Bruno Windels
5fb9276ef3
add togglePhase method, where we can show the panel if needed
...
without needing to resort to redispatching the original action
2019-04-10 13:20:03 +02:00
J. Ryan Stinnett
687b43f7b4
Merge pull request #2903 from jryans/rm-bottom-left-menu
...
Remove BottomLeftMenu and supporting bits
2019-04-09 19:09:07 +01:00
Travis Ralston
e4a9d4f5c8
Cache permalink creators out of the component's state
2019-04-09 12:01:09 -06:00
J. Ryan Stinnett
12f7d1715b
Remove BottomLeftMenu and supporting bits
...
The `BottomLeftMenu` component is not used in the new design. This removes the
component and also any images and sub-components that were only used by it.
2019-04-09 17:38:32 +01:00
Bruno Windels
0592a1711a
Merge pull request #2439 from matrix-org/matthew/retina
...
Fix for retina thumbnails being massive
2019-04-09 16:14:25 +00:00
Travis Ralston
daaedb8291
Merge pull request #2894 from matrix-org/travis/breadcrumbs/ratelimit
...
Send breadcrumb updates only when they change
2019-04-09 09:58:04 -06:00
Travis Ralston
44e33ba5f1
Merge pull request #2892 from matrix-org/travis/breadcrumbs/scrolling
...
Add some tolerances to breadcrumb scrolling
2019-04-09 09:41:07 -06:00
Travis Ralston
43362bfb98
Explain why the breadcrumbs don't need persisting elsewhere
2019-04-09 09:40:49 -06:00
J. Ryan Stinnett
a23900c29d
Merge pull request #2902 from jryans/auth-validation
...
Fix validation to avoid `undefined` class on fields
2019-04-09 16:25:24 +01:00
J. Ryan Stinnett
f2da833ac9
Fix validation to avoid undefined
class on fields
...
The class name handling for validation inadvertently added `undefined` as a
class when validation is not used. This rearranges the logic to avoid the issue.
Fixes https://github.com/vector-im/riot-web/issues/9345
2019-04-09 16:10:36 +01:00
Travis Ralston
12a9416741
Merge pull request #2895 from matrix-org/travis/return-client
...
Always return a client from onRegistered
2019-04-09 09:06:33 -06:00
Travis Ralston
35a20143ba
Merge pull request #2897 from matrix-org/travis/upgrades/touchups
...
Fix room upgrade warnings popping up in upgraded rooms
2019-04-09 09:06:17 -06:00
David Baker
0f1ebf8095
Factor out this device check & reorder conditionals
2019-04-09 13:47:25 +01:00
David Baker
7c1943ef4e
Key backup: Handle case where your onw sig is invalid
...
Sometimes life is just like that
2019-04-09 13:22:35 +01:00
Bruno Windels
15ba24f7fb
Merge branch 'develop' into matthew/retina
2019-04-09 10:55:05 +02:00
David Baker
babed3e5ee
Merge pull request #2891 from matrix-org/dbkr/simplify_settings_dialog_css
...
Simplify settings dialog CSS
2019-04-09 09:21:21 +01:00
Travis Ralston
c49afe4d72
Use dedicated permalink creators in search results with multiple rooms
...
Fixes https://github.com/vector-im/riot-web/issues/9376
This also would have happened in "All Rooms" searches.
2019-04-08 16:23:00 -06:00
Travis Ralston
4beecb50c9
Fix room upgrade warnings popping up in upgraded rooms
...
Rooms which are already upgraded shouldn't be asked to upgrade. Additionally, this fixes a bug where the room upgrade dialog would stay open even after upgrading the room.
2019-04-08 15:39:36 -06:00
Travis Ralston
7407950c75
Always return a client from onRegistered
...
Fixes https://github.com/vector-im/riot-web/issues/9406
The return value of onRegistered eventually ends up in the pusher setup, which means we were passing undefined through the stack.
2019-04-08 12:49:14 -06:00
David Baker
a04c15d131
consistent comments
2019-04-08 19:10:20 +01:00
Travis Ralston
bf0605cf84
Send breadcrumb updates only when they change
...
Fixes an issue where hovering over the breadcrumbs could cause hundreds of web requests due to updates. This also fixes https://github.com/vector-im/riot-web/issues/9390 as the update is more reliable.
2019-04-08 11:17:27 -06:00
Travis Ralston
aa96fd27cc
Add some tolerances to breadcrumb scrolling
...
See https://github.com/vector-im/riot-web/issues/9400
See https://github.com/vector-im/riot-web/issues/9394
Tolerances are defined as a device-only setting to give advanced users an option to override the values. No UI is exposed for this.
The default values are picked for assumptions on comfort, however as people change the tolerances themselves the defaults may need to change.
2019-04-08 10:56:44 -06:00
David Baker
59210564b7
Fix upload cancel in e2e rooms
...
This is a bit of a mess of passing promises around - we weren't
taking the right promise to pass to cancelUpload.
Also e2e uploads take time to read into memory & encrypt, so allow
cancelling them during those phases too, even though we can't abort
those phases before they're done - we do mark the upload as cancelled
though so filter the current uploads for cancelled ones.
Fixes https://github.com/vector-im/riot-web/issues/4891
2019-04-08 17:53:39 +01:00
J. Ryan Stinnett
054011f5f8
Merge pull request #2890 from jryans/guard-missing-crypto
...
Set E2E room status to warning when crypto is disabled
2019-04-08 16:56:19 +01:00
David Baker
670f6e4f99
Simplify settings dialog CSS
...
Stop the settings dialogs from requiring special styles on the
mx_Dialog which required passing in a classname from anywhere the
settings dialogs were opened (although this still requires
static=true). Some of the things have now been adopted for all dialogs
(border-radius), others have been moved to within the dialog content.
2019-04-08 16:48:42 +01:00
J. Ryan Stinnett
20c31082b5
Set E2E room status to warning when crypto is disabled
...
When crypto is disabled for the current device, we can't tell whether there are
unverified devices since we aren't tracking devices at all.
Let's be safe and default to the warning state.
See also https://github.com/matrix-org/matrix-js-sdk/pull/889
2019-04-08 16:28:19 +01:00
Andrew Morgan
77515f0b58
Remove duplicate space in credits
2019-04-08 14:40:08 +01:00
Bruno Windels
45f3282b1b
cleanup and linting
2019-04-08 14:57:39 +02:00
Travis Ralston
4ec2035f09
Merge pull request #2881 from matrix-org/travis/split-as-directory
...
Don't include all networks by default in the room directory
2019-04-08 06:55:39 -06:00
David Baker
3fe6d51fbe
Merge pull request #2868 from matrix-org/dbkr/dialog_redesign
...
Design tweaks to dialogs
2019-04-08 09:33:34 +01:00
Travis Ralston
b59de78129
Don't include all networks by default in the room directory
...
Fixes https://github.com/vector-im/riot-web/issues/9285
2019-04-05 10:50:01 -06:00
Travis Ralston
650185e578
Remove 'try the app' link from login
...
Fixes https://github.com/vector-im/riot-web/issues/8384
This will be re-addressed in https://github.com/vector-im/riot-web/issues/9388 or similar. Because the implementation is undefined, the dead code is being removed instead of just left dead.
2019-04-05 10:35:11 -06:00
Travis Ralston
6a8b98eb71
Merge pull request #2877 from matrix-org/travis/breadcrumbs/scroll-left
...
Translate vertical scrolling to horizontal movement in breadcrumbs
2019-04-05 09:51:13 -06:00
Travis Ralston
17a57eb3e5
Bind the onWheel listener directly to props
...
React doesn't seem to care if this is null/undefined.
2019-04-05 09:43:29 -06:00
Travis Ralston
1c41c3dd63
Only update analytics when there's a change
...
Also, the arguments are the previous state, not the new state.
2019-04-05 09:40:21 -06:00
Travis Ralston
e2edae3383
Merge branch 'develop' into travis/breadcrumbs/telemetry
2019-04-05 09:35:38 -06:00
David Baker
41c403c9a6
Merge pull request #2879 from matrix-org/dbkr/file_upload_fallout
...
Fix a few bugs introduced in file upload rework
2019-04-05 15:48:45 +01:00
Travis Ralston
4815aa6de9
Merge pull request #2875 from matrix-org/travis/breadcrumbs/mobile
...
Sync breadcrumb rooms through account data
2019-04-05 08:21:57 -06:00
Travis Ralston
2f8c0cb4e9
Merge pull request #2878 from matrix-org/travis/breadcrumbs/auto-scroll-left
...
Scroll breadcrumbs to the left when they change
2019-04-05 08:18:00 -06:00
Travis Ralston
223498a979
Merge pull request #2874 from matrix-org/travis/breadcrumbs/dms
...
Add an indicator to show a room is a direct chat in breadcrumbs
2019-04-05 08:15:12 -06:00
Travis Ralston
98b35d106b
Merge pull request #2872 from matrix-org/travis/breadcrumbs/upgrades
...
Use the most recent version of the room in breadcrumbs
2019-04-05 08:12:51 -06:00
David Baker
c8ba7d3434
Fix a few bugs introduced in file upload rework
...
* Fix the widget picture_snapshot command (not that I can find
anything that uses it)
* Remove unused prop
* Fix plural on ContentMessages
2019-04-05 15:09:07 +01:00
Bruno Windels
f1b00dff35
Merge branch 'develop' into matthew/retina
2019-04-05 13:35:54 +02:00
Travis Ralston
04b521c48b
Scroll breadcrumbs to the left when they change
...
Fixes https://github.com/vector-im/riot-web/issues/9355
2019-04-04 17:03:06 -06:00
Travis Ralston
138fd4ec87
Translate vertical scrolling to horizontal movement in breadcrumbs
...
Fixes https://github.com/vector-im/riot-web/issues/9314
2019-04-04 16:43:04 -06:00
Travis Ralston
b7e557e49a
Autohide the scrollbar on breadcrumbs
...
Fixes https://github.com/vector-im/riot-web/issues/9349
2019-04-04 16:27:00 -06:00
Travis Ralston
64a22236c3
Handle cases where the user rapidly clicks between rooms
...
Once the user has breadcrumbs, there should always be breadcrumbs. Therefore it is safe to ignore any updates which have zero entries.
2019-04-04 16:21:57 -06:00
Travis Ralston
406196e11c
Move import to avoid future merge conflicts
2019-04-04 15:10:17 -06:00
Travis Ralston
edc24c6a91
Move import to avoid future merge conflicts
2019-04-04 15:08:38 -06:00
Travis Ralston
44198ea97d
Sync breadcrumb rooms through account data
...
Fixes https://github.com/vector-im/riot-web/issues/9315
Other clients would need to listen for and update im.vector.riot.breadcrumb_rooms in account data.
2019-04-04 15:06:03 -06:00
Travis Ralston
095e6a3ba6
Add an indicator to show a room is a direct chat
...
Fixes https://github.com/vector-im/riot-web/issues/8797
2019-04-04 14:31:23 -06:00
Travis Ralston
035f6b14c0
Add telemetry for how many people use breadcrumbs
...
Fixes https://github.com/vector-im/riot-web/issues/9207
2019-04-04 14:17:15 -06:00
Travis Ralston
2496ee3b66
Merge branch 'travis/breadcrumbs/livereload' into travis/breadcrumbs/telemetry
2019-04-04 13:55:22 -06:00
Travis Ralston
68fc04d9f6
Use the most recent version of the room in breadcrumbs
...
Fixes https://github.com/vector-im/riot-web/issues/8662
2019-04-04 13:45:20 -06:00
Matthew Hodgson
d45f43144f
Merge pull request #2869 from matrix-org/matthew/redacted_tombstones
...
fix NPE for rooms with redacted tombstones
2019-04-04 16:53:31 +01:00
Travis Ralston
a61ab4eb4e
Merge pull request #2862 from matrix-org/travis/stickerpicker/remount
...
Don't re-init the stickerpicker unless something actually changes
2019-04-04 09:46:38 -06:00
Travis Ralston
9618187d2e
Merge pull request #2855 from YaoiFangirl420/rotate_images
...
Add option to rotate images
2019-04-04 09:46:06 -06:00
Travis Ralston
6722451207
semicolon
2019-04-04 09:36:45 -06:00
Travis Ralston
f2b7042a33
misc cleanup
2019-04-04 09:30:15 -06:00
Travis Ralston
5066d68875
Merge pull request #2861 from matrix-org/travis/breadcrumbs/badges
...
Add badges to breadcrumb rooms
2019-04-04 08:24:41 -06:00
J. Ryan Stinnett
cf69692d9e
Merge pull request #2866 from jryans/member-info-power
...
Include the current power level in the selector
2019-04-04 11:38:42 +01:00
J. Ryan Stinnett
fea9b009b3
Track life buoy dialog
2019-04-04 11:28:13 +01:00
J. Ryan Stinnett
b0f59007f3
Clarify level
variable name
2019-04-04 10:30:23 +01:00
YaoiFangirl420
1cbbe5f31f
Add i18n and fix method declaration
...
Add i18n entries for rotating images; fix the way `getName` is defined
Signed-off-by: YaoiFangirl420 <48789208+YaoiFangirl420@users.noreply.github.com>
2019-04-04 02:27:58 -07:00
YaoiFangirl420
9bd1ba60f5
Add option to rotate images
...
cf. https://github.com/vector-im/riot-web/issues/9257
Add rotate clockwise/counterclockwise buttons to <ImageView>
Signed-off-by: YaoiFangirl420 <48789208+YaoiFangirl420@users.noreply.github.com>
2019-04-04 01:48:41 -07:00
Travis Ralston
10369170ed
Use a static prop on Stickerpicker to track the current widget
2019-04-03 17:16:56 -06:00
Travis Ralston
ad777782b8
Merge branch 'develop' into travis/stickerpicker/remount
2019-04-03 17:00:19 -06:00
Travis Ralston
f73c32e6c2
Track notifications in component state
2019-04-03 16:13:09 -06:00
Travis Ralston
f5600fd4d7
Add badges to breadcrumb rooms
...
Fixes https://github.com/vector-im/riot-web/issues/8606
2019-04-03 15:29:15 -06:00
Matthew Hodgson
e98ef0d537
only show continues link if tombstone has a continuation
2019-04-03 21:12:36 +01:00
David Baker
7925e7169a
Design tweaks to dialogs
...
Little bit of a mix of things in this one:
* Support variable-width dialogs. Default is fixed-width as before,
only UploadConformDialog is variable-width. Controlled by a prop
to BaseDialog.
* Fixes to the cancel 'x' - scale the mask image, tweak size & colour
* Colour & boldness of dialog titles
* Align the dialog title & cancel 'x'
* Remove gap between dialog buttons & right hand side of dialog(!)
* Round corners on dialogs
* Add grey border on image preview in upload confirm dialog
* and, squeezing in slightly randomly, finish the partially renamed
ChatInviteDialog to AddressPickerDialog.
2019-04-03 16:27:45 +01:00
Travis Ralston
c3d3dd1fd7
Merge pull request #2860 from matrix-org/travis/breadcrumbs/parted
...
Apply 50% opacity to left breadcrumbs
2019-04-03 08:42:39 -06:00
J. Ryan Stinnett
fa88185dee
Include the current power level in the selector
...
This ensures we always include the current power level in the power selector,
even if it's greater than the level you're allowed to set yourself. This ensures
the selector can display the current value correctly when disabled.
Fixes https://github.com/vector-im/riot-web/issues/9340
2019-04-03 11:54:10 +01:00
Bruno Windels
a11786884e
Merge pull request #2865 from matrix-org/bwindels/smallscrollfixes
...
Small scroll fixes
2019-04-03 07:29:13 +00:00
Bruno Windels
fee8d79267
comment for PAGE_SIZE
2019-04-03 09:16:30 +02:00
Travis Ralston
c0f06602c5
Use state instead of forceUpdate
2019-04-02 10:47:39 -06:00
Travis Ralston
8225b91179
Merge pull request #2863 from matrix-org/travis/stickerpicker/lower-z
...
Put the stickerpicker below dialogs
2019-04-02 10:23:17 -06:00
Bruno Windels
86c13b97ce
increase PAGE_SIZE so users can scroll up already while waiting for pag.
2019-04-02 17:54:14 +02:00
Bruno Windels
726e91101a
allow fractional values for scrollTop above and below expected value
2019-04-02 17:53:53 +02:00
David Baker
24ccfa69f4
Merge pull request #2858 from matrix-org/dbkr/upload_redesign
...
Implement redesigned upload confirmation screens
2019-04-02 11:00:16 +01:00
David Baker
b6faaf419c
PR feedback
2019-04-02 10:50:17 +01:00
Travis Ralston
3f9d088667
Put the stickerpicker below dialogs
...
Fixes https://github.com/vector-im/riot-web/issues/9353
The ContextualMenu now accepts a zIndex parameter which can be used to control its level. Dialogs are at around 4000 in the z-index, and the context menu defaults to 5000 for the things that need tooltips and such in a dialog.
2019-04-01 20:34:33 -06:00
Travis Ralston
51750cf153
General cleanup of handling for WidgetMessaging instances
...
When setting, delete the old one. Because delete checks if it exists first, we can safely call this.
The change in FromWidgetPostMessageApi is just something noticed while debugging.
2019-04-01 19:50:05 -06:00
Travis Ralston
a4f76670c4
Don't re-init the stickerpicker unless something actually changes
...
Fixes https://github.com/vector-im/riot-web/issues/9354
https://github.com/matrix-org/matrix-react-sdk/pull/2801 introduced a change which tried to make sure that when the widget URL was changed that the picker would be re-mounted, however it accidentally introduced a regression. While it effectively did the task it wanted to, it failed to keep the previously-mounted sticker picker alive. This is because the Stickerpicker component is remounted when opened, and the _updateWidget function is called. This results in this.state not having the "current" widget, meaning a URL change is always detected when the component is remounted (room changes, open sticker picker).
Instead of remounting always, we'll instead track which sticker picker widget is being used out of band. This therefore means that whenever the Stickerpicker component is mounted it doesn't create a whole new widget, and the existing (background) picker can be used. This also fixes the loading screen that people would see when opening the sticker picker after switching rooms, something which the persistent widget stuff is supposed to solve.
2019-04-01 19:48:05 -06:00
Travis Ralston
7e2291592c
Apply 50% opacity to left breadcrumbs
...
Fixes https://github.com/vector-im/riot-web/issues/8564
We listen for membership changes to make sure the state is kept up to date.
2019-04-01 11:59:39 -06:00
Travis Ralston
842e19280d
Apply changes to breadcrumbs setting live
2019-04-01 11:49:58 -06:00
J. Ryan Stinnett
d92336fc16
Merge pull request #2859 from jryans/redesign-debug-logs
...
Use Field component in bug report dialog
2019-04-01 18:33:22 +01:00
J. Ryan Stinnett
3948520eaa
Use Field component in bug report dialog
...
This uses the field component in the bug report dialog, which generally improves
the styling to fit in more naturally with the rest of the app so that it feels
more trustworthy.
Fixes https://github.com/vector-im/riot-web/issues/9343
2019-04-01 17:50:12 +01:00
J. Ryan Stinnett
57d72b4deb
Merge pull request #2841 from jryans/storage-eviction-modal
...
Notify user when crypto data is missing
2019-04-01 17:31:39 +01:00
David Baker
0add3d0825
Translate into peoplecounting
2019-04-01 16:52:06 +01:00
David Baker
fedd4598b5
Space
...
The final frontier
2019-04-01 16:50:23 +01:00
David Baker
5b2cee2fc1
Implement redesigned upload confirmation screens
...
Also fairly significant refactor of the uploading code: there are
a number of different ways of triggerring a file upload and each
went through a different code path (the media config size limit
worked on one of those paths). Basically take a lot of code out
of the views and put it into ContentMessages.
Sorry about the size of this patch.
https://github.com/vector-im/riot-web/issues/7565
2019-04-01 16:42:41 +01:00
Travis Ralston
db66d27969
Merge pull request #2847 from matrix-org/travis/pdf-blob
...
Download PDFs as blobs to avoid empty grey screens
2019-03-29 16:05:07 -06:00
Travis Ralston
8d14dc4e26
Don't send options we don't need to fetch
2019-03-29 15:48:33 -06:00
Travis Ralston
fc28f094fe
Set title attribute on images in lightbox
...
Part of https://github.com/vector-im/riot-web/issues/9324
2019-03-29 14:55:56 -06:00
Travis Ralston
62ba7dde94
Download PDFs as blobs to avoid empty grey screens
...
Fixes https://github.com/vector-im/riot-web/issues/8605
The grey screen of sadness comes up when Chrome tries to open the PDF but doesn't have the right CSP headers. To avoid this, we'll just force a download of the PDF through `fetch` and `Blob`.
There are a few cases where the user might still get a grey screen though: namely if they open the URL in a new tab or when the event content is lying about the file type, or the file is too large to blobify.
`fetch` works in Chrome, Firefox, and our packaged Electron version.
2019-03-29 14:12:48 -06:00
Travis Ralston
86e4d29582
Merge remote-tracking branch 'origin/develop' into travis/cancel-3pid
2019-03-29 11:47:46 -06:00
Travis Ralston
07cc640089
Add common utility for checking 3pid invites
...
We just need to make sure they are structurally sound - actual validation is done by other parties.
2019-03-29 11:45:07 -06:00
J. Ryan Stinnett
328f0cd6bf
Notify user when crypto data is missing
...
If we have account data in local storage but nothing in the crypto store, it
generally means the browser has evicted IndexedDB out from under us. This adds a
modal to explain the situation and offer to completely clear storage to get
things back to normal.
Fixes https://github.com/vector-im/riot-web/issues/9109
2019-03-29 16:06:08 +00:00
Bruno Windels
e7852ad1b4
Merge pull request #2846 from matrix-org/bwindels/atbottomfix
...
round scrollTop upwards to prevent never detecting bottom
2019-03-29 15:57:24 +00:00
Bruno Windels
8e4a06db77
round scrollTop upwards to prevent never detecting bottom
2019-03-29 16:41:10 +01:00
J. Ryan Stinnett
6e79cbc092
Delay Notifier
check until we have push rules
...
The `Notifier` class expects push rules to be available, so it can explode in
strange ways if called too early. This changes to wait until the sync is in the
`PREPARED` state (when push rules should be ready) before using the `Notifier`.
Fixes https://github.com/vector-im/riot-web/issues/9323
2019-03-29 15:19:39 +00:00
Bruno Windels
a326c83016
Merge pull request #2842 from matrix-org/bwindels/bacat-scrolling-merged-develop
...
BACAT Scrolling
2019-03-29 14:02:15 +00:00
Bruno Windels
f157838864
dispatch supports async dispatching on its own
2019-03-29 14:32:26 +01:00
Travis Ralston
0258f61f63
Fix typo preventing custom status from deregistering listeners on tiles
2019-03-28 21:02:24 -06:00
Travis Ralston
99dc2c4738
Add MemberInfo for 3pid invites and support revoking those invites
...
Fixes https://github.com/vector-im/riot-web/issues/625
Fixes https://github.com/vector-im/riot-web/issues/6411
Fixes https://github.com/vector-im/riot-web/issues/5490
2019-03-28 21:02:24 -06:00
Bruno Windels
1a264006f7
turn off debug logging
2019-03-28 18:42:49 +01:00
Travis Ralston
6eb8368aa7
Merge pull request #2827 from matrix-org/travis/v3-room-permalink
...
Handle all the segments of a v3 event ID
2019-03-28 11:38:47 -06:00
Bruno Windels
0a4ef44bcf
fix lint
2019-03-28 18:29:48 +01:00
Travis Ralston
acb33e1aa0
Merge pull request #2839 from matrix-org/travis/breadcrumbs/visual
...
Add custom tooltips and scrolling to breadcrumbs
2019-03-28 11:29:48 -06:00
Travis Ralston
a0e3182e47
Merge pull request #2829 from matrix-org/travis/unread-button
...
Check if the message panel is at the end of the timeline on init
2019-03-28 11:26:48 -06:00
Bruno Windels
41c5582a7b
make resizeNotifier optional so tests don't fail
2019-03-28 17:56:12 +01:00
Travis Ralston
87ca3069bb
Misc code cleanup
2019-03-28 10:43:01 -06:00
Travis Ralston
92c99546f6
Merge pull request #2837 from matrix-org/travis/breadcrumbs/persist
...
Persist breadcrumb state between sessions
2019-03-28 10:32:26 -06:00
Travis Ralston
f73556d278
Remove unnecessary params
2019-03-28 09:52:12 -06:00
Travis Ralston
6a840a56d6
Add a comment to explain the state of affairs for refs.messagePanel
2019-03-28 09:50:17 -06:00
Travis Ralston
9b64dd0cd7
Support horizontal scrolling on breadcrumbs
...
Fixes https://github.com/vector-im/riot-web/issues/8714
Fixes https://github.com/vector-im/riot-web/issues/8890
Fixes https://github.com/vector-im/riot-web/issues/9034
Fixes https://github.com/vector-im/riot-web/issues/8954
This turned out to be much more complicated than it needed to be. We use an IndicatorScrollbar to do all the math for us and some minor changes have been made so it can flag left/right overflow. The complicated part is the css changes which make the gradients work: unlike the RoomSubList, we have to calculate the offset of the indicators (gradients) on our own because position:sticky doesn't work horizontally.
The changes to the css (well, mostly pointer-events:none) make it so the gradient doesn't interfere with the room avatars.
9034 and 8954 are fixed by this because they represent an overflow-x:none style breakage where browsers won't let you scroll without a scrollbar. The gradient offset problem is also demonstrated in 8954.
2019-03-27 17:52:05 -06:00
Travis Ralston
90d7e82399
Use custom tooltips on breadcrumb icons
...
Fixes https://github.com/vector-im/riot-web/issues/9303
We have to track our own onHover for this, and out of safety we ensure that exactly 1 room is hovered at a time.
2019-03-27 17:51:48 -06:00
Travis Ralston
bbbf509a8c
Always append the current room to the breadcrumbs
...
Fixes https://github.com/vector-im/riot-web/issues/8659
Fixes https://github.com/vector-im/riot-web/issues/8970
2019-03-27 15:38:42 -06:00
Travis Ralston
c8e42d61f5
Persist breadcrumb state between sessions
...
Fixes https://github.com/vector-im/riot-web/issues/8549
2019-03-27 15:32:51 -06:00
Travis Ralston
64a6b47692
Merge pull request #2831 from matrix-org/travis/hidden-bing
...
Alert the user to unread notifications in prior versions of rooms
2019-03-27 13:23:57 -06:00
Travis Ralston
c94ae6401b
Use an AccessibleButton for the clickable element
2019-03-27 13:14:31 -06:00
Bruno Windels
82e44249ff
make resizeNotifier optional in MainSplit for GroupView
2019-03-27 16:38:17 +01:00
David Baker
1b8b3efece
Merge pull request #2835 from matrix-org/dbkr/no_no_referrer
...
Remove noreferrer on widget pop-out
2019-03-27 15:17:38 +00:00
J. Ryan Stinnett
055f833042
Change loading errors in room directory to inline instead of modal
...
This changes errors that may occur when loading the room directory so that the
message appears inline with the overall directory UI instead of in a new modal.
This is important so that the new room button remains on screen even if the
directory is down.
Fixes https://github.com/vector-im/riot-web/issues/9046
2019-03-27 14:57:41 +00:00
J. Ryan Stinnett
0466e0a306
Reorganise room directory code so new room is always available
...
This reorganises the room directory so that the new room buttons is always
available no matter what state the overall directory is in.
Part of https://github.com/vector-im/riot-web/issues/9046
2019-03-27 14:17:24 +00:00
J. Ryan Stinnett
8d27cfde36
Remove unused import
2019-03-27 13:57:48 +00:00
David Baker
1fe830d1c6
Remove noreferrer on widget pop-out
...
Having the referrer allows widgets to do customisation based on what
riot instance is embedding it. It gets a referrer when we embed it
in the iframe so there's nothing gained by suppressing it here.
2019-03-27 13:27:57 +00:00
Bruno Windels
adf263c4af
Merge branch 'develop' into bwindels/bacat-scrolling-merged-develop
2019-03-27 11:46:28 +01:00
Bruno Windels
5d53913e35
fix filling conditions
2019-03-27 11:35:38 +01:00
Travis Ralston
ddcb7a68bd
Merge pull request #2781 from matrix-org/travis/openid-widget
...
Widget OpenID reauth implementation
2019-03-27 03:42:39 -06:00
Travis Ralston
04a9038a05
Alert the user to unread notifications in prior versions of rooms
...
Fixes https://github.com/vector-im/riot-web/issues/8161
2019-03-26 19:22:41 -06:00
Travis Ralston
4eb9fa6922
Check if the message panel is at the end of the timeline on init
...
Fixes https://github.com/vector-im/riot-web/issues/8503
componentDidUpdate is called a lot, and we don't really want to keep checking the messagePanel, so this introduces a new flag to check if the init is even needed.
2019-03-26 14:22:48 -06:00
J. Ryan Stinnett
db834b315a
Merge pull request #2828 from jryans/notification-labels
...
Clarify devices affected by notification settings
2019-03-26 17:43:19 +00:00
J. Ryan Stinnett
f8dce875f2
Clarify devices affected by notification settings
...
This clarifies that the notification settings only apply to the current device.
This also tries to apply the spirit of
https://github.com/matrix-org/matrix-react-sdk/pull/1995 (authored by @aidalgol)
which wanted to remove "web" from the label, since there's also a desktop
client.
2019-03-26 17:39:07 +00:00
Bruno Windels
f2f3661b7e
more debug logging
2019-03-26 17:40:24 +01:00
Bruno Windels
46f5f872c4
implement scrolling to a token (best effort)
2019-03-26 15:51:02 +01:00
Travis Ralston
1703e3860b
Merge pull request #2822 from matrix-org/travis/minimize-widgets
...
Minimize stickerpicker when the title is clicked
2019-03-26 07:44:14 -06:00
Bruno Windels
805539fdc7
remove timestamp logging in profiler
2019-03-26 13:44:39 +01:00
Bruno Windels
82a9b348c0
add some comments and initialization for async filling
2019-03-26 13:39:18 +01:00
Bruno Windels
18b5041ed2
try filling async instead of sync in scroll handler
...
see if that avoids jumps
2019-03-26 12:19:30 +01:00
J. Ryan Stinnett
dbc4735b06
Merge pull request #2825 from YaoiFangirl420/develop
...
Add <code> blocks around homeserver and identity server urls
2019-03-26 09:35:56 +00:00
Travis Ralston
d8edf2e3fb
Handle all the segments of a v3 event ID
...
They may contain slashes, so it is not suitable to just pull the first segment after the room ID. Instead, we just recompile the event ID from known source, assuming everything afterwards is an event ID.
Fixes https://github.com/vector-im/riot-web/issues/8315
This will need adapting to support https://github.com/vector-im/riot-web/issues/9149
2019-03-25 23:02:49 -06:00
Travis Ralston
69fcebf045
Use allow/deny instead of whitelist/blacklist for terminology
2019-03-25 21:14:21 -06:00
Travis Ralston
79ea873717
Merge pull request #2820 from matrix-org/travis/timeline-explosion-workaround
...
Ask the user for debug logs when the timeline explodes
2019-03-25 12:09:16 -06:00
J. Ryan Stinnett
1e5c0a8713
Apply suggestions from code review
...
Co-Authored-By: turt2live <travpc@gmail.com>
2019-03-25 11:56:49 -06:00
J. Ryan Stinnett
3e676454b6
Update src/components/views/dialogs/TimelineExplosionDialog.js
...
Co-Authored-By: turt2live <travpc@gmail.com>
2019-03-25 11:33:31 -06:00
Travis Ralston
1172488cce
Merge pull request #2823 from matrix-org/travis/fix-add-widget-button
...
Fix typo preventing users from adding more widgets easily
2019-03-25 09:59:43 -06:00
Travis Ralston
0d5c98634d
Merge pull request #2817 from matrix-org/travis/blacklist-unverified-devices
...
Attach an onChange listener to the room's blacklist devices option
2019-03-25 09:59:29 -06:00
Travis Ralston
a9ea74610a
Merge pull request #2818 from matrix-org/travis/leave-room-chain
...
Use leaveRoomChain when leaving a room
2019-03-25 09:57:17 -06:00
Bruno Windels
8f7170a4a1
add timeline profiling markers when updateheight and onscroll run
2019-03-25 12:47:08 +01:00
YaoiFangirl420
f2b64a8e7f
Add <code> blocks around homeserver and identity server urls
...
To make the urls visually distinct from the surrounding non-url text
Signed-off-by: YaoiFangirl420 <48789208+YaoiFangirl420@users.noreply.github.com>
2019-03-24 02:05:04 -07:00
Travis Ralston
1ba23d6833
Fix typo preventing users from adding more widgets easily
...
Fixes https://github.com/vector-im/riot-web/issues/9266
2019-03-23 23:53:21 -06:00
Travis Ralston
a8ae63bb06
Minimize stickerpicker when the title is clicked
...
Fixes https://github.com/vector-im/riot-web/issues/6437
This also fixes a bug where if the room had apps open and you clicked the sticker picker's title, you'd end up closing the apps and not the picker.
2019-03-23 23:50:06 -06:00
Travis Ralston
3654c895eb
Appease the linter
2019-03-23 23:31:19 -06:00
Travis Ralston
2dcb40f1be
Track OpenID automatic permissions by (widgetLocation, widgetUrl)
2019-03-23 23:25:31 -06:00
Travis Ralston
d3268801ed
Merge branch 'develop' into travis/openid-widget
2019-03-23 22:48:12 -06:00
YaoiFangirl420
00335e2462
Fix bug with NetworkList dropdown
...
The NetworkDropdown component was incorrectly guarding against a null
check when retrieving the list of networks
Signed-off-by: YaoiFangirl420 <48789208+YaoiFangirl420@users.noreply.github.com>
2019-03-23 20:53:09 -07:00
Travis Ralston
e5f7563dec
Ask the user for debug logs when the timeline explodes
...
Fixes https://github.com/vector-im/riot-web/issues/9260
Workaround for https://github.com/vector-im/riot-web/issues/8593
Requires https://github.com/matrix-org/matrix-js-sdk/pull/869
We check if any dialogs are open before moving forward because we don't want to risk showing so many dialogs that the user is unable to click a button. We're also not overly concerned if the dialog being shown is irrelevant because whatever the user is doing will likely be unaffected, and we can scream in pain when they're finished.
2019-03-22 20:23:35 -06:00
Travis Ralston
389abed574
Define a title for generic error
2019-03-22 19:03:52 -06:00
Travis Ralston
4fd48988e9
Check for any errors leaving the room, not just the top level
2019-03-22 17:39:42 -06:00
Travis Ralston
a34a8bb425
Use leaveRoomChain when leaving a room
...
Requires https://github.com/matrix-org/matrix-js-sdk/pull/868
Fixes https://github.com/vector-im/riot-web/issues/8539
We don't need to use leaveRoomChain when rejecting invites because we won't have the references needed. This leaves the couple spots where we do actually leave a room, and use the new function for that.
2019-03-22 17:36:54 -06:00
Travis Ralston
50614fa7fb
Attach an onChange listener to the room's blacklist devices option
...
Fixes https://github.com/vector-im/riot-web/issues/9235
The global option in user settings is unaffected by this bug. Users who have previously set the per-room flag without success can simply refresh the page and the change will be picked up. The bug here is that the current session would not update accordingly, however.
Introduced in https://github.com/matrix-org/matrix-react-sdk/pull/2523
2019-03-22 14:22:20 -06:00
J. Ryan Stinnett
c17f7a2949
Trim the logging for URL previews
...
It should be sufficient to have the error stack and general log message for URL
preview failure.
2019-03-22 18:50:08 +00:00
Bruno Windels
c9c2519240
log scroll events
2019-03-22 15:47:04 +01:00
Bruno Windels
4bfdbe3094
fix jumping when unfilling the top while scrolling down
2019-03-22 15:23:21 +01:00
Bruno Windels
ab49bc4fcf
fix comment typo
2019-03-21 15:37:35 +01:00
Bruno Windels
680afc5ce0
fix scrollToToken alignment
2019-03-21 15:37:06 +01:00
Bruno Windels
494779393f
Merge branch 'develop' into bwindels/bacat-scrolling
2019-03-21 13:50:32 +01:00
Bruno Windels
44f3cac5eb
Merge branch 'master' into develop
2019-03-21 11:28:35 +01:00
Bruno Windels
817fe1a520
disable typing notifs jumping prevention for now
2019-03-21 11:01:47 +01:00
David Baker
324781005d
Merge pull request #2808 from matrix-org/dbkr/velocity-mainline
...
Go back to using mainine velocity
2019-03-20 19:01:20 +00:00
Bruno Windels
3e13a11372
restore scroll position after hiding typing notifs with checkScroll
2019-03-20 17:38:05 +01:00
Bruno Windels
85d305430f
no need for forceUpdate here
2019-03-20 17:37:34 +01:00
Bruno Windels
02a5aa3b1f
more logging cleanup
2019-03-20 17:15:43 +01:00
Bruno Windels
9da13fe430
small cleanup
2019-03-20 17:13:09 +01:00
Bruno Windels
a8b149cfbb
cleanup scrollpanel logging
2019-03-20 17:12:49 +01:00
Bruno Windels
460f9a5959
comment typo
2019-03-20 17:10:38 +01:00
Bruno Windels
f164a78eaa
reimplement typing notif timeline shrinking prevention
...
instead of setting a min-height on the whole timeline,
track how much height we need to add to prevent shrinking
and set paddingBottom on the container element of the timeline.
2019-03-20 17:10:30 +01:00
Travis Ralston
94e91e6f9a
Merge pull request #2796 from matrix-org/travis/upgrade-warning
...
Warn that members won't be autojoined to upgraded rooms
2019-03-20 08:34:33 -06:00
David Baker
1a8fe4dd43
Go back to using mainine velocity
...
We moved off to our own fork of velocity many moons ago to fix
a memory leak bug when velocity was being barely maintained. They
have now merged the bugfix, so go back to mainline.
2019-03-20 10:54:06 +00:00
Bruno Windels
1e372aad47
only log when node was found
2019-03-20 11:10:04 +01:00
Bruno Windels
c306181fcd
take into account that node might not be in DOM while updating height
2019-03-20 11:00:27 +01:00
Bruno Windels
88f039fe44
keep track of current updateHeight request outside of method
...
it's only called from one place
2019-03-20 10:59:55 +01:00
Bruno Windels
2bcced72ad
take (potentially clipped) content height into account for filling
2019-03-19 16:51:39 +01:00
Bruno Windels
469511aa44
correctly calculate last node in viewport
...
these variables are now relative to bottom of timeline,
before it was the top
2019-03-19 16:50:55 +01:00
Travis Ralston
9f6b550caa
Merge pull request #2801 from matrix-org/travis/renew-widget
...
Discard old sticker picker when the URL changes
2019-03-19 08:50:33 -06:00
Travis Ralston
d713c62774
Merge pull request #2799 from matrix-org/travis/widget-reload
...
Reload widget messaging when widgets reload
2019-03-19 08:49:24 -06:00
Bruno Windels
71f6b08b26
first impl of new scrolling, still a bit broken
2019-03-19 13:42:22 +01:00
Travis Ralston
6a7e4ba52c
Merge pull request #2806 from matrix-org/t3chguy/explicit_room_name_settings
...
Don't show calculated room name in room settings name input field
2019-03-18 20:32:11 -06:00
Michael Telatynski
cadf36e1c9
Don't show calculated room name in room settings name input field
...
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
2019-03-18 23:33:24 +00:00
Michael Telatynski
d6f31bef8e
Disable big emoji for m.emote messages as it looks weird
...
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
2019-03-18 23:25:11 +00:00
Michael Telatynski
5771406dd7
Add View Servers in Room to Devtools
...
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
2019-03-18 23:21:21 +00:00
Bruno Windels
d84003ac44
dont break room directory and search
2019-03-18 14:05:56 +01:00
Travis Ralston
a397f333d7
Discard old sticker picker when the URL changes
...
Fixes https://github.com/vector-im/riot-web/issues/7547
2019-03-16 16:02:38 -06:00
David Baker
591a968368
Update CustomRoomTagPanel.js
2019-03-16 12:37:34 +00:00
Travis Ralston
b68960ad26
Reload widget messaging when widgets reload
...
Fixes a bug for some widgets where they cannot do their startup routine (capabilities negotiation, etc) when someone maximizes the widget. By reloading the widget messaging, we ensure the widget is kept in the loop.
2019-03-15 22:24:27 -06:00
Travis Ralston
b48842e070
Fix imports for linter
2019-03-15 21:51:19 -06:00
Travis Ralston
f045beafc3
Support whitelisting/blacklisting widgets for OpenID
2019-03-15 21:33:31 -06:00
Travis Ralston
27c9b24cab
Appease more of the linter
2019-03-15 16:44:27 -06:00