Alexander Blair
5402121323
Merge pull request #7180
...
56748e1d7
ban lists may now include subnets (moneromooo-monero)
2020-12-26 13:42:37 -08:00
Alexander Blair
d06bae56b3
Merge pull request #7173
...
d2fda6c25
restrict public node checks a little (moneromooo-monero)
2020-12-26 13:41:42 -08:00
Alexander Blair
609dbe6b92
Merge pull request #7154
...
cf7e1571d
protocol: reject claimed block hashes that already are in the chain (moneromooo-monero)
af0a25544
protocol: drop peers we can't download anything from in sync mode (moneromooo-monero)
2020-12-26 13:40:36 -08:00
Alexander Blair
cb712bf4f8
Merge pull request #7145
...
68637bca3
p2p: remove peers from grey and anchors lists when blocked (moneromooo-monero)
2020-12-26 13:40:19 -08:00
Alexander Blair
69ed0e0001
Merge pull request #7138
...
e9abfea16
Optional DNS based blocklist (moneromooo-monero)
2020-12-26 13:38:50 -08:00
Alexander Blair
b9e444da5e
Merge pull request #7098
...
c0c75ac19
Fixed issues found by static analysis (SChernykh)
2020-12-26 13:36:01 -08:00
Alexander Blair
133056f625
Merge pull request #7086
...
14bc5c095
db_lmdb: move spammy "not found in db" message to TRACE (moneromooo-monero)
2020-12-26 13:35:42 -08:00
Alexander Blair
d365f2409a
Merge pull request #6931
...
fbb03ef2a
simplewallet: add "address mnew" command (codesoap)
2020-12-26 13:35:24 -08:00
codesoap
fbb03ef2a0
simplewallet: add "address mnew" command
2020-12-26 19:33:11 +01:00
moneromooo-monero
efe83982d3
protocol: drop nodes if they claim new data but only give stale data
...
Some joker is spending time actually doing this
2020-12-25 20:30:39 +00:00
benevanoff
50ff1066f5
wallet api: allow wallet to fetch all key images via api
2020-12-25 00:40:50 -06:00
moneromooo-monero
d2fda6c25f
restrict public node checks a little
...
do not include blocked hosts in peer lists or public node lists by default,
warn about no https on clearnet and about untrusted peers likely being spies
2020-12-22 23:39:07 +00:00
Lee Clagett
927141bcc4
Command max_bytes moved from dynamic map to static switch
2020-12-22 20:54:16 +00:00
moneromooo-monero
56748e1d74
ban lists may now include subnets
2020-12-22 02:12:41 +00:00
moneromooo-monero
e9abfea165
Optional DNS based blocklist
...
If enabled, pulls IPs to block on blocklist.moneropulse.*, and
blocks then for 8 days (so IPs dropping from the list will
eventually get unblocked, and DNS failures don't result in
instant clearing of the blocklist).
Enable with --enable-dns-blocklist
2020-12-20 02:09:58 +00:00
luigi1111
0dac64afb3
Merge pull request #7143
...
58651d1
p2p: ignore incoming peer list entries when we have them blocked (moneromooo-monero)
2020-12-19 17:24:21 -06:00
luigi1111
e0d8af253e
Merge pull request #7141
...
9de3787
daemon: the ban command can now load IPs from a file (ban @filename) (moneromooo-monero)
2020-12-19 17:22:01 -06:00
luigi1111
7ee37e4b38
Merge pull request #7075
...
f3c0d4f
protocol: remove unused (and cunningly uninitialized) field (moneromooo-monero)
8e62362
p2p: ifx getting seed nodes for uncommon cases (moneromooo-monero)
2020-12-19 17:20:29 -06:00
moneromooo-monero
5a1ac9c0ef
rpc: add a busy_syncing field to get_info
...
true if and pretty much only if new blocks are being added
2020-12-17 18:03:11 +00:00
moneromooo-monero
cf7e1571d3
protocol: reject claimed block hashes that already are in the chain
2020-12-17 02:54:02 +00:00
Lee Clagett
61b6e4cc67
Add aggressive restrictions to pre-handshake p2p buffer limit
2020-12-17 00:36:10 +00:00
moneromooo-monero
af0a25544e
protocol: drop peers we can't download anything from in sync mode
...
instead of the (incorrect) check for whether we think we might have
a user for it at some point in the near future. We can reconnect.
2020-12-16 20:19:52 +00:00
moneromooo-monero
f3c0d4f9df
protocol: remove unused (and cunningly uninitialized) field
2020-12-15 01:32:18 +00:00
moneromooo-monero
8e62362cd3
p2p: ifx getting seed nodes for uncommon cases
...
The code is technically correct, but liable to easily become incorrect with changes
2020-12-15 01:32:15 +00:00
moneromooo-monero
9de3787c47
daemon: the ban command can now load IPs from a file (ban @filename)
2020-12-14 12:26:23 +00:00
moneromooo-monero
68637bca3f
p2p: remove peers from grey and anchors lists when blocked
2020-12-13 23:27:44 +00:00
moneromooo-monero
58651d16c0
p2p: ignore incoming peer list entries when we have them blocked
2020-12-13 23:14:05 +00:00
luigi1111
e5decd0cde
Merge pull request #7130
...
543733d
protocol: include first new block in chain entry response (moneromooo-monero)
2020-12-12 22:05:02 -06:00
luigi1111
a57c95b2f1
Merge pull request #7127
...
5d1849a
protocol: stricter checks on received chain hash list (moneromooo)
2020-12-12 22:03:12 -06:00
moneromooo-monero
543733d42c
protocol: include first new block in chain entry response
2020-12-12 01:36:35 +00:00
moneromooo
5d1849a9eb
protocol: stricter checks on received chain hash list
2020-12-11 18:47:40 +00:00
moneromooo-monero
62e8ca5eaf
protocol: revert incoming chain height check against local chain
...
We can actually request a chain that's further away from what we
have as we buffer more and more
2020-12-11 02:37:15 +00:00
Alexander Blair
0f67569279
Merge pull request #7121
...
cd7e9769d
protocol: one more sanity check on usable data from a peer (moneromooo-monero)
2020-12-10 17:44:54 -08:00
Alexander Blair
bdaadf85dc
Merge pull request #7117
...
5dee031b2
protocol: add a sanity check to the number of block hashes sent (moneromooo-monero)
2020-12-10 17:43:41 -08:00
Alexander Blair
bb6d2d4b05
Merge pull request #7114
...
eb77790df
protocol: fix asking for pruned blocks for v10 (moneromooo-monero)
2020-12-10 17:42:48 -08:00
Alexander Blair
28e5e42986
Merge pull request #7110
...
d660f22ed
protocol: drop origin IP if a block fails to verify in sync mode (moneromooo-monero)
2020-12-10 17:41:59 -08:00
Alexander Blair
5b62a6f316
Merge pull request #7106
...
0f34cabb9
protocol: more restrictive checks on chain entry response (moneromooo-monero)
2020-12-10 17:40:46 -08:00
Alexander Blair
1e9483a2d5
Merge pull request #7009
...
7414e2bac
Change epee binary output from std::stringstream to byte_stream (Lee Clagett)
2020-12-10 17:34:50 -08:00
moneromooo-monero
cd7e9769d8
protocol: one more sanity check on usable data from a peer
2020-12-10 23:02:06 +00:00
moneromooo-monero
d660f22ed1
protocol: drop origin IP if a block fails to verify in sync mode
...
It would otherwise be possible for a peer to send bad blocks,
then disconnect and reconnect again, escaping bans
2020-12-10 21:59:18 +00:00
moneromooo-monero
dd5e689533
protocol: add calls to reserve where appropriate
2020-12-10 20:47:35 +00:00
moneromooo-monero
5dee031b25
protocol: add a sanity check to the number of block hashes sent
2020-12-10 19:26:12 +00:00
moneromooo-monero
eb77790dfb
protocol: fix asking for pruned blocks for v10
...
Old format is still alloewd there, this is a two fork update
2020-12-10 18:10:45 +00:00
moneromooo-monero
7f30c49731
simplewallet: don't complain about connecting to the daemon when offline
2020-12-10 17:57:13 +00:00
moneromooo-monero
0f34cabb98
protocol: more restrictive checks on chain entry response
2020-12-10 17:23:50 +00:00
moneromooo-monero
47590fc80b
rpc: report target height as 0 when synced
...
since it only makes sense when syncing, and it confuses people
2020-12-10 17:05:34 +00:00
moneromooo-monero
19f77578e0
protocol: fix switchting to adding blocks if noone's adding the next span
2020-12-10 15:46:48 +00:00
SChernykh
c0c75ac19d
Fixed issues found by static analysis
...
- rolling_median: tried to free uninitialized pointer in a constructor
- net_node.inl: erase-remove idiom was used incorrectly. remove_if doesn't actually remove elements, see http://cpp.sh/6fcjv
- bulletproofs.cc: call to sizeof() instead of vector.size(), luckily it only impacts performance and not code logic there
2020-12-08 18:43:44 +01:00
luigi1111
b7425c14c8
Merge pull request #7072
...
bc7cd78
p2p: drop peers that spam peer lists (moneromooo-monero)
2020-12-07 10:24:30 -06:00
luigi1111
fb73f2b2be
Merge pull request #7070
...
281b42a
p2p: fix race condition accessing a deleted context (moneromooo-monero)
2020-12-07 10:23:24 -06:00
luigi1111
3d2a50a5c0
Merge pull request #7055
...
ff7fdf6
protocol: drop peers that don't reply to queries (moneromooo-monero)
89e984d
keep only the last seen node on a given host in the white list (moneromooo-monero)
c74d8ff
protocol: drop peers that decrease claimed height (moneromooo-monero)
61f5001
protocol: add scoring system to drop peers that don't behave (moneromooo-monero)
2020-12-07 10:07:33 -06:00
moneromooo
ff7fdf6db2
protocol: drop peers that don't reply to queries
2020-12-06 15:57:40 +00:00
moneromooo-monero
281b42a281
p2p: fix race condition accessing a deleted context
2020-12-06 12:40:07 +00:00
moneromooo-monero
14bc5c095c
db_lmdb: move spammy "not found in db" message to TRACE
...
These are functions that check whether a tx is in the db, so whether
it is there or not is really not interesting, and it seems to scare
people from time to time
2020-12-06 01:46:21 +00:00
moneromooo-monero
bc7cd78870
p2p: drop peers that spam peer lists
...
There's always some people who just want to abuse things
2020-12-05 13:12:58 +00:00
Alexander Blair
7ca4ef0d74
Merge pull request #7068
...
2395e0e67
p2p: add a tor seed node (moneromooo-monero)
2020-12-04 13:28:02 -08:00
Alexander Blair
42aa1a6aca
Merge pull request #7062
...
5ed604fe5
crypto: fix non zero scalar being 0 after reducing (moneromooo-monero)
2020-12-04 13:27:05 -08:00
Alexander Blair
6b8db83149
Merge pull request #7043
...
17c537039
wallet2: check imported multisig curve points are in main subgroup (Crypto City)
2020-12-04 13:25:01 -08:00
Alexander Blair
ce564e7ebf
Merge pull request #7030
...
0363476ee
rpc: get_info - add 'synchronized' field (xiphon)
2020-12-04 13:21:36 -08:00
Alexander Blair
1eae7574b5
Merge pull request #7017
...
13350f79d
Do not use peer_id tracking method over i2p/tor (Lee Clagett)
2020-12-04 13:21:13 -08:00
moneromooo
89e984d93b
keep only the last seen node on a given host in the white list
2020-12-04 01:55:22 +00:00
moneromooo
c74d8ffd63
protocol: drop peers that decrease claimed height
2020-12-04 01:55:22 +00:00
moneromooo
61f5001c3f
protocol: add scoring system to drop peers that don't behave
2020-12-04 01:55:21 +00:00
moneromooo-monero
5ed604fe5b
crypto: fix non zero scalar being 0 after reducing
2020-12-04 01:00:03 +00:00
moneromooo-monero
2395e0e678
p2p: add a tor seed node
2020-12-03 23:45:38 +00:00
Alexander Blair
f83203ecef
Merge pull request #7058
...
89bbb802c
wallet2: set propagation timeout to current max timeout (selsta)
2020-12-03 12:19:39 -08:00
Alexander Blair
e78669257e
Merge pull request #7056
...
c64b94bd1
p2p: fix endianness when checking IPv6 addresses mapping to IPv4 (moneromooo-monero)
67f2bec2d
p2p: make this work with boost <= 1.65 (pffff) (moneromooo-monero)
ffdf1fb1d
p2p: rewrite boost's make_address_v4 to cater for < 1.66 (moneromooo)
2020-12-03 12:19:15 -08:00
Alexander Blair
84bae315f8
Merge pull request #6984
...
7a5e11645
net_node: add tor / i2p seed nodes (selsta)
2020-12-03 12:17:44 -08:00
selsta
89bbb802c0
wallet2: set propagation timeout to current max timeout
2020-12-03 02:18:58 +01:00
moneromooo-monero
c64b94bd14
p2p: fix endianness when checking IPv6 addresses mapping to IPv4
2020-12-03 00:31:32 +00:00
moneromooo-monero
67f2bec2df
p2p: make this work with boost <= 1.65 (pffff)
2020-12-03 00:31:32 +00:00
moneromooo
ffdf1fb1de
p2p: rewrite boost's make_address_v4 to cater for < 1.66
2020-12-03 00:31:29 +00:00
Alexander Blair
4f401f6fca
Merge pull request #7025
...
b10878f10
Change Dandelion++ fluff probability to 20%, and embargo timeout to 39s (Lee Clagett)
2020-12-01 14:23:49 -08:00
Alexander Blair
976fcb5985
Merge pull request #7024
...
aaf837cf5
rpc: skip non-synced bootstrap daemons in --no-sync mode too (xiphon)
2020-12-01 14:23:21 -08:00
Alexander Blair
f41dce49ac
Merge pull request #6954
...
dff1d8067
Fix tx flush callback queueing (Lee Clagett)
2020-12-01 14:22:16 -08:00
Alexander Blair
7cd0c64210
Merge pull request #6948
...
65903d2cf
Add rpc-restricted-bind-ip option (Howard Chu)
2020-12-01 14:21:19 -08:00
Alexander Blair
431ec528bc
Merge pull request #6939
...
6c9980a55
p2p: give all hosts the same chance of being picked for connecting (moneromooo)
2020-12-01 14:20:02 -08:00
Alexander Blair
003a06f030
Merge pull request #6923
...
cc034fe0c
util: fix escaping more than one ?* in glob_to_regex (moneromooo-monero)
2020-12-01 14:19:21 -08:00
Alexander Blair
d8f9472356
Merge pull request #6910
...
b7dd8349f
Allow setting start block on export (Howard Chu)
2020-12-01 14:18:44 -08:00
Alexander Blair
438442ace0
Merge pull request #6890
...
ec14e4b8c
wallet2: skip reorgs exceeding max-reorg-depth wallet setting (xiphon)
2020-12-01 14:18:22 -08:00
moneromooo
6c9980a55b
p2p: give all hosts the same chance of being picked for connecting
...
even if some run more than one node
2020-11-29 15:55:58 +00:00
selsta
7a5e11645f
net_node: add tor / i2p seed nodes
...
Co-authored-by: Lee Clagett <code@leeclagett.com>
2020-11-29 13:49:03 +01:00
luigi1111
850edfe419
Merge pull request #7021
...
d73cb95
Fix timeout checks for forwarded and Dandelion++ stem txes (Lee Clagett)
2020-11-29 01:59:35 -06:00
luigi1111
cf816e51ad
Merge pull request #7020
...
2c66894
wallet_api: TransactionHistory - fill unconfirmed out payments dests (xiphon)
2020-11-29 01:58:56 -06:00
luigi1111
36d31ba0be
Merge pull request #7018
...
a9cd5d9
cryptonote_core: dandelion - use local height or median height if syncing (xiphon)
2020-11-29 01:58:13 -06:00
luigi1111
ad843541d5
Merge pull request #7008
...
3247f11
Silence stupid warnings (Howard Chu)
2020-11-29 01:57:24 -06:00
luigi1111
c041550ffa
Merge pull request #6973
...
be84f67
Switch to Dandelion++ fluff mode if no out connections for stem mode (Lee Clagett)
2020-11-29 01:54:43 -06:00
luigi1111
a92b968e35
Merge pull request #6971
...
f9527e6
protocol: reject empty incoming block messages (moneromooo-monero)
2020-11-29 01:54:08 -06:00
luigi1111
9945ca7a62
Merge pull request #6960
...
5569a8e
rpc: on_send_raw_tx (bootstrap) - send to bootstrap daemon and P2P (xiphon)
2020-11-29 01:53:12 -06:00
luigi1111
bb56248acd
Merge pull request #6949
...
aad780b
Fix CLI and unrestricted RPC relay_tx with stempool (Lee Clagett)
2020-11-29 01:52:23 -06:00
luigi1111
9a4d813136
Merge pull request #6943
...
cb069d0
p2p: remove banned peers from the white list (moneromooo-monero)
2020-11-29 01:51:41 -06:00
luigi1111
7a0334742a
Merge pull request #6937
...
8a282f6
Add RELINK_TARGETS, monero_add_target_no_relink and use monero_add_executable/monero_add_library where possible (mj-xmr) Add monero_add_minimal_executable and use in tests (mj-xmr)
2020-11-29 01:49:39 -06:00
luigi1111
2be7a4c04f
Merge pull request #6933
...
1f04a31
p2p: use /16 filtering on IPv4-within-IPv6 addresses (moneromooo-monero)
2020-11-29 01:46:46 -06:00
luigi1111
4d298d4f11
Merge pull request #6924
...
874487f
blockchain: remove some dead code (moneromooo-monero)
2020-11-29 01:44:26 -06:00
luigi1111
999e797cea
Merge pull request #6922
...
a25bc71
Make Blockchain::get_fee_quantization_mask() compile time (SChernykh)
2020-11-29 01:40:59 -06:00
luigi1111
bab4495cfb
Merge pull request #6921
...
f1836ac
cryptonote_core: Fix missing override warnings (Nathan Dorfman)
2020-11-29 01:39:17 -06:00
luigi1111
c5b3fd1fec
Merge pull request #6920
...
aad2f87
net_node: add --ban-list option (selsta)
2020-11-29 01:38:27 -06:00
luigi1111
84cdb5d914
Merge pull request #6915
...
c67fa32
bump default number of connections from 8 to 12 (moneromooo-monero)
2020-11-29 01:34:02 -06:00
luigi1111
4c2e77854d
Merge pull request #6913
...
fc2f971
wallet2: wait for propagation timeout before marking tx as failed (xiphon)
2020-11-29 01:32:01 -06:00
luigi1111
eebd86dc3e
Merge pull request #6898
...
593ae2e
device: Ledger - update status codes (xiphon)
2020-11-29 00:44:27 -06:00
luigi1111
52006df9bb
Merge pull request #6897
...
2abdbf6
Add support for i2p and tor seed nodes (vtnerd)
2020-11-29 00:42:27 -06:00
luigi1111
7539d4ac74
Merge pull request #6895
...
b49f489
fix next_seed_height regression in getblocktemplate rpc (xnbya)
2020-11-29 00:41:42 -06:00
luigi1111
678237835f
Merge pull request #6892
...
ad7ea2c
core_rpc_server: on_send_raw_tx - fix bootstrap daemon mode check (xiphon)
2020-11-29 00:40:03 -06:00
luigi1111
d45a4ba106
Merge pull request #6849
...
f4b2382
rpc_private_headers declaration fix (malbit)
2020-11-28 22:31:25 -06:00
luigi1111
7778384071
Merge pull request #6830
...
64e9526
Extend TransactionInfo with coinbase and description attributes in wallet/api (dsc)
2020-11-28 21:55:16 -06:00
dsc
d157196416
Allow tx note edits via TransactionHistory object in wallet/api
2020-11-28 21:48:57 -06:00
luigi1111
b37d6fe368
Merge pull request #6826
...
83da867
Update error messages in daemon (tmoravec)
2020-11-28 21:35:34 -06:00
xiphon
a9cd5d914e
cryptonote_core: dandelion - use local height or median height if syncing
2020-11-25 01:27:42 +00:00
Crypto City
17c5370398
wallet2: check imported multisig curve points are in main subgroup
2020-11-24 16:25:35 +00:00
xiphon
0363476ee3
rpc: get_info - add 'synchronized' field
2020-11-19 12:51:31 +00:00
Lee Clagett
b10878f108
Change Dandelion++ fluff probability to 20%, and embargo timeout to 39s
...
A 20% fluff probability increases the precision of a spy connected to
every node by 10% on average, compared to a network using 0% fluff
probability. The current value (10% fluff) should increase precision by
~5% compared to baseline.
This decreases the expected stem length from 10 to 5. The embargo
timeout was therefore lowered to 39s; the fifth node in a stem is
expected to have a 90% chance of being the first to timeout, which is
the same probability we currently have with an expected stem length of
10 nodes.
2020-11-17 21:45:37 -05:00
xiphon
aaf837cf5f
rpc: skip non-synced bootstrap daemons in --no-sync mode too
2020-11-17 23:15:36 +00:00
Howard Chu
91fd634768
Better log message for unusable anon networks
2020-11-16 12:36:37 +00:00
Lee Clagett
d73cb95dfa
Fix timeout checks for forwarded and Dandelion++ stem txes
2020-11-15 00:08:10 -05:00
xiphon
5569a8e426
rpc: on_send_raw_tx (bootstrap) - send to bootstrap daemon and P2P
2020-11-15 03:13:07 +00:00
xiphon
2c668940cd
wallet_api: TransactionHistory - fill unconfirmed out payments dests
2020-11-14 14:09:07 +00:00
Howard Chu
3247f11638
Silence stupid warnings
2020-11-11 02:34:14 +00:00
woodser
ee58f4f766
Balance includes unconfirmed payments
2020-11-06 15:08:43 -05:00
Lee Clagett
be84f678b9
Switch to Dandelion++ fluff mode if no out connections for stem mode
2020-11-03 13:58:14 -05:00
moneromooo-monero
f9527e608e
protocol: reject empty incoming block messages
2020-11-03 12:59:36 +00:00
moneromooo-monero
1f04a3186b
p2p: use /16 filtering on IPv4-within-IPv6 addresses
...
IPv6 addresses include a range that can map IPv4 addresses,
which allowed those mapped addresses to bypass filtering.
This filter should be replaced by AS filtering at some point.
2020-11-03 00:46:07 +00:00
Lee Clagett
aad780bcfa
Fix CLI and unrestricted RPC relay_tx with stempool
2020-10-29 00:17:55 -04:00
Howard Chu
65903d2cfc
Add rpc-restricted-bind-ip option
...
Fixes #6369
2020-10-29 00:22:18 +00:00
mj-xmr
8a282f64c9
Add RELINK_TARGETS, monero_add_target_no_relink and use monero_add_executable/monero_add_library where possible (mj-xmr)
...
Add monero_add_minimal_executable and use in tests
This is done in order not to have to relink targets, when just an .so changed, but not its interface.
2020-10-28 20:08:26 +01:00
moneromooo
cb069d0a42
p2p: remove banned peers from the white list
2020-10-27 22:35:14 +00:00
luigi1111
8b3b106ad1
Merge pull request #6902
...
70eb0d1
wallet2_api: implement stop() to interrupt refresh() loop once (xiphon)
2020-10-21 22:57:42 -05:00
selsta
aad2f87a53
net_node: add --ban-list option
2020-10-20 19:39:44 +02:00
moneromooo-monero
874487fed8
blockchain: remove some dead code
...
This is already done
2020-10-20 16:50:36 +00:00
moneromooo-monero
cc034fe0c3
util: fix escaping more than one ?* in glob_to_regex
2020-10-20 16:46:53 +00:00
SChernykh
a25bc71f3f
Make Blockchain::get_fee_quantization_mask() compile time
...
This also removes potential thread safety bug in that function.
2020-10-20 14:16:09 +02:00
Nathan Dorfman
f1836ac28a
cryptonote_core: Fix missing override warnings
2020-10-19 18:23:07 -06:00
Lee Clagett
2abdbf63cf
Add support for i2p and tor seed nodes
2020-10-19 13:13:07 +00:00
Alexander Blair
faedcded39
Merge pull request #6891
...
4cf3545a3
core_rpc_server: on_get_blocks - forward bootstrap daemon error (xiphon)
2020-10-18 23:26:17 -07:00
Alexander Blair
8e3f46dd0a
Merge pull request #6881
...
11b20229c
tx_pool: silence spammy harmless warning till we fix the bug (moneromooo-monero)
2020-10-18 23:25:54 -07:00
Alexander Blair
142489bd60
Merge pull request #6882
...
fcbfb0a00
wallet2: fix missing m_state field in wallet serialization (moneromooo-monero)
2020-10-18 23:25:32 -07:00
Alexander Blair
543d600042
Merge pull request #6875
...
a12a8174e
Dandelion++: skip desynced peers in stem phase (xiphon)
2020-10-18 23:25:08 -07:00
xiphon
fc2f97177b
wallet2: wait for propagation timeout before marking tx as failed
2020-10-18 14:00:56 +00:00
moneromooo-monero
c67fa32496
bump default number of connections from 8 to 12
2020-10-18 13:25:05 +00:00
Howard Chu
b7dd8349f4
Allow setting start block on export
...
And make import honor the starting block# recorded in a bootstrap file
2020-10-18 14:01:44 +01:00
Alexander Blair
519740a1d3
Merge pull request #6905
...
88fde0309
blockchain: fix sync at v14 boundary (moneromooo-monero)
2020-10-18 05:51:43 -07:00
moneromooo-monero
88fde0309a
blockchain: fix sync at v14 boundary
...
Miners with MLSAG txes which they'd already verified included
a couple in that block, but the consensus rules had changed
in the meantime, so that block is technically invalid and any
node which did not already have those two txes in their txpool
could not sync. Grandfather them in, since it has no effect in
practice.
2020-10-18 11:52:33 +00:00
xiphon
70eb0d1844
wallet2_api: implement stop() to interrupt refresh() loop once
2020-10-17 02:56:15 +00:00
Lee Clagett
13350f79df
Do not use peer_id tracking method over i2p/tor
2020-10-15 16:47:59 +00:00
moneromooo-monero
aaa3289e22
add more updates domains and make the voting generic, not just 2/3
2020-10-15 14:06:44 +00:00
xiphon
593ae2e9f9
device: Ledger - update status codes
2020-10-13 22:53:19 +00:00
luigi1111
e503688a6b
Merge pull request #6828
...
1b3f220
Allow AddressBook description edits via wallet/api interface (xmrdsc)
2020-10-13 10:39:05 -05:00
xiphon
ec14e4b8cd
wallet2: skip reorgs exceeding max-reorg-depth wallet setting
2020-10-13 15:23:35 +00:00
Alexis Enston
b49f48962b
fix next_seed_height regression in getblocktemplate rpc
2020-10-13 11:07:59 +01:00
xiphon
4cf3545a31
core_rpc_server: on_get_blocks - forward bootstrap daemon error
2020-10-13 00:44:59 +00:00
xiphon
ad7ea2c60c
core_rpc_server: on_send_raw_tx - fix bootstrap daemon mode check
2020-10-12 23:49:37 +00:00
moneromooo-monero
fcbfb0a00a
wallet2: fix missing m_state field in wallet serialization
2020-10-12 15:35:52 +00:00
moneromooo-monero
11b20229c9
tx_pool: silence spammy harmless warning till we fix the bug
2020-10-12 14:07:40 +00:00
xiphon
a12a8174e0
Dandelion++: skip desynced peers in stem phase
2020-10-12 13:44:06 +00:00
Lee Clagett
7414e2bac1
Change epee binary output from std::stringstream to byte_stream
2020-10-10 15:28:40 +00:00
Lee Clagett
386ef03be3
Add TLSA support to DNSSEC fetching
2020-10-07 15:43:31 +00:00
Lee Clagett
dff1d8067c
Fix tx flush callback queueing
2020-10-06 16:07:49 +00:00
Alexander Blair
3cbb44a2fd
Merge pull request #6841
...
b6c4f8cd5
fix a couple bugs found by OSS-fuzz (moneromooo-monero)
2020-09-27 16:17:17 -07:00
Michal m@lbit Malicki
f4b2382713
rpc_private_headers declaration fix
2020-09-27 13:41:44 +01:00
moneromooo-monero
b6c4f8cd54
fix a couple bugs found by OSS-fuzz
...
- index out of bounds when importing outputs
- accessing invalid CLSAG data
2020-09-24 15:30:38 +00:00
xiphon
4846743fdc
daemon: Windows - fix FAT32 warning, trailing backslash is required
2020-09-20 13:57:44 +00:00
dsc
64e9526509
Extend TransactionInfo with coinbase and description attributes in wallet/api
2020-09-19 22:54:23 +02:00
dsc
1b3f220251
Allow AddressBook description edits via wallet/api interface
2020-09-19 18:29:46 +02:00
Tadeas Moravec
83da867474
Update error messages in daemon
...
When given a wrong argument, some daemon commands failed with "unknown
command" error, instead of a meaningful error message. This patch
brings consistency into the error messages.
In several places, this patch removes relatively useful messages,
and replaces them with more generic ones. E.g.,
- std::cout << "use: print_pl [white] [gray] [<limit>] [pruned]
[publicrpc]" << std::endl;
+ std::cout << "Invalid syntax: Too many parameters. For more
details, use the help command." << std::endl;
There are two reasons for this:
1. Consistency.
2. Removing duplicates.
The detailed information about the parameters is present in
the help messages already. Having it in two places increases
the risk that the messages would get out of date.
2020-09-18 14:04:19 +02:00
luigi1111
d27d4526fe
Merge pull request #6819
...
c3f354e
simplewallet fix wrong persistent-rpc-client-id name in help (moneromooo-monero)
2020-09-15 19:59:36 -05:00
luigi1111
5b3614e6a9
Merge pull request #6816
...
929ea98
Remove unused macros from cryptonote_config.h (TheCharlatan)
2020-09-15 19:58:39 -05:00
luigi1111
2b1488ef6f
Merge pull request #6793
...
de9a9fb
update error message 'No unlocked balance in the specified account' (woodser)
2020-09-15 19:56:49 -05:00
TheCharlatan
80e535c95a
wallet2: adapt to deterministic unlock time
2020-09-15 11:40:31 +00:00
moneromooo-monero
4971219c2c
blockchain: deterministic UNIX time unlock checks
...
Based on a patch by TheCharlatan <seb.kung@gmail.com>
2020-09-15 11:40:28 +00:00
moneromooo-monero
c3f354e6c1
simplewallet fix wrong persistent-rpc-client-id name in help
2020-09-14 20:50:35 +00:00
luigi1111
9bba1a24ea
Merge pull request #6815
...
ef4325f
wallet2: fix tx sanity check triggering on pre-rct outputs (monermooo-monero)
2020-09-14 11:47:06 -05:00
luigi1111
2993d2004a
Merge pull request #6813
...
a3844e2
Fix typo in command line argument description (reinaldoacosta)
2020-09-14 11:45:55 -05:00
selsta
f240b1dd88
build: prepare v0.17
2020-09-14 16:52:42 +02:00
TheCharlatan
929ea98662
Remove unused macros from cryptonote_config.h
2020-09-14 00:20:58 +02:00
moneromooo-monero
ef4325fd41
wallet2: fix tx sanity check triggering on pre-rct outputs
2020-09-12 17:51:41 +00:00
Reinaldulin
a3844e257e
Fix typo in command line argument description
2020-09-09 10:18:32 -04:00
luigi1111
836067b68b
Merge pull request #6805
...
fc2cb22
blockchain: fix pow skipping for old blocks without precalc hash (moneromooo-monero)
2020-09-07 15:31:20 -05:00
luigi1111
9c9c689db4
Merge pull request #6804
...
5498142
rpc: assume randomx from v13 onwards (moneromooo-monero)
2020-09-07 14:34:46 -05:00
luigi1111
3a761e10d2
Merge pull request #6800
...
036da6d
Let stagenet hardfork happen before mainnet. (normoes)
2020-09-07 14:32:28 -05:00
luigi1111
fd657c7706
Merge pull request #6798
...
4e44306
enable CLSAG support for Trezor client (ph4r05)
2020-09-07 14:30:41 -05:00
moneromooo-monero
fc2cb224a9
blockchain: fix pow skipping for old blocks without precalc hash
2020-09-07 01:57:19 +00:00
moneromooo-monero
5498142e8f
rpc: assume randomx from v13 onwards
2020-09-07 01:13:06 +00:00
Riccardo Spagni
aefa7740c3
Merge pull request #6111
...
d20ff4f64
functional_tests: add a large (many randomx epochs) p2p reorg test (moneromooo-monero)
6a0b3b1f8
functional_tests: add randomx tests (moneromooo-monero)
9d42649d5
core: fix mining from a block that's not the current top (moneromooo-monero)
2020-09-06 15:49:37 +02:00
Norman Moeschter
036da6d45b
Let stagenet hardfork happen before mainnet.
2020-09-04 22:47:05 +01:00
Dusan Klinec
4e4430603f
enable CLSAG support for Trezor client
2020-09-04 01:24:58 +02:00
luigi1111
9fb2243db0
Merge pull request #6794
...
b09cc3d
hardforks: add v13/v14 for testnet (moneromooo-monero)
2020-09-03 12:27:18 -05:00
luigi1111
ee0b02d0db
Merge pull request #6757
...
6a37da8
threadpool: guard against exceptions in jobs, and armour plating (moneromooo-monero)
2020-09-03 12:25:59 -05:00
moneromooo-monero
b09cc3d03d
hardforks: add v13/v14 for testnet
2020-09-02 17:56:48 +00:00
woodser
de9a9fb340
update error message "No unlocked balance in the specified account"
2020-09-01 17:30:00 -04:00
moneromooo-monero
6a37da837e
threadpool: guard against exceptions in jobs, and armour plating
...
Those would, if uncaught, exit run and leave the waiter to wait
indefinitely for the number of active jobs to reach 0
2020-09-01 14:33:33 +00:00
luigi1111
2d8a197b91
Merge pull request #6789
...
bdcf587
net: fix get_tcp_endpoint, boost address_v4 ip in host byte order (xiphon)
2020-08-31 16:58:13 -05:00
luigi1111
94b056c06e
Merge pull request #6786
...
975ae22
Fix send scalar z in plaintext (grydz)
333ae55
Update minimal Ledger Monero app version (grydz)
0a3c5a6
Update protocol version with Ledger's HW (grydz)
2020-08-31 16:54:51 -05:00
luigi1111
a51ccc036f
Merge pull request #6770
...
bdc6b10
Fix ZMQ pruned bulletproof transactions (vtnerd)
2020-08-31 16:50:18 -05:00
xiphon
bdcf587c79
net: fix get_tcp_endpoint, boost address_v4 ip in host byte order
2020-08-29 18:07:46 +00:00
Sarang Noether
fa06c39d97
Bind signature to full address and signing mode
2020-08-28 19:38:00 -04:00
moneromooo-monero
743608ec16
wallet: allow signing a message with spend or view key
2020-08-28 19:25:17 -04:00
moneromooo-monero
e6c81c5ea7
ringct: fix CLSAG serialization after boost/epee changes
...
also fix a an assert message refering t MLSAG
2020-08-28 11:52:54 +00:00
François Colas
975ae22211
Fix send scalar z in plaintext
...
The scalar z has not been generated on the HW thus it can't be sent
encrypted. The value is derived from the exported private view key.
2020-08-28 12:01:57 +02:00
François Colas
333ae55fef
Update minimal Ledger Monero app version
2020-08-28 12:00:25 +02:00
François Colas
0a3c5a605b
Update protocol version with Ledger's HW
2020-08-28 11:59:02 +02:00
moneromooo-monero
d20ff4f648
functional_tests: add a large (many randomx epochs) p2p reorg test
2020-08-27 15:13:04 +00:00
moneromooo-monero
6a0b3b1f8a
functional_tests: add randomx tests
2020-08-27 15:13:03 +00:00
moneromooo-monero
9d42649d58
core: fix mining from a block that's not the current top
2020-08-27 15:13:00 +00:00
cslashm
1660fe8a25
draft support of clsag
2020-08-27 12:44:18 +00:00
Sarang Noether
703944c4d4
CLSAG device support
2020-08-27 12:44:04 +00:00
Sarang Noether
641b08c920
CLSAG optimizations
2020-08-27 12:44:04 +00:00
moneromooo-monero
82ee01699c
Integrate CLSAGs into monero
...
They are allowed from v12, and MLSAGs are rejected from v13.
2020-08-27 12:44:04 +00:00
Sarang Noether
4b328c6616
CLSAG signatures
2020-08-27 12:43:29 +00:00
Alexander Blair
0c101f1236
Merge pull request #6767
...
07442a605
Fix build with Boost 1.74 (moneromooo-monero)
2020-08-27 03:07:32 -07:00
Alexander Blair
27b49033fd
Merge pull request #6763
...
728ba38b1
rpc: always send raw txes through P2P (don't use bootstrap daemon) (xiphon)
2020-08-27 03:02:30 -07:00
Alexander Blair
b04da25e4d
Merge pull request #6760
...
844fb4e94
enforce claiming maximum coinbase amount (moneromooo-monero)
2020-08-27 03:01:28 -07:00
Alexander Blair
4fe2858b4d
Merge pull request #6746
...
20f603c6b
Fix broken multisig pubkey sorting (Jason Rhinelander)
2020-08-27 02:58:53 -07:00
Alexander Blair
dd7fd2ef80
Merge pull request #6753
...
4ff2074c7
cryptonote_protocol: don't synced pruned blocks before v11 (cohcho)
2020-08-27 02:58:45 -07:00
Alexander Blair
a06c83db73
Merge pull request #6752
...
85899230d
simplewallet: allow setting tx keys when sending to a subaddress (moneromooo-monero)
e916201f1
wallet2: fix setting tx keys when another is already set (moneromooo-monero)
2020-08-27 02:58:23 -07:00
Alexander Blair
42519b48a7
Merge pull request #6731
...
db5d6e460
wallet2: fix wrong name when checking RPC cost (moneromooo-monero)
2020-08-27 02:55:48 -07:00
Alexander Blair
bad5d8d6f0
Merge pull request #6690
...
7175dcb10
replace most boost serialization with existing monero serialization (moneromooo-monero)
2020-08-27 02:54:30 -07:00
Alexander Blair
38914fe6fa
Merge pull request #6613
...
55363c594
Avoid some temporary strings when reading off the database (moneromooo-monero)
2020-08-27 02:52:59 -07:00
Alexander Blair
a6f1fa0194
Merge pull request #6607
...
eb1b321fe
miner: increase min/max intervals to full extents (moneromooo-monero)
2020-08-26 12:53:09 -07:00
moneromooo-monero
844fb4e940
enforce claiming maximum coinbase amount
...
Claiming a slightly lesser amount does not yield the size gains
that were seen pre rct, so this closes a fingerprinting vector
2020-08-21 12:36:53 +00:00
Lee Clagett
bdc6b10d62
Fix ZMQ pruned bulletproof transactions
2020-08-19 00:36:06 -04:00
luigi1111
765db1ae7a
Revert "Use domain-separated ChaCha20 for in-memory key encryption"
...
This reverts commit 921dd8dde5
.
2020-08-17 14:08:59 -05:00
moneromooo-monero
7175dcb107
replace most boost serialization with existing monero serialization
...
This reduces the attack surface for data that can come from
malicious sources (exported output and key images, multisig
transactions...) since the monero serialization is already
exposed to the outside, and the boost lib we were using had
a few known crashers.
For interoperability, a new load-deprecated-formats wallet
setting is added (off by default). This allows loading boost
format data if there is no alternative. It will likely go
at some point, along with the ability to load those.
Notably, the peer lists file still uses the boost serialization
code, as the data it stores is define in epee, while the new
serialization code is in monero, and migrating it was fairly
hairy. Since this file is local and not obtained from anyone
else, the marginal risk is minimal, but it could be migrated
later if needed.
Some tests and tools also do, this will stay as is for now.
2020-08-17 16:23:58 +00:00
moneromooo-monero
55363c5941
Avoid some temporary strings when reading off the database
2020-08-17 14:02:27 +00:00
Alexander Blair
43f5369bec
Merge pull request #6733
...
4f01cf4b4
Tweak format, add option for difficulty (Howard Chu)
429d49512
Add options to print daily coin emission and fees (Howard Chu)
d745d2433
Don't forget size of prunable txn part (Howard Chu)
2020-08-16 12:56:03 -07:00
Alexander Blair
d73b1b6560
Merge pull request #6727
...
13eee1d6a
rpc: reject wrong sized txid (moneromooo-monero)
92e6b7df2
easylogging++: fix crash with reentrant logging (moneromooo-monero)
6dd95d530
epee: guard against exceptions in RPC handlers (moneromooo-monero)
90016ad74
blockchain: guard against exceptions in add_new_block/children (moneromooo-monero)
2020-08-16 12:55:25 -07:00
Alexander Blair
569d07d60b
Merge pull request #6722
...
c1b03fb1a
rpc: return empty txid get_outs rather than 00..00 when not requested (moneromooo-monero)
2020-08-16 12:54:42 -07:00
Alexander Blair
01b512f3a9
Merge pull request #6716
...
76c16822d
wallet2_api: implement runtime proxy configuration (xiphon)
2020-08-16 12:52:21 -07:00
Alexander Blair
f40b9e34e0
Merge pull request #6715
...
3d6bc0a68
wallet2: throw a error on wallet initialization failure (xiphon)
2020-08-16 12:51:57 -07:00
Alexander Blair
43f91ee12e
Merge pull request #6703
...
8baa7bb23
daemon: don't print "(pruned)" for coinbase txes (moneromooo-monero)
2020-08-16 12:50:43 -07:00
Alexander Blair
0b0da2aa81
Merge pull request #6689
...
afd002c31
daemon: print sampling time in print_net_stats (moneromooo-monero)
ec7bba079
util: fix kilo prefix typo (K instead of k) (moneromooo-monero)
2020-08-16 12:47:36 -07:00
Alexander Blair
236256f114
Merge pull request #6679
...
2f1ad3b3d
updates: mac gui .tar.bz2 -> .dmg (selsta)
2020-08-16 12:46:51 -07:00
Alexander Blair
eba2189925
Merge pull request #6677
...
f9e3fcdf3
add trezor support to sweep_single (Dusan Klinec)
2020-08-16 12:46:27 -07:00
Alexander Blair
bc48494731
Merge pull request #6661
...
267ce5b71
avoid a couple needless copies (moneromooo-monero)
2020-08-16 12:45:37 -07:00
Alexander Blair
8f02e7a7fc
Merge pull request #6632
...
ef694d028
fix warning by removing std::move() on temporary http_client object (woodser)
2020-08-16 12:44:59 -07:00
Alexander Blair
c6c4ead44e
Merge pull request #6614
...
fb31167b1
Wallet, daemon: From 'help_advanced' back to 'help', and new 'apropos' command (rbrunner7)
2020-08-16 12:44:03 -07:00
Alexander Blair
a08df6eb1b
Merge pull request #6603
...
4e2377995
Change ZMQ-JSON txextra to hex and remove unnecessary base fields (Lee Clagett)
2020-08-16 12:43:38 -07:00
Alexander Blair
009ca6fcd3
Merge pull request #6601
...
98c151ecb
Optimize ZMQ-JSON vector reading; GetBlocksFast reads 24%+ faster (Lee Clagett)
60627c9f2
Switch to insitu parsing for ZMQ-JSON; GetBlocksFast reads 13%+ faster (Lee Clagett)
fe96e66eb
Fix pruned tx for ZMQ's GetBlocksFast (Lee Clagett)
2020-08-16 12:43:11 -07:00
Alexander Blair
0f5eb0e70c
Merge pull request #6546
...
eda167585
wallet_rpc_server: use unlock_time in suggested confirmations calc (moneromooo-monero)
2020-08-16 12:40:51 -07:00
Alexander Blair
461651fce5
Merge pull request #6542
...
35665df20
protocol: don't drop a connection if we can't get a compatible chain (moneromooo-monero)
2020-08-16 12:40:37 -07:00
Alexander Blair
6d29ee6c52
Merge pull request #6493
...
921dd8dde
Use domain-separated ChaCha20 for in-memory key encryption (Sarang Noether)
2020-08-16 12:39:59 -07:00
Alexander Blair
e2e09d00c2
Merge pull request #6337
...
a11ec4ac1
Support for supercop ASM in wallet, and benchmark for supercop (Lee Clagett)
2020-08-16 12:38:44 -07:00
Alexander Blair
13549d590e
Merge pull request #6329
...
6bfcd3101
Updates InProofV1, OutProofV1, and ReserveProofV1 to new V2 variants that include all public proof parameters in Schnorr challenges, along with hash function domain separators. Includes new randomized unit tests. (Sarang Noether)
2020-08-16 12:37:43 -07:00
xiphon
728ba38b11
rpc: always send raw txes through P2P (don't use bootstrap daemon)
...
It turns out that some remote (bootstrap) nodes silently drop /
don't broadcast client's transactions.
2020-08-16 17:34:28 +00:00
moneromooo-monero
07442a6059
Fix build with Boost 1.74
...
Thanks iDunk for testing
2020-08-16 16:23:26 +00:00
Lee Clagett
4e2377995d
Change ZMQ-JSON txextra to hex and remove unnecessary base fields
2020-08-14 23:01:00 +00:00
Lee Clagett
98c151ecb8
Optimize ZMQ-JSON vector reading; GetBlocksFast reads 24%+ faster
2020-08-14 19:47:19 +00:00
Lee Clagett
60627c9f24
Switch to insitu parsing for ZMQ-JSON; GetBlocksFast reads 13%+ faster
2020-08-14 19:46:59 +00:00
Lee Clagett
fe96e66ebe
Fix pruned tx for ZMQ's GetBlocksFast
2020-08-14 19:46:33 +00:00
moneromooo-monero
85899230d1
simplewallet: allow setting tx keys when sending to a subaddress
...
The tx key derivation is different then
2020-08-10 21:25:51 +00:00
cohcho
4ff2074c74
cryptonote_protocol: don't synced pruned blocks before v11
...
There are a few Borromean proofs txes in the v8 era, and these
aren't supported by get_pruned_transaction_weight. Moreover, only
only the most recent variant of bulletproofs is currently supported.
2020-08-10 16:17:39 +00:00
Sarang Noether
921dd8dde5
Use domain-separated ChaCha20 for in-memory key encryption
2020-08-09 19:11:54 -04:00