nqrduck/limedriver
1
0
Fork 0
Code Issues 1 Pull requests Projects Releases 1 Packages Wiki Activity Actions

Added function to parse arguments for future implementation of python… #9

Merged
jupfi merged 2 commits from parsi_argi into main 2024-02-07 13:48:34 +00:00
Conversation 6 Commits 2 Files changed 2 +182 -152
jupfi commented 2024-02-07 13:38:28 +00:00 (Migrated from github.com)
Copy link

… binding.

… binding.
jupfi commented 2024-02-07 13:38:46 +00:00 (Migrated from github.com)
Copy link

I tested this with the LimeSDR USB

I tested this with the LimeSDR USB
kumitterer (Migrated from github.com) requested changes 2024-02-07 13:42:45 +00:00
kumitterer (Migrated from github.com) left a comment
Copy link

Please exclude the .h5 file, that shouldn't be in the repo (just add data/ to .gitignore). Other than that, LGTM.

Please exclude the .h5 file, that shouldn't be in the repo (just add `data/` to `.gitignore`). Other than that, LGTM.
src/limedriver.cpp
kumitterer (Migrated from github.com) commented 2024-02-07 13:42:10 +00:00
Copy link

At this point, this is only used by the dump function. I should modify that one to take the vector instead of an array so we don't have to cast around that much.

At this point, this is only used by the dump function. I should modify that one to take the vector instead of an array so we don't have to cast around that much.
jupfi (Migrated from github.com) reviewed 2024-02-07 13:45:47 +00:00
jupfi (Migrated from github.com) reviewed 2024-02-07 13:46:25 +00:00
src/limedriver.cpp
jupfi (Migrated from github.com) commented 2024-02-07 13:46:25 +00:00
Copy link

Yup. We should probably move to vectors all the time? Because we might run into this issue more often.

Yup. We should probably move to vectors all the time? Because we might run into this issue more often.
kumitterer (Migrated from github.com) reviewed 2024-02-07 13:47:09 +00:00
src/limedriver.cpp
kumitterer (Migrated from github.com) commented 2024-02-07 13:47:09 +00:00
Copy link

+1. Should happen pretty much naturally as we work through the code.

+1. Should happen pretty much naturally as we work through the code.
kumitterer (Migrated from github.com) approved these changes 2024-02-07 13:47:57 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
kumitterer
Labels
Clear labels   
bug

Something isn't working

  
documentation

Improvements or additions to documentation

  
duplicate

This issue or pull request already exists

  
enhancement

New feature or request

  
good first issue

Good for newcomers

  
help wanted

Extra attention is needed

  
invalid

This doesn't seem right

  
question

Further information is requested

  
wontfix

This will not be worked on

No labels
bug
documentation
duplicate
enhancement
good first issue
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: nqrduck/limedriver#9
No description provided.
Delete branch "parsi_argi"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?