nqrduck/limedriver
1
0
Fork 0
Code Issues 1 Pull requests Projects Releases 1 Packages Wiki Activity Actions

Refactor to use getHDFAttributes function #6

Merged
kumitterer merged 1 commit from hdfattr_function_fix into main 2024-02-07 13:12:11 +00:00
Conversation 8 Commits 1 Files changed 1 +208 -201
kumitterer commented 2024-02-07 09:35:34 +00:00 (Migrated from github.com)
Copy link

Moved the constuction of the HDF attribute array to a dedicated function so we can use it from other places than main() in the future.

Fixed merge issues of #4

Moved the constuction of the HDF attribute array to a dedicated function so we can use it from other places than main() in the future. Fixed merge issues of #4
jupfi commented 2024-02-07 09:57:39 +00:00 (Migrated from github.com)
Copy link

With the current implementation the RX data stream is empty.

With the current implementation the RX data stream is empty.
kumitterer commented 2024-02-07 10:06:45 +00:00 (Migrated from github.com)
Copy link

Let's dive into this. This is the content of the array with the code from this branch:

{
"sra": {"name": "SampleRate [Hz]", "type": "16Config2HDFattr_t", "value": "3.072e+07", "dim": 1},
"lof": {"name": "LO Frequency [Hz]", "type": "16Config2HDFattr_t", "value": "5e+07", "dim": 1},
"rlp": {"name": "RX LowPass BW [Hz]", "type": "16Config2HDFattr_t", "value": "5e+06", "dim": 1},
"tlp": {"name": "TX LowPass BW [Hz]", "type": "16Config2HDFattr_t", "value": "1.3e+08", "dim": 1},
"rgn": {"name": "RX Gain [dB]", "type": "16Config2HDFattr_t", "value": "20", "dim": 1},
"tgn": {"name": "TX Gain [dB]", "type": "16Config2HDFattr_t", "value": "30", "dim": 1},
"//0": {"name": "RX Gain readback [dB]", "type": "16Config2HDFattr_t", "value": "32568", "dim": 4},
"//1": {"name": "TX Gain readback [dB]", "type": "16Config2HDFattr_t", "value": "32568", "dim": 3},
"tdq": {"name": "TX DC-correction Q", "type": "16Config2HDFattr_t", "value": "50", "dim": 1},
"tdi": {"name": "TX DC-correction I", "type": "16Config2HDFattr_t", "value": "-32", "dim": 1},
"npu": {"name": "Number of Pulses", "type": "16Config2HDFattr_t", "value": "2", "dim": 1},
"pdr": {"name": "Pulse Duration [s]", "type": "16Config2HDFattr_t", "value": "2e-06", "dim": 2},
"pof": {"name": "Pulse Offset [Sa]", "type": "16Config2HDFattr_t", "value": "4080", "dim": 2},
"pam": {"name": "IF Pulse Amplitude", "type": "16Config2HDFattr_t", "value": "1", "dim": 2},
"pfr": {"name": "IF Pulse Frequency [Hz]", "type": "16Config2HDFattr_t", "value": "2e+06", "dim": 2},
"pph": {"name": "IF Pulse Phase", "type": "16Config2HDFattr_t", "value": "0", "dim": 2},
"pcn": {"name": "Nmbr of Phasecycles", "type": "16Config2HDFattr_t", "value": "1", "dim": 2},
"pcl": {"name": "Level of Phasecycle", "type": "16Config2HDFattr_t", "value": "0", "dim": 2},
"//2": {"name": "Pulse Duration [Sa]", "type": "16Config2HDFattr_t", "value": "788491040", "dim": 2},
"//3": {"name": "IF Pulse Frequency [1/Sa]", "type": "16Config2HDFattr_t", "value": "6.91095e-310", "dim": 2},
"t0d": {"name": "Trigger0 Timing [Sa]", "type": "16Config2HDFattr_t", "value": "0", "dim": 4},
"t1d": {"name": "Trigger1 Timing [Sa]", "type": "16Config2HDFattr_t", "value": "0", "dim": 4},
"t2d": {"name": "Trigger2 Timing [Sa]", "type": "16Config2HDFattr_t", "value": "0", "dim": 4},
"t3d": {"name": "Trigger3 Timing [Sa]", "type": "16Config2HDFattr_t", "value": "0", "dim": 4},
"t0s": {"name": "Trigger0 Synth [Sa]", "type": "16Config2HDFattr_t", "value": "0", "dim": 5},
"t1s": {"name": "Trigger1 Synth [Sa]", "type": "16Config2HDFattr_t", "value": "0", "dim": 5},
"t2s": {"name": "Trigger2 Synth [Sa]", "type": "16Config2HDFattr_t", "value": "0", "dim": 5},
"t3s": {"name": "Trigger3 Synth [Sa]", "type": "16Config2HDFattr_t", "value": "0", "dim": 5},
"t0p": {"name": "Trigger0 Enable", "type": "16Config2HDFattr_t", "value": "1", "dim": 2},
"t1p": {"name": "Trigger1 Enable", "type": "16Config2HDFattr_t", "value": "1", "dim": 2},
"t2p": {"name": "Trigger2 Enable", "type": "16Config2HDFattr_t", "value": "1", "dim": 2},
"t3p": {"name": "Trigger3 Enable", "type": "16Config2HDFattr_t", "value": "1", "dim": 2},
"nrp": {"name": "Nmbr of Repetitions", "type": "16Config2HDFattr_t", "value": "4", "dim": 1},
"nav": {"name": "Nmbr of Averages", "type": "16Config2HDFattr_t", "value": "6", "dim": 1},
"trp": {"name": "Repetition Time [s]", "type": "16Config2HDFattr_t", "value": "0.004", "dim": 1},
"tac": {"name": "Acquisition Time [s]", "type": "16Config2HDFattr_t", "value": "0.0002", "dim": 1},
"//4": {"name": "Repetition Time [Sa]", "type": "16Config2HDFattr_t", "value": "800165792", "dim": 1},
"//5": {"name": "Acquisition Time [Sa]", "type": "16Config2HDFattr_t", "value": "32568", "dim": 1},
"bsz": {"name": "Buffersize", "type": "16Config2HDFattr_t", "value": "12240", "dim": 1},
"pba": {"name": "Pcyc before Avg if >0", "type": "16Config2HDFattr_t", "value": "800163584", "dim": 1},
"fpa": {"name": "Filename Pattern", "type": "16Config2HDFattr_t", "value": "test", "dim": 1},
"spt": {"name": "Save Path", "type": "16Config2HDFattr_t", "value": "./data/", "dim": 1},
"nos": {"name": "Don't save if >0", "type": "16Config2HDFattr_t", "value": "0", "dim": 1},
"fst": {"name": "Filename Timestamp", "type": "16Config2HDFattr_t", "value": "20240207_103431", "dim": 1},
"//6": {"name": "Exp Start Timestamp", "type": "16Config2HDFattr_t", "value": "20240207_103431", "dim": 1},
"//7": {"name": "Exp End Timestamp", "type": "16Config2HDFattr_t", "value": "20240207_103431", "dim": 1}
}
Let's dive into this. This is the content of the array with the code from this branch: ```json { "sra": {"name": "SampleRate [Hz]", "type": "16Config2HDFattr_t", "value": "3.072e+07", "dim": 1}, "lof": {"name": "LO Frequency [Hz]", "type": "16Config2HDFattr_t", "value": "5e+07", "dim": 1}, "rlp": {"name": "RX LowPass BW [Hz]", "type": "16Config2HDFattr_t", "value": "5e+06", "dim": 1}, "tlp": {"name": "TX LowPass BW [Hz]", "type": "16Config2HDFattr_t", "value": "1.3e+08", "dim": 1}, "rgn": {"name": "RX Gain [dB]", "type": "16Config2HDFattr_t", "value": "20", "dim": 1}, "tgn": {"name": "TX Gain [dB]", "type": "16Config2HDFattr_t", "value": "30", "dim": 1}, "//0": {"name": "RX Gain readback [dB]", "type": "16Config2HDFattr_t", "value": "32568", "dim": 4}, "//1": {"name": "TX Gain readback [dB]", "type": "16Config2HDFattr_t", "value": "32568", "dim": 3}, "tdq": {"name": "TX DC-correction Q", "type": "16Config2HDFattr_t", "value": "50", "dim": 1}, "tdi": {"name": "TX DC-correction I", "type": "16Config2HDFattr_t", "value": "-32", "dim": 1}, "npu": {"name": "Number of Pulses", "type": "16Config2HDFattr_t", "value": "2", "dim": 1}, "pdr": {"name": "Pulse Duration [s]", "type": "16Config2HDFattr_t", "value": "2e-06", "dim": 2}, "pof": {"name": "Pulse Offset [Sa]", "type": "16Config2HDFattr_t", "value": "4080", "dim": 2}, "pam": {"name": "IF Pulse Amplitude", "type": "16Config2HDFattr_t", "value": "1", "dim": 2}, "pfr": {"name": "IF Pulse Frequency [Hz]", "type": "16Config2HDFattr_t", "value": "2e+06", "dim": 2}, "pph": {"name": "IF Pulse Phase", "type": "16Config2HDFattr_t", "value": "0", "dim": 2}, "pcn": {"name": "Nmbr of Phasecycles", "type": "16Config2HDFattr_t", "value": "1", "dim": 2}, "pcl": {"name": "Level of Phasecycle", "type": "16Config2HDFattr_t", "value": "0", "dim": 2}, "//2": {"name": "Pulse Duration [Sa]", "type": "16Config2HDFattr_t", "value": "788491040", "dim": 2}, "//3": {"name": "IF Pulse Frequency [1/Sa]", "type": "16Config2HDFattr_t", "value": "6.91095e-310", "dim": 2}, "t0d": {"name": "Trigger0 Timing [Sa]", "type": "16Config2HDFattr_t", "value": "0", "dim": 4}, "t1d": {"name": "Trigger1 Timing [Sa]", "type": "16Config2HDFattr_t", "value": "0", "dim": 4}, "t2d": {"name": "Trigger2 Timing [Sa]", "type": "16Config2HDFattr_t", "value": "0", "dim": 4}, "t3d": {"name": "Trigger3 Timing [Sa]", "type": "16Config2HDFattr_t", "value": "0", "dim": 4}, "t0s": {"name": "Trigger0 Synth [Sa]", "type": "16Config2HDFattr_t", "value": "0", "dim": 5}, "t1s": {"name": "Trigger1 Synth [Sa]", "type": "16Config2HDFattr_t", "value": "0", "dim": 5}, "t2s": {"name": "Trigger2 Synth [Sa]", "type": "16Config2HDFattr_t", "value": "0", "dim": 5}, "t3s": {"name": "Trigger3 Synth [Sa]", "type": "16Config2HDFattr_t", "value": "0", "dim": 5}, "t0p": {"name": "Trigger0 Enable", "type": "16Config2HDFattr_t", "value": "1", "dim": 2}, "t1p": {"name": "Trigger1 Enable", "type": "16Config2HDFattr_t", "value": "1", "dim": 2}, "t2p": {"name": "Trigger2 Enable", "type": "16Config2HDFattr_t", "value": "1", "dim": 2}, "t3p": {"name": "Trigger3 Enable", "type": "16Config2HDFattr_t", "value": "1", "dim": 2}, "nrp": {"name": "Nmbr of Repetitions", "type": "16Config2HDFattr_t", "value": "4", "dim": 1}, "nav": {"name": "Nmbr of Averages", "type": "16Config2HDFattr_t", "value": "6", "dim": 1}, "trp": {"name": "Repetition Time [s]", "type": "16Config2HDFattr_t", "value": "0.004", "dim": 1}, "tac": {"name": "Acquisition Time [s]", "type": "16Config2HDFattr_t", "value": "0.0002", "dim": 1}, "//4": {"name": "Repetition Time [Sa]", "type": "16Config2HDFattr_t", "value": "800165792", "dim": 1}, "//5": {"name": "Acquisition Time [Sa]", "type": "16Config2HDFattr_t", "value": "32568", "dim": 1}, "bsz": {"name": "Buffersize", "type": "16Config2HDFattr_t", "value": "12240", "dim": 1}, "pba": {"name": "Pcyc before Avg if >0", "type": "16Config2HDFattr_t", "value": "800163584", "dim": 1}, "fpa": {"name": "Filename Pattern", "type": "16Config2HDFattr_t", "value": "test", "dim": 1}, "spt": {"name": "Save Path", "type": "16Config2HDFattr_t", "value": "./data/", "dim": 1}, "nos": {"name": "Don't save if >0", "type": "16Config2HDFattr_t", "value": "0", "dim": 1}, "fst": {"name": "Filename Timestamp", "type": "16Config2HDFattr_t", "value": "20240207_103431", "dim": 1}, "//6": {"name": "Exp Start Timestamp", "type": "16Config2HDFattr_t", "value": "20240207_103431", "dim": 1}, "//7": {"name": "Exp End Timestamp", "type": "16Config2HDFattr_t", "value": "20240207_103431", "dim": 1} } ```
kumitterer commented 2024-02-07 10:08:07 +00:00 (Migrated from github.com)
Copy link

And this is from main:

{
"sra": {"name": "SampleRate [Hz]", "type": "16Config2HDFattr_t", "value": "3.072e+07", "dim": 1},
"lof": {"name": "LO Frequency [Hz]", "type": "16Config2HDFattr_t", "value": "5e+07", "dim": 1},
"rlp": {"name": "RX LowPass BW [Hz]", "type": "16Config2HDFattr_t", "value": "5e+06", "dim": 1},
"tlp": {"name": "TX LowPass BW [Hz]", "type": "16Config2HDFattr_t", "value": "1.3e+08", "dim": 1},
"rgn": {"name": "RX Gain [dB]", "type": "16Config2HDFattr_t", "value": "20", "dim": 1},
"tgn": {"name": "TX Gain [dB]", "type": "16Config2HDFattr_t", "value": "30", "dim": 1},
"//0": {"name": "RX Gain readback [dB]", "type": "16Config2HDFattr_t", "value": "0", "dim": 4},
"//1": {"name": "TX Gain readback [dB]", "type": "16Config2HDFattr_t", "value": "0", "dim": 3},
"tdq": {"name": "TX DC-correction Q", "type": "16Config2HDFattr_t", "value": "50", "dim": 1},
"tdi": {"name": "TX DC-correction I", "type": "16Config2HDFattr_t", "value": "-32", "dim": 1},
"npu": {"name": "Number of Pulses", "type": "16Config2HDFattr_t", "value": "2", "dim": 1},
"pdr": {"name": "Pulse Duration [s]", "type": "16Config2HDFattr_t", "value": "2e-06", "dim": 2},
"pof": {"name": "Pulse Offset [Sa]", "type": "16Config2HDFattr_t", "value": "4080", "dim": 2},
"pam": {"name": "IF Pulse Amplitude", "type": "16Config2HDFattr_t", "value": "1", "dim": 2},
"pfr": {"name": "IF Pulse Frequency [Hz]", "type": "16Config2HDFattr_t", "value": "2e+06", "dim": 2},
"pph": {"name": "IF Pulse Phase", "type": "16Config2HDFattr_t", "value": "0", "dim": 2},
"pcn": {"name": "Nmbr of Phasecycles", "type": "16Config2HDFattr_t", "value": "1", "dim": 2},
"pcl": {"name": "Level of Phasecycle", "type": "16Config2HDFattr_t", "value": "0", "dim": 2},
"//2": {"name": "Pulse Duration [Sa]", "type": "16Config2HDFattr_t", "value": "1782541088", "dim": 2},
"//3": {"name": "IF Pulse Frequency [1/Sa]", "type": "16Config2HDFattr_t", "value": "6.90336e-310", "dim": 2},
"t0d": {"name": "Trigger0 Timing [Sa]", "type": "16Config2HDFattr_t", "value": "0", "dim": 4},
"t1d": {"name": "Trigger1 Timing [Sa]", "type": "16Config2HDFattr_t", "value": "0", "dim": 4},
"t2d": {"name": "Trigger2 Timing [Sa]", "type": "16Config2HDFattr_t", "value": "0", "dim": 4},
"t3d": {"name": "Trigger3 Timing [Sa]", "type": "16Config2HDFattr_t", "value": "0", "dim": 4},
"t0s": {"name": "Trigger0 Synth [Sa]", "type": "16Config2HDFattr_t", "value": "0", "dim": 5},
"t1s": {"name": "Trigger1 Synth [Sa]", "type": "16Config2HDFattr_t", "value": "0", "dim": 5},
"t2s": {"name": "Trigger2 Synth [Sa]", "type": "16Config2HDFattr_t", "value": "0", "dim": 5},
"t3s": {"name": "Trigger3 Synth [Sa]", "type": "16Config2HDFattr_t", "value": "0", "dim": 5},
"t0p": {"name": "Trigger0 Enable", "type": "16Config2HDFattr_t", "value": "1", "dim": 2},
"t1p": {"name": "Trigger1 Enable", "type": "16Config2HDFattr_t", "value": "1", "dim": 2},
"t2p": {"name": "Trigger2 Enable", "type": "16Config2HDFattr_t", "value": "1", "dim": 2},
"t3p": {"name": "Trigger3 Enable", "type": "16Config2HDFattr_t", "value": "1", "dim": 2},
"nrp": {"name": "Nmbr of Repetitions", "type": "16Config2HDFattr_t", "value": "4", "dim": 1},
"nav": {"name": "Nmbr of Averages", "type": "16Config2HDFattr_t", "value": "6", "dim": 1},
"trp": {"name": "Repetition Time [s]", "type": "16Config2HDFattr_t", "value": "0.004", "dim": 1},
"tac": {"name": "Acquisition Time [s]", "type": "16Config2HDFattr_t", "value": "0.0002", "dim": 1},
"//4": {"name": "Repetition Time [Sa]", "type": "16Config2HDFattr_t", "value": "0", "dim": 1},
"//5": {"name": "Acquisition Time [Sa]", "type": "16Config2HDFattr_t", "value": "0", "dim": 1},
"bsz": {"name": "Buffersize", "type": "16Config2HDFattr_t", "value": "12240", "dim": 1},
"pba": {"name": "Pcyc before Avg if >0", "type": "16Config2HDFattr_t", "value": "0", "dim": 1},
"fpa": {"name": "Filename Pattern", "type": "16Config2HDFattr_t", "value": "test", "dim": 1},
"spt": {"name": "Save Path", "type": "16Config2HDFattr_t", "value": "./data/", "dim": 1},
"nos": {"name": "Don't save if >0", "type": "16Config2HDFattr_t", "value": "0", "dim": 1},
"fst": {"name": "Filename Timestamp", "type": "16Config2HDFattr_t", "value": "20240207_110730", "dim": 1},
"//6": {"name": "Exp Start Timestamp", "type": "16Config2HDFattr_t", "value": "20240207_110730", "dim": 1},
"//7": {"name": "Exp End Timestamp", "type": "16Config2HDFattr_t", "value": "20240207_110730", "dim": 1}
}

Do your elven eyes spy a difference?

And this is from main: ```json { "sra": {"name": "SampleRate [Hz]", "type": "16Config2HDFattr_t", "value": "3.072e+07", "dim": 1}, "lof": {"name": "LO Frequency [Hz]", "type": "16Config2HDFattr_t", "value": "5e+07", "dim": 1}, "rlp": {"name": "RX LowPass BW [Hz]", "type": "16Config2HDFattr_t", "value": "5e+06", "dim": 1}, "tlp": {"name": "TX LowPass BW [Hz]", "type": "16Config2HDFattr_t", "value": "1.3e+08", "dim": 1}, "rgn": {"name": "RX Gain [dB]", "type": "16Config2HDFattr_t", "value": "20", "dim": 1}, "tgn": {"name": "TX Gain [dB]", "type": "16Config2HDFattr_t", "value": "30", "dim": 1}, "//0": {"name": "RX Gain readback [dB]", "type": "16Config2HDFattr_t", "value": "0", "dim": 4}, "//1": {"name": "TX Gain readback [dB]", "type": "16Config2HDFattr_t", "value": "0", "dim": 3}, "tdq": {"name": "TX DC-correction Q", "type": "16Config2HDFattr_t", "value": "50", "dim": 1}, "tdi": {"name": "TX DC-correction I", "type": "16Config2HDFattr_t", "value": "-32", "dim": 1}, "npu": {"name": "Number of Pulses", "type": "16Config2HDFattr_t", "value": "2", "dim": 1}, "pdr": {"name": "Pulse Duration [s]", "type": "16Config2HDFattr_t", "value": "2e-06", "dim": 2}, "pof": {"name": "Pulse Offset [Sa]", "type": "16Config2HDFattr_t", "value": "4080", "dim": 2}, "pam": {"name": "IF Pulse Amplitude", "type": "16Config2HDFattr_t", "value": "1", "dim": 2}, "pfr": {"name": "IF Pulse Frequency [Hz]", "type": "16Config2HDFattr_t", "value": "2e+06", "dim": 2}, "pph": {"name": "IF Pulse Phase", "type": "16Config2HDFattr_t", "value": "0", "dim": 2}, "pcn": {"name": "Nmbr of Phasecycles", "type": "16Config2HDFattr_t", "value": "1", "dim": 2}, "pcl": {"name": "Level of Phasecycle", "type": "16Config2HDFattr_t", "value": "0", "dim": 2}, "//2": {"name": "Pulse Duration [Sa]", "type": "16Config2HDFattr_t", "value": "1782541088", "dim": 2}, "//3": {"name": "IF Pulse Frequency [1/Sa]", "type": "16Config2HDFattr_t", "value": "6.90336e-310", "dim": 2}, "t0d": {"name": "Trigger0 Timing [Sa]", "type": "16Config2HDFattr_t", "value": "0", "dim": 4}, "t1d": {"name": "Trigger1 Timing [Sa]", "type": "16Config2HDFattr_t", "value": "0", "dim": 4}, "t2d": {"name": "Trigger2 Timing [Sa]", "type": "16Config2HDFattr_t", "value": "0", "dim": 4}, "t3d": {"name": "Trigger3 Timing [Sa]", "type": "16Config2HDFattr_t", "value": "0", "dim": 4}, "t0s": {"name": "Trigger0 Synth [Sa]", "type": "16Config2HDFattr_t", "value": "0", "dim": 5}, "t1s": {"name": "Trigger1 Synth [Sa]", "type": "16Config2HDFattr_t", "value": "0", "dim": 5}, "t2s": {"name": "Trigger2 Synth [Sa]", "type": "16Config2HDFattr_t", "value": "0", "dim": 5}, "t3s": {"name": "Trigger3 Synth [Sa]", "type": "16Config2HDFattr_t", "value": "0", "dim": 5}, "t0p": {"name": "Trigger0 Enable", "type": "16Config2HDFattr_t", "value": "1", "dim": 2}, "t1p": {"name": "Trigger1 Enable", "type": "16Config2HDFattr_t", "value": "1", "dim": 2}, "t2p": {"name": "Trigger2 Enable", "type": "16Config2HDFattr_t", "value": "1", "dim": 2}, "t3p": {"name": "Trigger3 Enable", "type": "16Config2HDFattr_t", "value": "1", "dim": 2}, "nrp": {"name": "Nmbr of Repetitions", "type": "16Config2HDFattr_t", "value": "4", "dim": 1}, "nav": {"name": "Nmbr of Averages", "type": "16Config2HDFattr_t", "value": "6", "dim": 1}, "trp": {"name": "Repetition Time [s]", "type": "16Config2HDFattr_t", "value": "0.004", "dim": 1}, "tac": {"name": "Acquisition Time [s]", "type": "16Config2HDFattr_t", "value": "0.0002", "dim": 1}, "//4": {"name": "Repetition Time [Sa]", "type": "16Config2HDFattr_t", "value": "0", "dim": 1}, "//5": {"name": "Acquisition Time [Sa]", "type": "16Config2HDFattr_t", "value": "0", "dim": 1}, "bsz": {"name": "Buffersize", "type": "16Config2HDFattr_t", "value": "12240", "dim": 1}, "pba": {"name": "Pcyc before Avg if >0", "type": "16Config2HDFattr_t", "value": "0", "dim": 1}, "fpa": {"name": "Filename Pattern", "type": "16Config2HDFattr_t", "value": "test", "dim": 1}, "spt": {"name": "Save Path", "type": "16Config2HDFattr_t", "value": "./data/", "dim": 1}, "nos": {"name": "Don't save if >0", "type": "16Config2HDFattr_t", "value": "0", "dim": 1}, "fst": {"name": "Filename Timestamp", "type": "16Config2HDFattr_t", "value": "20240207_110730", "dim": 1}, "//6": {"name": "Exp Start Timestamp", "type": "16Config2HDFattr_t", "value": "20240207_110730", "dim": 1}, "//7": {"name": "Exp End Timestamp", "type": "16Config2HDFattr_t", "value": "20240207_110730", "dim": 1} } ``` Do your elven eyes spy a difference?
kumitterer commented 2024-02-07 10:11:23 +00:00 (Migrated from github.com)
Copy link

Indeed.

8,9c8,9
< "//0": {"name": "RX Gain readback [dB]", "type": "16Config2HDFattr_t", "value": "0", "dim": 4},
< "//1": {"name": "TX Gain readback [dB]", "type": "16Config2HDFattr_t", "value": "0", "dim": 3},
---
> "//0": {"name": "RX Gain readback [dB]", "type": "16Config2HDFattr_t", "value": "32568", "dim": 4},
> "//1": {"name": "TX Gain readback [dB]", "type": "16Config2HDFattr_t", "value": "32568", "dim": 3},
20,21c20,21
< "//2": {"name": "Pulse Duration [Sa]", "type": "16Config2HDFattr_t", "value": "1782541088", "dim": 2},
< "//3": {"name": "IF Pulse Frequency [1/Sa]", "type": "16Config2HDFattr_t", "value": "6.90336e-310", "dim": 2},
---
> "//2": {"name": "Pulse Duration [Sa]", "type": "16Config2HDFattr_t", "value": "788491040", "dim": 2},
> "//3": {"name": "IF Pulse Frequency [1/Sa]", "type": "16Config2HDFattr_t", "value": "6.91095e-310", "dim": 2},
38,39c38,39
< "//4": {"name": "Repetition Time [Sa]", "type": "16Config2HDFattr_t", "value": "0", "dim": 1},
< "//5": {"name": "Acquisition Time [Sa]", "type": "16Config2HDFattr_t", "value": "0", "dim": 1},
---
> "//4": {"name": "Repetition Time [Sa]", "type": "16Config2HDFattr_t", "value": "800165792", "dim": 1},
> "//5": {"name": "Acquisition Time [Sa]", "type": "16Config2HDFattr_t", "value": "32568", "dim": 1},
41c41
< "pba": {"name": "Pcyc before Avg if >0", "type": "16Config2HDFattr_t", "value": "0", "dim": 1},
---
> "pba": {"name": "Pcyc before Avg if >0", "type": "16Config2HDFattr_t", "value": "800163584", "dim": 1},
45,47c45,47
< "fst": {"name": "Filename Timestamp", "type": "16Config2HDFattr_t", "value": "20240207_110730", "dim": 1},
< "//6": {"name": "Exp Start Timestamp", "type": "16Config2HDFattr_t", "value": "20240207_110730", "dim": 1},
< "//7": {"name": "Exp End Timestamp", "type": "16Config2HDFattr_t", "value": "20240207_110730", "dim": 1}
---
> "fst": {"name": "Filename Timestamp", "type": "16Config2HDFattr_t", "value": "20240207_103431", "dim": 1},
> "//6": {"name": "Exp Start Timestamp", "type": "16Config2HDFattr_t", "value": "20240207_103431", "dim": 1},
> "//7": {"name": "Exp End Timestamp", "type": "16Config2HDFattr_t", "value": "20240207_103431", "dim": 1}
Indeed. ```json 8,9c8,9 < "//0": {"name": "RX Gain readback [dB]", "type": "16Config2HDFattr_t", "value": "0", "dim": 4}, < "//1": {"name": "TX Gain readback [dB]", "type": "16Config2HDFattr_t", "value": "0", "dim": 3}, --- > "//0": {"name": "RX Gain readback [dB]", "type": "16Config2HDFattr_t", "value": "32568", "dim": 4}, > "//1": {"name": "TX Gain readback [dB]", "type": "16Config2HDFattr_t", "value": "32568", "dim": 3}, 20,21c20,21 < "//2": {"name": "Pulse Duration [Sa]", "type": "16Config2HDFattr_t", "value": "1782541088", "dim": 2}, < "//3": {"name": "IF Pulse Frequency [1/Sa]", "type": "16Config2HDFattr_t", "value": "6.90336e-310", "dim": 2}, --- > "//2": {"name": "Pulse Duration [Sa]", "type": "16Config2HDFattr_t", "value": "788491040", "dim": 2}, > "//3": {"name": "IF Pulse Frequency [1/Sa]", "type": "16Config2HDFattr_t", "value": "6.91095e-310", "dim": 2}, 38,39c38,39 < "//4": {"name": "Repetition Time [Sa]", "type": "16Config2HDFattr_t", "value": "0", "dim": 1}, < "//5": {"name": "Acquisition Time [Sa]", "type": "16Config2HDFattr_t", "value": "0", "dim": 1}, --- > "//4": {"name": "Repetition Time [Sa]", "type": "16Config2HDFattr_t", "value": "800165792", "dim": 1}, > "//5": {"name": "Acquisition Time [Sa]", "type": "16Config2HDFattr_t", "value": "32568", "dim": 1}, 41c41 < "pba": {"name": "Pcyc before Avg if >0", "type": "16Config2HDFattr_t", "value": "0", "dim": 1}, --- > "pba": {"name": "Pcyc before Avg if >0", "type": "16Config2HDFattr_t", "value": "800163584", "dim": 1}, 45,47c45,47 < "fst": {"name": "Filename Timestamp", "type": "16Config2HDFattr_t", "value": "20240207_110730", "dim": 1}, < "//6": {"name": "Exp Start Timestamp", "type": "16Config2HDFattr_t", "value": "20240207_110730", "dim": 1}, < "//7": {"name": "Exp End Timestamp", "type": "16Config2HDFattr_t", "value": "20240207_110730", "dim": 1} --- > "fst": {"name": "Filename Timestamp", "type": "16Config2HDFattr_t", "value": "20240207_103431", "dim": 1}, > "//6": {"name": "Exp Start Timestamp", "type": "16Config2HDFattr_t", "value": "20240207_103431", "dim": 1}, > "//7": {"name": "Exp End Timestamp", "type": "16Config2HDFattr_t", "value": "20240207_103431", "dim": 1} ```
jupfi commented 2024-02-07 10:11:52 +00:00 (Migrated from github.com)
Copy link

This pulls request shall not passs in it's current form!

This pulls request shall not passs in it's current form!
kumitterer commented 2024-02-07 11:10:41 +00:00 (Migrated from github.com)
Copy link

With the possible exception of the below, it does seem to be an initialization issue, though. It reads values where it should be reading 0.

This is still weird:

20,21c20,21
< "//2": {"name": "Pulse Duration [Sa]", "type": "16Config2HDFattr_t", "value": "1782541088", "dim": 2},
< "//3": {"name": "IF Pulse Frequency [1/Sa]", "type": "16Config2HDFattr_t", "value": "6.90336e-310", "dim": 2},
---
> "//2": {"name": "Pulse Duration [Sa]", "type": "16Config2HDFattr_t", "value": "-945853664", "dim": 2},
> "//3": {"name": "IF Pulse Frequency [1/Sa]", "type": "16Config2HDFattr_t", "value": "6.94418e-310", "dim": 2},
With the possible exception of the below, it *does* seem to be an initialization issue, though. It reads values where it should be reading 0. This is still weird: ```diff 20,21c20,21 < "//2": {"name": "Pulse Duration [Sa]", "type": "16Config2HDFattr_t", "value": "1782541088", "dim": 2}, < "//3": {"name": "IF Pulse Frequency [1/Sa]", "type": "16Config2HDFattr_t", "value": "6.90336e-310", "dim": 2}, --- > "//2": {"name": "Pulse Duration [Sa]", "type": "16Config2HDFattr_t", "value": "-945853664", "dim": 2}, > "//3": {"name": "IF Pulse Frequency [1/Sa]", "type": "16Config2HDFattr_t", "value": "6.94418e-310", "dim": 2}, ```
kumitterer commented 2024-02-07 11:16:25 +00:00 (Migrated from github.com)
Copy link

Just checked, when I initialize the struct as LimeConfig_t LimeCfg{}; (rather than LimeConfig_t LimeCfg;) in initializeLimeConfig(), that gets rid of that part of the problem. Now I'm trying to figure out the other.

Just checked, when I initialize the struct as `LimeConfig_t LimeCfg{};` (rather than `LimeConfig_t LimeCfg;`) in `initializeLimeConfig()`, that gets rid of that part of the problem. Now I'm trying to figure out the other.
kumitterer commented 2024-02-07 11:23:39 +00:00 (Migrated from github.com)
Copy link

The other issue is already present here, not only in getHDFAttributes.

7414d1490c/src/limedriver.cpp (L427-L428)

The other issue is already present here, not only in getHDFAttributes. https://github.com/nqrduck/LimeDriver/blob/7414d1490cdbbed660e0d16c019ae4aa0582f6be/src/limedriver.cpp#L427-L428
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug

Something isn't working

  
documentation

Improvements or additions to documentation

  
duplicate

This issue or pull request already exists

  
enhancement

New feature or request

  
good first issue

Good for newcomers

  
help wanted

Extra attention is needed

  
invalid

This doesn't seem right

  
question

Further information is requested

  
wontfix

This will not be worked on

No labels
bug
documentation
duplicate
enhancement
good first issue
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: nqrduck/limedriver#6
No description provided.
Delete branch "hdfattr_function_fix"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?