nqrduck/limedriver
1
0
Fork 0
Code Issues 1 Pull requests Projects Releases 1 Packages Wiki Activity Actions

Channel selection fixes #20

Merged
kumitterer merged 8 commits from channel-selection-fixes into main 2024-02-17 17:18:24 +00:00
Conversation 3 Commits 8 Files changed 2 +78 -25
kumitterer commented 2024-02-17 15:49:59 +00:00 (Migrated from github.com)
Copy link

This PR adds two features:

First, it allows passing a device info string as a parameter, allowing selection of a specific LimeSDR when multiple are connected simultaneously (falling back to the first identified device when undefined).

In addition, it adds functions to retrieve the number of TX and RX channels available on the selected LimeSDR, and a check for validity of the selected channel when running an experiment.

N.B.: On the LimeDriverBinding side, this probably requires a change to the LimeConfig object reflecting the added parameter.

This PR adds two features: First, it allows passing a device info string as a parameter, allowing selection of a specific LimeSDR when multiple are connected simultaneously (falling back to the first identified device when undefined). In addition, it adds functions to retrieve the number of TX and RX channels available on the selected LimeSDR, and a check for validity of the selected channel when running an experiment. N.B.: On the LimeDriverBinding side, this probably requires a change to the LimeConfig object reflecting the added parameter.
jupfi commented 2024-02-17 15:55:01 +00:00 (Migrated from github.com)
Copy link

Probably something for the LimeDriverBindings but:

There should be a method that provides the currently available devices as strings. Than it would be easier to select the appropriate device.

Probably something for the LimeDriverBindings but: There should be a method that provides the currently available devices as strings. Than it would be easier to select the appropriate device.
kumitterer commented 2024-02-17 15:57:37 +00:00 (Migrated from github.com)
Copy link

That's already there: 2fa839fbb4/src/limedriver.cpp (L97)

That's already there: https://github.com/nqrduck/LimeDriver/blob/2fa839fbb4ee6c6240c5b2a2d296877199e92667/src/limedriver.cpp#L97
jupfi commented 2024-02-17 15:59:39 +00:00 (Migrated from github.com)
Copy link

Ok then we only need to expose the existing function in the LimeDriverBinding.

Ok then we only need to expose the existing function in the LimeDriverBinding.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug

Something isn't working

  
documentation

Improvements or additions to documentation

  
duplicate

This issue or pull request already exists

  
enhancement

New feature or request

  
good first issue

Good for newcomers

  
help wanted

Extra attention is needed

  
invalid

This doesn't seem right

  
question

Further information is requested

  
wontfix

This will not be worked on

No labels
bug
documentation
duplicate
enhancement
good first issue
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: nqrduck/limedriver#20
No description provided.
Delete branch "channel-selection-fixes"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?