Harsh Shandilya
c0332c42ff
treewide: fix copyright template and apply to all files ( #773 )
...
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-05-13 21:01:41 +05:30
Fabian Henneke
d695d21497
Make APS buildable on F-Droid ( #762 )
...
* Include lib-publicsuffixlist in tree with proper license attribution
* Exclude lib-publicsuffixlist from code style
* Move applicationId to app/build.gradle
* build: add distributionSha256Sum to Gradle
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
* Initial workflow configuration for PSL update
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
* Initial check-in of PSL data
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
Co-authored-by: Harsh Shandilya <me@msfjarvis.dev>
2020-05-12 11:17:08 +02:00
Harsh Shandilya
b16620b55c
Add setting for fallback username ( #772 )
...
* PasswordEntry: remove useless annotations
Turns out VisibleForTesting only applies for documentation purposes. Boo >:(
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
* PasswordEntry: silence locale warning
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
* Add setting for fallback username
Fixes #763
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-05-11 22:13:03 +02:00
Harsh Shandilya
041cf00510
Treewide codestyle cleanup ( #765 )
...
- Updated gitignore and checked in the IDE's codestyle config
- Removed spotless as the underlying ktlint backend has failed to resolve the super frustrating import order bug[1] in nearly a year
- Reformat the entire codebase based on the previously committed code style configuration.
1: https://github.com/pinterest/ktlint/issues/527
2020-05-10 19:21:39 +05:30
Harsh Shandilya
94dc92f8d7
Miscellaneous UI tweaking ( #771 )
...
* Remove dangling UI element and relayout authentication modes
* Drop unnecessary actionBarPopupTheme declaration
* Improve ssh keygen UI
* Commonize button styling
* Tweak save button in server config
* Tweak generate button in ssh keygen
* Commonize OutlinedButton style
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-05-10 14:25:59 +05:30
Fabian Henneke
9a77f6bbea
Use NoBackgroundTheme for utility activities ( #770 )
2020-05-09 19:44:24 +02:00
Harsh Shandilya
4c461fb174
Introduce no-auth mode for connections ( #768 )
...
Fixes #758
Fixes #526
2020-05-08 20:50:04 +05:30
Harsh Shandilya
ed3312b303
PasswordEntry: add user to the potential candidates for username ( #766 )
2020-05-06 13:59:48 +05:30
Harsh Shandilya
feab56994d
PasswordEntry: add more potential fields for username ( #764 )
2020-05-06 01:58:05 +05:30
Harsh Shandilya
f99a14d95b
github: implement path filtering to run actions only when required ( #760 )
2020-05-04 20:59:52 +05:30
The Gitter Badger
adf38e95e6
Add a Gitter chat badge to README.md ( #759 )
2020-05-04 18:29:32 +05:30
Harsh Shandilya
69e887f3d8
Better handle non-git repositories ( #756 )
2020-05-03 01:39:16 +05:30
Harsh Shandilya
ced8bcca01
Confirm password move if it will replace an existing one ( #757 )
...
* Confirm password move if it will replace an existing one
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
* CHANGELOG: update
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-05-01 16:32:58 +05:30
Harsh Shandilya
9696af4024
Update Actions caching and add workflow to validate Gradle wrapper ( #754 )
2020-05-01 15:20:57 +05:30
Harsh Shandilya
92131bc6d4
CODEOWNERS: update for current development scenario ( #755 )
...
- zidhuss while around has been unable to find enough time for doing
code review.
- FabianHenneke has been working on all parts of the app, triaging issues
and has agreed to continue as a maintainer for the next few months
while he can devote the time to this project.
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-05-01 14:11:18 +05:30
Fabian Henneke
c41100eff9
Use official FastScroll fix and refactor PasswordFragment ( #753 )
2020-04-29 08:53:27 +02:00
Harsh Shandilya
edc6dcda88
build: update to openpgp-ktx 2.0 ( #749 )
...
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-04-29 11:01:22 +05:30
Harsh Shandilya
f9c310e93a
release/deploy-github: add rudimentary checks for tag existence
...
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-04-29 03:25:58 +05:30
Harsh Shandilya
4c3ccb42cd
release/deploy-github: automatically switch refs
...
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-04-29 03:21:58 +05:30
Harsh Shandilya
27cc0728d4
build: prepare next release
...
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-04-29 03:15:05 +05:30
Harsh Shandilya
1e67936751
build: bump version
...
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-04-29 03:12:29 +05:30
Fabian Henneke
d1abc09ef7
Fix Autofill icons in dark mode ( #748 )
2020-04-28 13:30:22 +05:30
Harsh Shandilya
6350682bd1
Some README updates ( #746 )
2020-04-26 18:22:01 +05:30
Harsh Shandilya
8cada17bcb
Add toggle for debug logging ( #745 )
2020-04-25 20:34:33 +05:30
Harsh Shandilya
f89d5c282f
Improve UX around settings items ( #744 )
...
Fixes #461
2020-04-25 16:53:40 +05:30
Maxime Catrice
f7dbac4649
Fix search if external root dir starts with a dot ( #743 )
...
Fixes #740
Co-Authored-By: Fabian Henneke <FabianHenneke@users.noreply.github.com>
2020-04-25 15:18:19 +05:30
Harsh Shandilya
73695e2493
auth: redo implementation with a cleaner and simpler API surface ( #741 )
2020-04-24 15:00:33 +05:30
Harsh Shandilya
bee20ac44a
Better detect uninitialized repositories and offer to clone ( #738 )
...
* PasswordRepository: more comprehensive check for valid repository
* PasswordFragment: Give 'repo uninitialized' Snackbar some purpose in life
* GitOperationActivity: finish immediately when an unhandled request code is used
* PasswordFragment: Make uninitialized repo Snackbar indefinite
* spotless
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-04-24 02:05:07 +05:30
Harsh Shandilya
a5437c480a
release/deploy-github: fix tag parameter
...
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-04-23 13:09:03 +05:30
Harsh Shandilya
b0f312cd1e
README: unlist F-Droid for now
...
The version here is deprecated and extremely outdated. We're working on getting F-Droid releases back
up (#648 ) but in the mean time I'd rather people not use wrong versions
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-04-23 12:57:49 +05:30
Harsh Shandilya
b3f6fc20c4
build: prepare next development version
...
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-04-23 12:54:09 +05:30
Harsh Shandilya
9a843b08f3
build: bump version for patch release
...
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-04-23 12:52:24 +05:30
Harsh Shandilya
3d8cea5966
Improve permission handling logic ( #732 )
...
* Improve permission handling logic
Ensure we always ask for storage permissions when required
* Refactor storage permission checks and invert return value
* PasswordStore: improve permission grant flow
* strings: slightly reword permission grant request message
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
Co-authored-by: Fabian Henneke <fabian@henneke.me>
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-04-22 21:57:52 +05:30
Fabian Henneke
00361a58c7
Fix crash when using type independent sort ( #734 )
2020-04-22 18:13:56 +02:00
Fabian Henneke
9c1cc8690d
Mark Autofill onboarding dialog as seen on dismiss ( #731 )
2020-04-22 14:44:25 +05:30
Fabian Henneke
c302d6fe58
Never obscure OK button in Autofill onboarding UI ( #729 )
2020-04-21 21:38:02 +02:00
Harsh Shandilya
0c0649b86d
build: prepare next development version
...
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-04-21 18:39:02 +05:30
Harsh Shandilya
f7e405486f
release/deploy-github: don't attempt to tag before deployment
...
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-04-21 18:39:02 +05:30
Harsh Shandilya
ec0d478b85
build: bump version to 1.7.0
...
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-04-21 18:39:01 +05:30
Harsh Shandilya
3d0850fa1f
build: inline versionCode and versionName at destination
...
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-04-21 18:39:01 +05:30
Harsh Shandilya
e6ea5f6a08
PasswordStore: onboard users to Oreo autofill
...
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-04-21 18:39:00 +05:30
Harsh Shandilya
b0774febb1
Application: only install logging tree in debug features build
...
We should be at a stability level now that does not require logging in prod
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-04-21 15:55:26 +05:30
Harsh Shandilya
500ab60973
treewide: switch to logging via timberkt
...
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-04-21 15:55:26 +05:30
Harsh Shandilya
72166c6912
treewide: use getSystemService extension everywhere
...
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-04-21 15:55:25 +05:30
Harsh Shandilya
d505151662
treewide: use edit extension and cleanup some deprecation
...
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-04-21 15:55:25 +05:30
Harsh Shandilya
e1921b26e0
Remove unused import
...
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-04-21 15:55:25 +05:30
Harsh Shandilya
77096c1702
BaseGitActivity: don't remove saved password unnecessarily
...
if previousUrl is empty it means that this the first time the method is being called, and url
has not been built yet. We let things slide for the first pass so that the actual logic
only kicks in when it needs to.
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-04-21 15:36:30 +05:30
Harsh Shandilya
47c2875e93
Fix protocol validation ( #726 )
...
* GitOperation: code cleanup
* WIP: Fix validation
* Fixup SSH validation
* Spotless
* Remove logging of MalformedURLException
Co-authored-by: Fabian Henneke <fabian@henneke.me>
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-04-20 13:29:10 +05:30
Harsh Shandilya
99aa0d9bb2
Validate hostname protocol before saving ( #723 )
...
* RFC: protocol validation
* Use java.net.URL for saner parsing
* Improve protocol correction; handle ssh://
Co-authored-by: Fabian Henneke <fabian@henneke.me>
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-04-19 17:13:39 +05:30
Harsh Shandilya
7ce8831401
release/deploy-snapshot: Don't swallow errors ( #724 )
...
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-04-19 16:52:14 +05:30