Commit graph

533 commits

Author SHA1 Message Date
Harsh Shandilya
7936ca1e78
Upgrade dependencies (#1289) 2021-01-28 14:48:58 +05:30
Harsh Shandilya
3a2cfd22e6
Migrate versioning to Gradle plugin and automate version bumps (#1282) 2021-01-20 20:27:04 +05:30
Harsh Shandilya
5713c719a5
Update Actions (#1270)
* github: bump actions/upload-artifact to v2.2.2

Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>

* github: bump reactivecircus/android-emulator-runner to v2.14.2

Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>

* github: bump peter-evans/create-pull-request to v3.6.0

Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2021-01-06 13:33:18 +01:00
Harsh Shandilya
1a774eae23
Automate Crowdin localisation sync (#1265)
* build: add a Gradle plugin for Crowdin

Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>

* build/crowdin: add skipCleanup extension property

Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>

* build/crowdin: also handle nonFree source set

Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>

* build/crowdin: fixup directory names for nonFree variant

Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>

* app: sync translations from Crowdin

Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>

* github: add Crowdin sync workflow

Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-12-30 11:06:51 +01:00
Harsh Shandilya
3c85930e6f
Switch back to pull_request to mitigate security issue (#1257)
According to advisory GHSL-2020-367 the changes I made to support pull_request_target make this repository vulnerable to attacks from any malicious forker

Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-12-22 14:02:56 +05:30
Harsh Shandilya
67393ef62d
github: checkout PR head when running checks (#1247)
Fixes: 29778e0e3d ("Strip down README to feature new docs and Discussions (#1243)")
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-12-11 11:23:48 +05:30
Harsh Shandilya
29778e0e3d
Strip down README to feature new docs and Discussions (#1243) 2020-12-10 16:55:31 +05:30
Harsh Shandilya
6642e556c2
github: update peter-evans/create-pull-request to v3.5.1
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-12-07 13:45:38 +05:30
Harsh Shandilya
48e4ed1e91
github: update thomaseizinger/keep-a-changelog-new-release to v1.2.0
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-12-07 13:45:38 +05:30
Harsh Shandilya
9f17d60f99
github: update actions/download-artifact to v2.0.6
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-12-07 13:45:37 +05:30
Harsh Shandilya
51bde071b6
github: update actions/upload-artifact to v2.2.1
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-12-07 13:45:37 +05:30
Harsh Shandilya
b5b0e177d9
github: update actions/checkout to v2.3.4
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-12-07 13:45:37 +05:30
Harsh Shandilya
7cd416216e
github: rename validate_wrapper.yml to validate_gradle_wrapper.yml
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-12-07 13:45:36 +05:30
Harsh Shandilya
be1e840ffe
github: rename release.yml to deploy_github_releases.yml
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-12-07 13:45:36 +05:30
Harsh Shandilya
aff03e34a2
github: remove dependency-tree-diff workflow
We never extracted much value from it

Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-12-07 13:36:13 +05:30
Harsh Shandilya
32e1ce17d0
github: add auto-cancel-redundant-workflow
Automatically cancels existing runs of a PR checking workflow to prevent
redundant checks and wastage of resources.

Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-12-07 13:36:13 +05:30
Harsh Shandilya
8eb55f18a1
Create issue template for RFCs (#1234)
* github: update label directive in issue templates

Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>

* github: add an issue template for RFCs

Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-12-04 19:42:31 +05:30
Harsh Shandilya
c7a5a97722
CODEOWNERS: update to Fabian's new username
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-11-30 13:58:02 +05:30
Harsh Shandilya
7bcdc09b92
github: add release workflow for library subprojects
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-11-29 17:51:17 +05:30
Harsh Shandilya
f19ca706e6
Update kotlinx.coroutines and WhatTheStack (#1177)
* build: bump coroutines, AndroidX test and WhatTheStack

Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>

* github: run dependency analysis workflow in pull_request_target context

Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>

* Downgrade AndroidX test back

Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-10-27 09:42:32 +05:30
Harsh Shandilya
b8e07ae98c
github: add workflow to track dependency tree changes (#1176)
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-10-26 16:55:13 +01:00
Harsh Shandilya
a0ffebd52e
github: fix issue template frontmatter (#1175)
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-10-24 12:27:18 +02:00
Harsh Shandilya
4e22df02fa
Update GitHub Actions workflows (#1169)
* github: switch all actions to their latest versions and pin by SHA1 hash

Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>

* github: switch back to peter-evans/create-pull-request for creating pull requests

Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-10-23 11:33:45 +02:00
Harsh Shandilya
6c1e41ba10
Revamp build configuration (#1156)
* release: move scripts to scripts directory

Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>

* Move CI secrets to secrets directory

Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>

* gradle: uprev to 6.7

Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>

* gradle: suppress warnings about unsupported options

Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>

* build: update dependencies

Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>

* build: move Gradle plugins to ext

Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>

* build: move configuration tasks to buildSrc

Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>

* CHANGELOG: add entry for #1137

Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>

* Fix lint warnings

Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-10-16 17:18:11 +02:00
Harsh Shandilya
544ca59f4d
github: fix release draft workflow (#1152)
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-10-13 12:48:02 +05:30
Harsh Shandilya
facc4d9163
github: update release draft workflow
Switch to $GITHUB_ENV since set-env has been deprecated

Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-10-10 12:29:13 +05:30
Harsh Shandilya
927f228db5
github: update PSL workflow
- Use the pull request action utilized by GitHub for their own projects

- Switch to $GITHUB_ENV since set-env has been deprecated

Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-10-10 12:25:08 +05:30
Harsh Shandilya
8b86f36552
github: lay down some ground rules in issue templates
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-10-10 12:25:07 +05:30
Harsh Shandilya
9dc56214b9 github: switch PR workflow from an allowlist to a blocklist
This is going to be less work to maintain going forward since we won't need to
change it every time we include a new subproject.

Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-10-02 13:12:14 +00:00
Harsh Shandilya
cf0d20299d
github: run apiCheck task in pull requests
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-10-01 19:11:21 +05:30
Harsh Shandilya
28bdbbbcce
github: update workflows to use gradle-cache-action
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-10-01 19:11:21 +05:30
Harsh Shandilya
37ea5d4a49
Revert "github: remove ci-gradle.properties" (#1113)
GitHub's runners are still too weak for us to go by without
doing this: https://pipelines.actions.githubusercontent.com/eRaLlgv7QgiQrEiMWvOVzCfcXl8ehv3iNil9w7DRw7wdT9P1kT/_apis/pipelines/1/runs/2741/signedlogcontent/3?urlExpires=2020-09-21T07%3A46%3A57.1297541Z&urlSigningMethod=HMACV1&urlSignature=6e1r7tlUIn9E2EuEm2i4skqgQwZ4jCmO9ARlGZ6a3SU%3D

This reverts commit 098c765132.
2020-09-21 14:17:06 +05:30
Harsh Shandilya
098c765132
github: remove ci-gradle.properties
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-09-20 22:49:01 +05:30
Harsh Shandilya
bfd9c1d776
github: remove nonFree flavor from tests (#1102)
Our tests have zero differences between these flavors so running 4 jobs rather than 2 just slows us down

Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-09-17 01:00:21 +05:30
Vincent Breitmoser
0810273444
Autofill: Extract AutofillParser into separate subproject (#1101)
Co-authored-by: Harsh Shandilya <me@msfjarvis.dev>
Co-authored-by: Fabian Henneke <fabian@henneke.me>
2020-09-16 23:47:55 +05:30
Harsh Shandilya
2c0ecdfb67
Fix changelog links (#1083)
* changelog: fix links

Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>

* github: prepend 'v' to version passed in changelog action

Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-09-07 07:18:19 +02:00
Harsh Shandilya
258ccc6016
github: also run presubmit tests for buildSrc changes (#1074)
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-09-03 12:03:41 +05:30
Harsh Shandilya
6f42586a8d
github: update workflows to use peter-evans/create-pull-request (#1072)
Turns out the workflow we use currently is far too unreliable.

Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-09-02 18:18:18 +05:30
Harsh Shandilya
1b8fedd8fa
github: switch to debug builds (#1037)
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-08-21 02:38:58 +05:30
Harsh Shandilya
2732f9093e
github: set git config for PSL workflow (#1018)
user.name and user.email are not set by default in a standard Actions workflow

Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-08-13 16:17:04 +05:30
Harsh Shandilya
729fc80255
github: fix derp in PSL update workflow (#983) 2020-07-29 13:08:38 +05:30
Harsh Shandilya
8c2a9a91ef
github: upload test reports on failure
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-07-26 16:48:03 +05:30
Harsh Shandilya
e3cf73885c
Expand OTP and PasswordEntry tests (#968) 2020-07-24 14:33:55 +05:30
Harsh Shandilya
44846d1bde
github: create release as draft
Allows us to verify manually that the generated release is correct before we spam our users with notifications

Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-07-22 15:28:04 +05:30
Harsh Shandilya
bf4955675a
github: fix paths to binaries
Fixes: 9fb492b572 ("Deploy both variants to snapshot directory (#914)")
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-07-22 15:01:49 +05:30
Harsh Shandilya
06b226ae8d
github: update all Actions (#934)
Switch publicsuffix update workflow to use the same pull-request action
as release drafter.

Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-07-14 20:38:34 +02:00
Harsh Shandilya
2f657108b3
github: remove freeDebug variant from pull request matrix (#932)
We don't need this tested and it slows down CI.

Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-07-14 10:31:16 +02:00
Harsh Shandilya
7f3aceaf11
Fix navigation bar theming and reformat (#930) 2020-07-14 11:31:37 +05:30
Harsh Shandilya
9fb492b572
Deploy both variants to snapshot directory (#914)
* Deploy both free and non-free variants

Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>

* build: add product flavor to APK name

Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-07-02 20:23:31 +02:00
Fabian Henneke
ca9c951a53
Fill OTP fields with SMS codes (#900)
* Fill OTP fields with SMS codes

* Allow SMS OTP fill also for web origins

* Introduce free and nonFree build variants

* Fix up workflow

* Improve layout and feature detection

* Workflow changes

* Add Changelog entry

* github: update release workflow for nonFree/Free split

Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>

* Switch to lifecycleScope

* github: make snapshot deploy free variant

Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>

Co-authored-by: Harsh Shandilya <me@msfjarvis.dev>
2020-07-02 13:49:32 +02:00
Harsh Shandilya
a3eaefa50d
Rework GitHub Actions (#893) 2020-06-28 21:28:24 +05:30
Harsh Shandilya
c9149a7663
github: update actions for updated branching logic
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-06-25 00:21:05 +05:30
Harsh Shandilya
eb31385102
Remove API 30 from pull request test matrix (#879)
* Revert "github: run instrumentation tests against API 30 (#847)"

API 30 is too flaky to be a part of our active test suite.

This reverts commit bf33fb2c88.

* github: bump android-emulator-runner action

Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-06-23 18:51:47 +05:30
Harsh Shandilya
fed8236738
Automate release steps (#849) 2020-06-18 12:01:18 +05:30
Harsh Shandilya
dd8df232fb
github: add flow to purge Cloudflare cache after snapshot deploy (#848)
This will ensure that APKs served from Cloudflare's edge will always be fresh.

Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-06-12 22:26:40 +05:30
Harsh Shandilya
bf33fb2c88
github: run instrumentation tests against API 30 (#847) 2020-06-12 16:25:50 +05:30
Harsh Shandilya
7569d40270
Update changelog and pull request template (#842) 2020-06-09 19:20:25 +05:30
Harsh Shandilya
340d870cce
github: run PSL update workflow weekly (#809)
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-05-29 07:59:06 +02:00
Harsh Shandilya
0c45bffaba
github: Switch to dynamic filtering (#786)
Also update cache layout for snapshot deployment workflows
2020-05-23 16:34:10 +05:30
Harsh Shandilya
d103d6d4ba
Add tests for GitServerConfigActivity (#783)
* Add tests for GitServerConfigActivity

* github: disable animations before running UI tests

Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-05-17 01:14:09 +05:30
Fabian Henneke
d695d21497
Make APS buildable on F-Droid (#762)
* Include lib-publicsuffixlist in tree with proper license attribution

* Exclude lib-publicsuffixlist from code style

* Move applicationId to app/build.gradle

* build: add distributionSha256Sum to Gradle

Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>

* Initial workflow configuration for PSL update

Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>

* Initial check-in of PSL data

Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>

Co-authored-by: Harsh Shandilya <me@msfjarvis.dev>
2020-05-12 11:17:08 +02:00
Harsh Shandilya
041cf00510
Treewide codestyle cleanup (#765)
- Updated gitignore and checked in the IDE's codestyle config
- Removed spotless as the underlying ktlint backend has failed to resolve the super frustrating import order bug[1] in nearly a year
- Reformat the entire codebase based on the previously committed code style configuration.

1: https://github.com/pinterest/ktlint/issues/527
2020-05-10 19:21:39 +05:30
Harsh Shandilya
f99a14d95b
github: implement path filtering to run actions only when required (#760) 2020-05-04 20:59:52 +05:30
Harsh Shandilya
9696af4024
Update Actions caching and add workflow to validate Gradle wrapper (#754) 2020-05-01 15:20:57 +05:30
Harsh Shandilya
92131bc6d4
CODEOWNERS: update for current development scenario (#755)
- zidhuss while around has been unable to find enough time for doing
  code review.

- FabianHenneke has been working on all parts of the app, triaging issues
  and has agreed to continue as a maintainer for the next few months
  while he can devote the time to this project.

Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-05-01 14:11:18 +05:30
Fabian Henneke
cd0621864c
Run tests for debug/release on 23/29 (#720)
* Also run unit tests for release build

* Only test on API levels 23 and 29
2020-04-18 20:16:40 +02:00
Harsh Shandilya
4ffd7ed9bf
Enable emulator tests (#708)
* github: Enable instrumentation testing in PRs

Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>

* Upgrade to Gradle 6.3

Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>

* Remove outdated and broken tests, redo PasswordEntryTest in Kotlin

Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>

* Remove now unused test assets

Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>

* github: Disable debug APK uploads in PR testing

Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>

* Update .github/workflows/pull_request.yml

* Update .github/workflows/pull_request.yml

Switching to Ubuntu fails due to the SDK 29 missing.

Co-authored-by: Fabian Henneke <FabianHenneke@users.noreply.github.com>
2020-04-17 00:24:13 +05:30
Fabian Henneke
bebe434683
Add support for Oreo Autofill (#653)
Adds support for the Autofill feature first available in Android Oreo.

In compatible apps and browsers, login forms are automatically detected and
the user is presented with options to fill or generate credentials. In most apps
and certain browsers, the service will also offer to create new Password Store
entries from credentials entered into login forms.

Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
Co-authored-by: Harsh Shandilya <me@msfjarvis.dev>
2020-03-24 14:03:40 +01:00
Harsh Shandilya
bea3cd5457
CI workflow improvements (#642)
* github: Only run debug tasks in PRs

* github: Remove nightly deploys

* github: Setup automatic debug branch deployment

* Tweak Gradle config in CI

Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>

Co-authored-by: Aditya Wasan <adityawasan55@gmail.com>
2020-02-25 15:22:05 +05:30
Harsh Shandilya
052467518e
github: Add action to deploy nightly snapshots (#618)
Signed-off-by: Harsh Shandilya <msfjarvis@gmail.com>
2020-01-26 11:40:01 +05:30
Harsh Shandilya
d5a744bd37 Prepare for new Play Store listing (#602)
* Gradle cleanup

* Update package name

* Remove release APK from git

This should have never been here

* Move package name to dependencies.gradle

* github: Setup caching for gradle

* Update Play Store art

* gradle: Use constraints API in place of deprecated force

* Update dependencies

* Raise minSdk to 23

* Target SDK 28 for now

External storage handling changes are atrocious to support in this codebase so we'll be holding out as far as we can.

* Revert "Opt into legacy external storage handling (#595)"

Not needed on SDK 28

This reverts commit 3f249e4bff.

Signed-off-by: Harsh Shandilya <msfjarvis@gmail.com>
2019-12-31 20:57:38 +05:30
Harsh Shandilya
e61551bf37
Setup snapshot deployment (#599)
* Setup snapshot deployment

* README: Update repository links

* README: Update workflow badge link

* README: Add link to Snapshot builds

* Fix snapshot/pull-request build conflict

* Deploy from feature/deploy-snapshots as well

* Revert "Deploy from feature/deploy-snapshots as well"

Confirmed it works well

This reverts commit 06f6bc0e8c19f238643655d09ca20f83dd416283.

Signed-off-by: Harsh Shandilya <msfjarvis@gmail.com>
2019-12-16 03:19:18 +05:30
Harsh Shandilya
5e1927d068 Remove extraneous GitHub metadata (#586)
Funding is now configured at an organisation level
HCL workflow files are deprecated

Signed-off-by: Harsh Shandilya <msfjarvis@gmail.com>
2019-12-02 20:17:59 +05:30
Harsh Shandilya
241986e4fa github: Remove zeapo from codeowners (#584)
zeapo has not had time to work on APS for a while now and has formally let the rest of us know that he'll be stepping away

Signed-off-by: Harsh Shandilya <msfjarvis@gmail.com>
2019-11-29 14:15:17 +05:30
Harsh Shandilya
f78962ec77
Create FUNDING.yml (#576) 2019-11-18 20:06:57 +05:30
Harsh Shandilya
cbda39c0ea
CODEOWNERS: Adding Skrilltrax as a maintainer (#575)
Signed-off-by: Harsh Shandilya <msfjarvis@gmail.com>
2019-11-18 20:06:44 +05:30
Harsh Shandilya
36c2518f90
github: Add PR and issue templates
Signed-off-by: Harsh Shandilya <msfjarvis@gmail.com>
2019-10-27 22:52:40 +05:30
Harsh Shandilya
90b534e2ea
github: Update workflow settings
Signed-off-by: Harsh Shandilya <msfjarvis@gmail.com>
2019-10-13 11:31:47 +05:30
Harsh Shandilya
f1f59dc1ed
Add Spotless to regulate codestyle (#550)
* Add Spotless to regulate codestyle

* treewide: Run spotless

* Add spotlessCheck to CI test

Signed-off-by: Harsh Shandilya <msfjarvis@gmail.com>
2019-10-02 18:04:18 +05:30
Harsh Shandilya
27592dde10
Migrate to GitHub actions for CI
Signed-off-by: Harsh Shandilya <msfjarvis@gmail.com>
2019-10-02 10:44:16 +05:30
Harsh Shandilya
e37ea38f01
CODEOWNERS: Update to my new username
Signed-off-by: Harsh Shandilya <msfjarvis@gmail.com>
2019-07-28 09:57:11 +05:30
Harsh Shandilya
dcb9fd1c4d
Add CODEOWNERS
[ci skip]

Signed-off-by: Harsh Shandilya <msfjarvis@gmail.com>
2019-05-24 23:11:24 +05:30
Harsh Shandilya
655b3a11f4
Add github action to automatically delete merged branches
Signed-off-by: Harsh Shandilya <msfjarvis@gmail.com>
2019-04-25 09:13:12 +05:30