86cce6d161
Biome as it is now didn't work out for us 😢 Summary for posterity: * it IS much, much faster, fast enough to skip any sort of caching * we couldn't fully replace Prettier just yet. We use Prettier programmatically to format code in docs, and Biome's JS interface is officially alpha and [had legacy peer deps set](https://github.com/biomejs/biome/pull/1756) (which would fail our CI build as we don't allow installation warnings) * ternary formatting differs from Prettier, leading to a large diff https://github.com/biomejs/biome/issues/1661 * import sorting differs from Prettier's `prettier-plugin-organize-imports`, making the diff even bigger * the deal breaker is a multi-second delay on saving large files (for us it's [Editor.ts](https://github.com/tldraw/tldraw/blob/main/packages/editor/src/lib/editor/Editor.ts)) in VSCode when import sorting is enabled. There is a seemingly relevant Biome issue where I posted a small summary of our findings: https://github.com/biomejs/biome/issues/1569#issuecomment-1930411623 Further actions: * reevaluate in a few months as Biome matures ### Change Type - [x] `internal` — Any other changes that don't affect the published package
73 lines
1.7 KiB
YAML
73 lines
1.7 KiB
YAML
name: Checks
|
|
|
|
on:
|
|
pull_request:
|
|
merge_group:
|
|
push:
|
|
branches: [main]
|
|
|
|
env:
|
|
CI: 1
|
|
PRINT_GITHUB_ANNOTATIONS: 1
|
|
|
|
defaults:
|
|
run:
|
|
shell: bash
|
|
|
|
jobs:
|
|
test:
|
|
name: 'Tests & checks'
|
|
timeout-minutes: 15
|
|
runs-on: ubuntu-latest-16-cores-open # TODO: this should probably run on multiple OSes
|
|
|
|
steps:
|
|
- name: Check out code
|
|
uses: actions/checkout@v3
|
|
|
|
- uses: ./.github/actions/setup
|
|
|
|
- name: Check version constraints
|
|
run: yarn constraints
|
|
|
|
- name: Check for duplicate dependencies
|
|
run: yarn dedupe --check
|
|
|
|
# Not the most sophisticated way to check for warnings, but I don't think
|
|
# Yarn can be convinced to exit with a non-zero exit code on warnings
|
|
# see also https://unix.stackexchange.com/a/433713 for the explanation of the parameters
|
|
- name: Check for installation warnings
|
|
run: 'yarn | grep -vzq "with warnings"'
|
|
|
|
- name: Typecheck
|
|
run: yarn build-types
|
|
|
|
- name: Check scripts
|
|
run: yarn check-scripts
|
|
|
|
- name: Lint
|
|
run: yarn lint
|
|
|
|
- name: Check API declarations and docs work as intended
|
|
run: yarn api-check
|
|
|
|
- name: Test
|
|
run: yarn test
|
|
|
|
build:
|
|
name: 'Build all projects'
|
|
timeout-minutes: 15
|
|
runs-on: ubuntu-latest-16-cores-open
|
|
|
|
steps:
|
|
- name: Check out code
|
|
uses: actions/checkout@v3
|
|
|
|
- uses: ./.github/actions/setup
|
|
|
|
- name: Build all projects
|
|
# the sed pipe makes sure that github annotations come through without
|
|
# turbo's prefix
|
|
run: "yarn build | sed -E 's/^.*? ::/::/'"
|
|
|
|
- name: Pack public packages
|
|
run: "yarn lazy pack-tarball | sed -E 's/^.*? ::/::/'"
|