Peter Vágner
ab0ff9b781
BaseDialog: split a very long line
2017-12-12 18:55:57 +01:00
Peter Vágner
321b1adb99
Elliminate lint errors and warnings
2017-12-08 07:47:08 +01:00
Peter Vágner
839f938c91
Argh! Reworked AccessibleButton key handling again. It turned out by
...
fixing behaviour when pressing the enter key breaks behaviour when
pressing space to activate the buttons. So we are now handling enter
onKeyDown and space onKeyUp. Also briefly explained the situation with
comments.
2017-12-07 10:20:27 +01:00
Peter Vágner
4171675221
Add some comments explaining how we are using aria-hidden property to
...
hide content outside of the BaseDialog to screen reader users.
2017-12-07 09:44:00 +01:00
Peter Vágner
f9b0243c8e
Merge branch 'develop' into dialog-a11y
2017-12-06 11:10:18 +01:00
Peter Vágner
9146fde308
Add a missing language string
2017-12-05 23:48:42 +01:00
Peter Vágner
60ada30680
Forgot to turn div displaying error text into an aria-alert in the
...
create group dialog.
2017-12-05 23:46:02 +01:00
Peter Vágner
eda453bbe5
Fixed an issue where pressing enter key to activate the AccessibleButton
...
was also activating normal button that might just have received the
system focus as a result of the key press and the other way round.
The most obvious occurence of this issue is that dialogs were
reappearing when dismissed by pressing the enter key.
2017-12-05 23:23:40 +01:00
Peter Vágner
a31af39ca8
Applied aria-describedby to all other dialogs that are using BaseDialog.
...
Also added initial focus where it has not been set.
2017-12-05 13:52:20 +01:00
Richard Lewis
9eb334a1d4
Merge pull request #1640 from matrix-org/rxl881/widgetTitle
...
Add widget -> riot postMessage API
2017-12-05 12:02:57 +00:00
David Baker
130c056ed9
Merge pull request #1646 from matrix-org/dbkr/nullchecks4u
...
Add some null checks
2017-12-05 11:59:24 +00:00
David Baker
87c808a088
semicolon
2017-12-05 11:53:49 +00:00
David Baker
fec2e31b41
oops, actual null check
2017-12-05 11:38:25 +00:00
David Baker
c23a3fd7fe
Add some null checks
2017-12-05 11:14:55 +00:00
Richard Lewis
ac36f93c3f
Remove logging.
2017-12-05 11:00:38 +00:00
Peter Vágner
4f83f6cf25
Move keyboard focus management back to the BaseDialog rather than
...
leaving it in the Modal manager.
We are using Modal manager to load other components not just BaseDialog
and its subclasses and they might require different keyboard handling.
Also depend on focus-trap-react rather than react-focus-trap for locking
keyboard focus inside the dialog. The experience is much nicer and even
the FocusTrap element it-self no longer gains the focus.
On a side note using the FocusTrap element outside the dialog (on
its parent) stops it from working properly.
2017-12-05 08:50:40 +01:00
Richard Lewis
59f9e388d4
Remove logging.
2017-12-05 00:11:01 +00:00
Richard Lewis
49a2985515
Register message endpoints.
...
Store endpoint origins only.
2017-12-05 00:08:17 +00:00
Richard Lewis
8595053d28
Update API data docs.
2017-12-04 18:06:05 +00:00
Richard Lewis
df1fa80ff6
Use global object for listener count and messaging endpoints.
2017-12-04 17:54:00 +00:00
Luke Barnard
4f58b92a14
Merge branch 'master' into develop
2017-12-04 12:24:56 +00:00
Luke Barnard
1a283f90f5
v0.11.3
2017-12-04 12:24:21 +00:00
Luke Barnard
d2cb46159b
Prepare changelog for v0.11.3
2017-12-04 12:24:21 +00:00
Luke Barnard
50e227f5c0
Bump js-sdk dep. to 0.9.2
2017-12-04 12:15:19 +00:00
Luke Barnard
aee04e41a6
Bump js-sdk dep. to 0.9.2
2017-12-04 11:59:01 +00:00
Peter Vágner
5ccbcf02e2
Several changes improving accessibility of the dialogs
...
- Wrapped all the modals inside a react-focus-trap component disabling
keyboard navigation outside the modal dialogs
- Disabled our custom key handling at dialog level. Cancelling on esc
key is now handled via FocusTrap component.
- Removed onEnter prop from the BaseDialog component. Dialogs that
submit data all now embed a form with onSubmit handler. And since
keyboard focus is now managed better via FocusTrap it no longer makes
sense for the other dialog types. Fixes
https://github.com/vector-im/riot-web/issues/5736
- Set aria-hidden on the matrixChat outer node when showing dialogs to
disable navigating outside the modals by using screen reader specific
features.
2017-12-03 21:38:21 +01:00
Richard Lewis
dd7358cbb4
Use strict equality.
2017-12-01 16:39:07 +00:00
Richard Lewis
9dabf19d1b
Improve readability.
2017-12-01 16:35:55 +00:00
Richard Lewis
81f7f805fa
Fix check
2017-12-01 16:31:39 +00:00
Richard Lewis
024aefe131
Use ES6 style exports.
2017-12-01 16:17:18 +00:00
Richard Lewis
58616a45ef
Add API endpoints to get current widget postMessage API version and supported API versions.
2017-12-01 15:56:30 +00:00
Richard Lewis
5239729e8e
Return a response to widget postMessage request (inline with scalarMessaging API).
2017-12-01 14:56:27 +00:00
Richard Lewis
81fdccb109
Add API description comment.
2017-12-01 14:44:14 +00:00
Luke Barnard
641add4964
Fix one kind of scroll jump
...
by calling onWidgetLoad when the <img> in MImageBody loads
2017-12-01 14:18:13 +00:00
Luke Barnard
b26cf23574
Merge pull request #1641 from matrix-org/luke/tag-panel-shift-click-semantics
...
Implement shift-click and ctrl-click semantics for TP
2017-12-01 12:04:21 +00:00
Luke Barnard
363fe04a10
isCtrlOrCmdKeyEvent -> isOnlyCtrlOrCmdKeyEvent
2017-12-01 10:44:00 +00:00
Luke Barnard
ddd0e161c0
Fix broken imports
2017-12-01 10:41:56 +00:00
Luke Barnard
fe81fcb8c6
Factor out isCtrlOrCmdKeyEvent, use that in TagPanel
...
as opposed to the incorrect ctrl || meta
2017-12-01 10:30:49 +00:00
David Baker
f30094c648
Merge pull request #1642 from matrix-org/luke/tag-panel-do-not-view-group
...
Don't show group when clicking tag panel
2017-11-30 15:43:24 +00:00
Luke Barnard
eaaa9fe747
Don't show group when clicking tag panel
2017-11-30 15:35:40 +00:00
Richard Lewis
5ff5ca4705
Remove logging and broken title fetching functions.
2017-11-30 14:50:30 +00:00
Luke Barnard
3bcb3195c4
Implement shift-click and ctrl-click semantics for TP
2017-11-30 14:48:54 +00:00
Richard Lewis
87eab7573c
Handle widget content loaded events.
2017-11-30 12:26:40 +00:00
Richard Lewis
be603fecb0
Register and de-register widget postMessage endpoints.
2017-11-30 11:30:30 +00:00
Richard Lewis
2cfbbb000e
Refactor messaging listerners.
2017-11-30 10:20:29 +00:00
Stefan Parviainen
437a440bdf
Add missing id
...
Signed-off-by: Stefan Parviainen <pafcu@iki.fi>
2017-11-30 08:32:18 +01:00
Richard Lewis
4f5f44ff38
Add widget postmessage API stub.
2017-11-29 22:16:22 +00:00
Stefan Parviainen
cb5c9f2c5a
Make Dialogs more accessible
...
Signed-off-by: Stefan Parviainen <pafcu@iki.fi>
2017-11-29 21:13:48 +01:00
Luke Barnard
7118f7a38f
gen-18n
2017-11-29 18:41:08 +00:00
Luke Barnard
feb193afd4
Merge pull request #1639 from matrix-org/luke/feature-tag-panel
...
Implement TagPanel (or LeftLeftPanel) for group filtering
2017-11-29 18:16:43 +00:00
