Commit graph

41 commits

Author SHA1 Message Date
Michael Telatynski
f0ee7f7905
Merge matrix-react-sdk into element-web
Merge remote-tracking branch 'repomerge/t3chguy/repomerge' into t3chguy/repo-merge

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
2024-10-15 15:32:09 +01:00
David Baker
5f1f018a30 Fundamental behaviour, not return type 2024-05-10 16:52:19 +01:00
David Baker
f2da5fcf2c
Fix typos and clarify wording
Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
2024-05-10 16:49:05 +01:00
David Baker
8ba3f53d2c Hopefully clarify 2024-05-10 10:48:11 +01:00
David Baker
36571edb95 Prettier 2024-05-09 10:53:33 +01:00
David Baker
3a159beb21 Add code style rule for multiple return types 2024-05-09 10:42:26 +01:00
David Baker
aae59b93e6
Re-write the rule about casting to be clearer ()
This is the proposal from the comments on https://github.com/vector-im/element-web/pull/26220
(so effectively an alternative to that PR, if you like).
2023-10-09 14:34:36 +01:00
Richard van der Hoff
40f95a6c06
Deprecate $spacing variables ()
Per https://github.com/matrix-org/matrix-react-sdk/pull/10686, these don't make
much sense at the moment.
2023-04-21 15:12:08 +01:00
Michael Weimann
ece117b33f
Improve CSS class naming style guide () 2023-04-21 12:54:57 +02:00
Richard van der Hoff
b9b52c8c06
code_style.md: Add notes on comments () 2023-03-30 12:28:22 +01:00
Michael Weimann
9a55019d65
Align code_style.md with prettier () 2023-01-02 14:32:33 +01:00
Michael Weimann
7921a6cbf8
Apply prettier formatting 2022-12-09 13:28:29 +01:00
Michael Weimann
b2704d5bde
Link contributing guide to Element Web ()
* Link contributing to Element Web

* Update README.md

Co-authored-by: Travis Ralston <travisr@matrix.org>

* Update README.md

Co-authored-by: Travis Ralston <travisr@matrix.org>

Co-authored-by: Travis Ralston <travisr@matrix.org>
2022-09-01 13:49:52 +02:00
Michael Weimann
143632adb0
Add 2022 code style ()
* Add 2022 code style

* Update CONTRIBUTING/code_style
2022-09-01 13:49:44 +02:00
Kerry
158e42f764
Unit test MessageActionBar ()
* test most basic paths in messageactionbar

Signed-off-by: Kerry Archibald <kerrya@element.io>

* tidy

Signed-off-by: Kerry Archibald <kerrya@element.io>

* add rtl

* add code style note about using rtl

Signed-off-by: Kerry Archibald <kerrya@element.io>

* downgrade to rtl 12

* use rtl for MessageActionBar test

Signed-off-by: Kerry Archibald <kerrya@element.io>

* try mocking settingsstore for ci only failure

Signed-off-by: Kerry Archibald <kerrya@element.io>

* mock setValue too

Signed-off-by: Kerry Archibald <kerrya@element.io>

* uupdate lockfile

Signed-off-by: Kerry Archibald <kerrya@element.io>
2022-06-02 10:25:56 +02:00
Clemens Zeidler
e8e0d808d4 Remove out-dated comment about flow annotation 2021-01-26 21:25:12 +13:00
czeidler
662d89659f
Update code_style.md
Co-authored-by: J. Ryan Stinnett <jryans@gmail.com>
2021-01-26 21:23:11 +13:00
Clemens Zeidler
87f752dfa1 Add reference to TypeScript in the comment on flow annotations
Signed-off-by: Clemens Zeidler <clemens.zeidler@gmail.com>
2021-01-22 22:22:33 +13:00
Clemens Zeidler
3eae714269 Update code_style.md
- Remove invalid single quotes item
- Add TypeScript section
- Add item regarding React function components and hooks

Signed-off-by: Clemens Zeidler <clemens.zeidler@gmail.com>
2021-01-19 21:36:02 +13:00
Matthew Hodgson
7750c95a02 typoe 2020-05-30 00:43:55 +01:00
Matthew Hodgson
f3fedc5fc4 fix url 2020-05-30 00:42:23 +01:00
Michael Telatynski
5618c382bd
Update code style to mention switch statements 2020-05-20 16:01:34 +01:00
Michael Telatynski
d22985f12e Migrate string refs over to createRef
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
2019-12-08 12:16:17 +00:00
J. Ryan Stinnett
8f79661725 Update code style for our 90 char life
We've been using 90 chars for JS code for quite a while now, but for some
reason, the code style guide hasn't admitted that, so this adjusts it to match
ESLint settings.
2019-11-20 10:30:42 +00:00
Michael Kohler
8eb07197cc Rename UPPER_CAMEL_CASE to UPPER_SNAKE_CASE in Coding Style 2019-10-06 13:08:46 +02:00
J. Ryan Stinnett
757181c322 Update React guide in code style
This updates React guidance to prefer JS classes and adds additional info about
how to handle specific situations when using them.

Signed-off-by: J. Ryan Stinnett <jryans@gmail.com>
2018-12-06 16:34:54 -06:00
Michael Telatynski
73d68c5513 no leading lines for else,finally,catch etc 2017-05-18 23:03:34 +01:00
Michael Telatynski
2ac3371ea4 Don't suggest vars!! 2017-05-18 22:51:22 +01:00
Richard van der Hoff
86a24fb5de Fix some markdown ih the code style doc 2016-11-01 11:33:06 +00:00
Matthew Hodgson
8349ea4b0e fix code style for ES6 classes 2016-11-01 10:58:56 +00:00
Aviral Dasgupta
b62622a814 Improve autocomplete behaviour
Fixes 
2016-09-13 15:46:02 +05:30
David Baker
e00f3d9334 Mark code blocks as javascript 2016-07-11 16:28:41 +01:00
David Baker
513492e1bf Change line length as per PR discussion 2016-07-11 16:27:17 +01:00
David Baker
a28a335df4 More newlines for formatting 2016-07-11 16:21:21 +01:00
David Baker
8d1d37c103 Try newline to fix code style formatting 2016-07-11 16:19:14 +01:00
David Baker
ffbe045fcc Change to const-by-default 2016-07-11 10:10:51 +01:00
David Baker
0fdc2d817c mark as jsx 2016-07-08 15:59:34 +01:00
David Baker
1a3bc814e1 clarify event handlers 2016-07-08 15:58:18 +01:00
David Baker
afa6acc20a All the trailing commas 2016-07-08 15:42:42 +01:00
David Baker
04728ae03b PR fixes + more general notes 2016-07-07 12:09:02 +01:00
David Baker
56c73b68a9 Use markdown
because the rst wasn't formatting and we use md for everything else in this repo, and in a document that talks about consistency...
2016-07-04 17:23:38 +01:00
Renamed from code_style.rst (Browse further)