Commit graph

41940 commits

Author SHA1 Message Date
Matthew Hodgson
22712d3091
fix ugly warning from nesting div tags in p tags (#8094)
might make negligible spacing changes to text buttons in MemberInfo, but not enough that i could spot them.
2022-03-21 10:27:19 +00:00
Matthew Hodgson
b8b5dd82aa
Triple the speed of E2E tests and stop them exploding if a circular datastructure is logged (#8095)
* stop e2e tests exploding if a circular datastructure is logged

it's valid for the webapp to log datastructures to the console which happen to be circular
but the e2e test running explodes badly with a runtime exception and bombs out before
logging anything or providing a sensible stacktrace. you can trap the exception though and
get a sensible error however.

* don't barf on circular refs in return vals either

and log timestamps

* log timestamps

* speed up roomDir & E2EE tests by 3x

use timeouts correctly, so the first set
of scenarios take 42s to run rather than 2m21s

* speed up space test by 20s
2022-03-21 10:26:26 +00:00
Kerry
026ca1ab64
Fix tsc issues in right_panel and room component tests (#8078)
* fix ts issues in SendMessageComposer-test

Signed-off-by: Kerry Archibald <kerrya@element.io>

* remove empty file

Signed-off-by: Kerry Archibald <kerrya@element.io>

* fix tsc issues in MessageComposerbUttons-test

Signed-off-by: Kerry Archibald <kerrya@element.io>

* fix the rest

Signed-off-by: Kerry Archibald <kerrya@element.io>

* bad autoformatter

Signed-off-by: Kerry Archibald <kerrya@element.io>

* tsc fixes for test/components/views/right_panel

Signed-off-by: Kerry Archibald <kerrya@element.io>
2022-03-21 10:03:03 +01:00
Suguru Hirahara
d7a3f39a3e
Remove padding of InviteDialog & fix visual regression (#8076)
* Remove padding of InviteDialog

Closes https://github.com/vector-im/element-web/issues/20631

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Fix visual regression of InviteDialog

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
2022-03-18 15:28:21 -06:00
Suguru Hirahara
cec6a76352
Retry fixing buttons alignment of Space list header (#8080)
Closes https://github.com/vector-im/element-web/issues/21463

- Move min-height property

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
2022-03-18 15:26:35 -06:00
Robin
83f2bf4261
Improve remove recent messages dialog (#6114)
* Allow keeping state events when removing recent messages

The remove recent messages dialog redacts most state events since they
can be abuse vectors as well, however some users that see the option
actually want to use it to only remove messages. This adds a checkbox
option to do so.

Signed-off-by: Robin Townsend <robin@robin.town>

* Don't redact encryption events when removing recent messages

Signed-off-by: Robin Townsend <robin@robin.town>

* Show UserMenu spinner while removing recent messages

This also generalizes the UserMenu spinner to work with other types of
actions in the future.

Signed-off-by: Robin Townsend <robin@robin.town>

* Clarify remove recent messages warning

Clarify that they are removed for everyone in the conversation, not just
yourself.

Signed-off-by: Robin Townsend <robin@robin.town>

* Adjust copy and preserve state events by default

* Redact messages in reverse chronological order

Signed-off-by: Robin Townsend <robin@robin.town>
2022-03-18 20:08:32 +00:00
Travis Ralston
d8a939df5d
Use & enforce snake_case naming convention on config.json settings (#8062)
* Document and support the established naming convention for config opts

This change:
* Rename `ConfigOptions` to `IConfigOptions` to match code convention/style, plus move it to a dedicated file
* Update comments and surrounding documentation
* Define every single documented option (from element-web's config.md)
* Enable a linter to enforce the convention
* Invent a translation layer for a different change to use
* No attempt to fix build errors from doing this (at this stage)

* Add demo of lint rule in action

* Fix all obvious instances of SdkConfig case conflicts

* Fix tests to use SdkConfig directly

* Add docs to make unset() calling safer

* Appease the linter

* Update documentation to match snake_case_config

* Fix more instances of square brackets off SdkConfig
2022-03-18 10:12:36 -06:00
Suguru Hirahara
09c57b228e
Fixes mx_MLocationBody_markerBorder (#8069)
Fixes https://github.com/vector-im/element-web/issues/21444

This commit fixes the position of the avatar on the location pin on the
timeline.

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
2022-03-18 16:43:44 +01:00
Kerry
ab934a2a08
kill beacons on expiry (#8075)
Signed-off-by: Kerry Archibald <kerrya@element.io>
2022-03-18 14:38:41 +01:00
Germain
12d26555af
Move timeline set creation logic to the JS SDK (#8070) 2022-03-18 11:59:03 +00:00
Kerry
da097d42ef
fix ts issues in SendMessageComposer-test (#8077)
* fix ts issues in SendMessageComposer-test

Signed-off-by: Kerry Archibald <kerrya@element.io>

* remove empty file

Signed-off-by: Kerry Archibald <kerrya@element.io>

* better event type for m.room.message

Signed-off-by: Kerry Archibald <kerrya@element.io>
2022-03-18 10:07:33 +00:00
Kerry
cdcf6d0fd1
Live location sharing: create beacon info event from location picker (#8072)
* create beacon info event with defaulted duration

Signed-off-by: Kerry Archibald <kerrya@element.io>

* add shareLiveLocation fn

Signed-off-by: Kerry Archibald <kerrya@element.io>

* test share live location

Signed-off-by: Kerry Archibald <kerrya@element.io>

* i18n

Signed-off-by: Kerry Archibald <kerrya@element.io>
2022-03-18 10:52:24 +01:00
Germain
4e4ce65f58
Use redaction enum event type rather than hardcoded string (#8071) 2022-03-17 18:38:29 +01:00
Kerry
176e49e312
enable geolocation behaviour in location picker for live share type (#8068)
* enable geolocation behaviour in location picker for live share type

Signed-off-by: Kerry Archibald <kerrya@element.io>

* add empty lines

Signed-off-by: Kerry Archibald <kerrya@element.io>
2022-03-17 09:26:47 +01:00
Kerry
9f6c238827
Add simple live share warning (#8066)
* add simple live share warning

Signed-off-by: Kerry Archibald <kerrya@element.io>

* rough first cut of OwnBeaconStore

Signed-off-by: Kerry Archibald <kerrya@element.io>

* working (?) has live beacons status

Signed-off-by: Kerry Archibald <kerrya@element.io>

* lint

Signed-off-by: Kerry Archibald <kerrya@element.io>

* add left panel share warning

Signed-off-by: Kerry Archibald <kerrya@element.io>

* setup for tests

Signed-off-by: Kerry Archibald <kerrya@element.io>

* test ownbeaconstore

Signed-off-by: Kerry Archibald <kerrya@element.io>

* add copyright

Signed-off-by: Kerry Archibald <kerrya@element.io>

* add copyright

Signed-off-by: Kerry Archibald <kerrya@element.io>

* remove warning banner

Signed-off-by: Kerry Archibald <kerrya@element.io>

* fix test

Signed-off-by: Kerry Archibald <kerrya@element.io>

* fix tests for weird asyncstore closure issues

Signed-off-by: Kerry Archibald <kerrya@element.io>

* fix OwnBeaconStore more...

Signed-off-by: Kerry Archibald <kerrya@element.io>

* revert loose change to LeftPanel

Signed-off-by: Kerry Archibald <kerrya@element.io>

* Revert "remove warning banner"

This reverts commit 4529813b12e3206731f18e0514aa6e0f6896d03a.

* test live share warning

Signed-off-by: Kerry Archibald <kerrya@element.io>
2022-03-17 09:25:57 +01:00
Germain
59584cdc3e
Threads experimental transition modal (#8065) 2022-03-16 16:35:25 +00:00
Kerry
bb6ae3fdbc
Live beacons: track users live beacons (#8061)
* add simple live share warning

Signed-off-by: Kerry Archibald <kerrya@element.io>

* rough first cut of OwnBeaconStore

Signed-off-by: Kerry Archibald <kerrya@element.io>

* working (?) has live beacons status

Signed-off-by: Kerry Archibald <kerrya@element.io>

* lint

Signed-off-by: Kerry Archibald <kerrya@element.io>

* add left panel share warning

Signed-off-by: Kerry Archibald <kerrya@element.io>

* setup for tests

Signed-off-by: Kerry Archibald <kerrya@element.io>

* test ownbeaconstore

Signed-off-by: Kerry Archibald <kerrya@element.io>

* add copyright

Signed-off-by: Kerry Archibald <kerrya@element.io>

* add copyright

Signed-off-by: Kerry Archibald <kerrya@element.io>

* remove warning banner

Signed-off-by: Kerry Archibald <kerrya@element.io>

* fix test

Signed-off-by: Kerry Archibald <kerrya@element.io>

* fix tests for weird asyncstore closure issues

Signed-off-by: Kerry Archibald <kerrya@element.io>

* fix OwnBeaconStore more...

Signed-off-by: Kerry Archibald <kerrya@element.io>

* revert loose change to LeftPanel

Signed-off-by: Kerry Archibald <kerrya@element.io>
2022-03-16 17:35:09 +01:00
Kerry
e677901eaf
Add test utils for Beacons (#8064)
* copy beacon event test utils from js-sdk

Signed-off-by: Kerry Archibald <kerrya@element.io>

* mock with event emitter test util

* set return type getMockClientWithEventEmitter

Signed-off-by: Kerry Archibald <kerrya@element.io>

* fix lint

Signed-off-by: Kerry Archibald <kerrya@element.io>

* copyright

Signed-off-by: Kerry Archibald <kerrya@element.io>

* pr improvements

Signed-off-by: Kerry Archibald <kerrya@element.io>
2022-03-16 13:11:06 +00:00
Suguru Hirahara
6ee54b6480
Make margin and padding of mx_InviteDialog_other consistent (#8063) 2022-03-16 12:15:02 +00:00
Alexander Stephan
26e6f8deca
Improve formatting features in the editor (#7104)
Co-authored-by: Michael Telatynski <7t3chguy@gmail.com>
2022-03-16 09:46:07 +00:00
Andy Balaam
cbf5fbf870
Enable the live location share button (#8056) 2022-03-16 09:37:09 +00:00
Andy Balaam
e1fdff46f5
Show "Share my location" button (#8054) 2022-03-15 15:04:52 +00:00
RiotRobot
2778fd135e Reset matrix-js-sdk back to develop branch 2022-03-15 14:34:00 +00:00
RiotRobot
2ed18a1d85 Resetting package fields for development 2022-03-15 14:33:47 +00:00
RiotRobot
d592537a3a Merge branch 'master' into develop 2022-03-15 14:33:46 +00:00
RiotRobot
ac3a907238 v3.42.0 2022-03-15 14:31:45 +00:00
RiotRobot
67f81f05aa Prepare changelog for v3.42.0 2022-03-15 14:31:44 +00:00
RiotRobot
ddb3f57470 Upgrade matrix-js-sdk to 16.0.0 2022-03-15 14:26:48 +00:00
David Baker
7ca7aa1303
Merge pull request from GHSA-qmf4-7w7j-vf23 (#8059)
Co-authored-by: J. Ryan Stinnett <jryans@gmail.com>
2022-03-15 14:14:25 +00:00
J. Ryan Stinnett
c4428a804c
Merge pull request from GHSA-qmf4-7w7j-vf23 2022-03-15 14:08:34 +00:00
David Baker
4d6643c7b8
Fix freeze/crash when 1:1 calling (#8057) (#8058)
* Fix freeze/crash when 1:1 calling

Don't log call feed objects because they reference the client and
it causes the client to get logged too.

* Log purpose too
2022-03-15 14:06:22 +00:00
Germain
2acc8fd18b
Implement is_falling_back in accordance to MSC3440 (#8055) 2022-03-15 13:52:37 +00:00
David Baker
cc9651089e
Fix freeze/crash when 1:1 calling (#8057)
* Fix freeze/crash when 1:1 calling

Don't log call feed objects because they reference the client and
it causes the client to get logged too.

* Log purpose too
2022-03-15 13:52:22 +00:00
Robin
744eeb53fe
Don't assume that widget IDs are unique (#8052)
* Don't assume that widget IDs are unique

Signed-off-by: Robin Townsend <robin@robin.town>

* Don't remove live tiles that don't exist

Signed-off-by: Robin Townsend <robin@robin.town>

* Add unit test for AppTile's live tile tracking

Signed-off-by: Robin Townsend <robin@robin.town>
2022-03-15 12:15:26 +00:00
Kerry
bc8fdac491
fix more type issues in unit tests (#8053)
* fix ts issues in test/components/structures

Signed-off-by: Kerry Archibald <kerrya@element.io>

* fix ts issues in test/components/views/context_menus

Signed-off-by: Kerry Archibald <kerrya@element.io>
2022-03-15 10:30:48 +01:00
Travis Ralston
813a60a7f3
Remove left panel widgets (#8044)
They aren't practically used, and are difficult to set up in the first place (requires server-managed account or devtools).
2022-03-14 19:39:35 -06:00
Šimon Brandner
8d13e238b9
Keybinding code unification #6 (#8042) 2022-03-14 13:25:51 +00:00
Andy Balaam
e725f14651
Further attempt to prevent codecov posting failure messages (#8050) 2022-03-14 11:01:02 +00:00
David Baker
23d5ba9c89
Support MSC3026 busy presence (#8043)
* Support MSC3026 busy presence

* Use UnstableValue

* Add the import
2022-03-14 10:22:12 +00:00
Suguru Hirahara
afadea01a0
Reuse a common part of the translation (#7978) 2022-03-14 09:12:02 +00:00
Suguru Hirahara
64e9cdd619
Fix the header of Space landing page (#8048) 2022-03-14 09:11:12 +00:00
Suguru Hirahara
ed6a371616
Fix buttons alignment of Space list header (#8047) 2022-03-14 09:07:36 +00:00
Michael Telatynski
14807de552
Show displayname in non-narrow thread summeries (#8036)
* Show displayname in non-narrow thread summeries

* Iterate PR

* Iterate PR to use line-height based approach

* Fix hover/focus chevron on thread summary relying on font character
2022-03-11 19:24:18 +00:00
Ankur
c0fec42387
Fixed a minor typo (#8041) 2022-03-11 11:59:49 -07:00
Germain
7508fd975f
Prevent thread creation on events with existing relation (#8037) 2022-03-11 17:51:38 +00:00
Michael Telatynski
4b0df21b0a
Fix null-guarding regression around reply_to_event dispatch (#8039) 2022-03-11 17:21:28 +00:00
Michael Telatynski
5262d5c315
Fix clicking on copy link to thread wrongly opening thread (#8038) 2022-03-11 17:13:23 +00:00
Travis Ralston
4a36f9b470
Fix logging in end-to-end tests (#8028)
* Nullcheck the argument being stringified

* Improve null handling of responses in requestfinished

Apparently puppeteer can race on this
2022-03-11 10:00:22 -07:00
Kerry
df6c53ff41
include /test/stores in tsconfig (#8026)
* fix space store emits

Signed-off-by: Kerry Archibald <kerrya@element.io>

* fix spacestore-test imports

* fix export-test.tsx

Signed-off-by: Kerry Archibald <kerrya@element.io>

* include test/utils to tsconfig

Signed-off-by: Kerry Archibald <kerrya@element.io>

* fix types in SpaceStore-test

Signed-off-by: Kerry Archibald <kerrya@element.io>

* fix ts issues in rest of test/stores

Signed-off-by: Kerry Archibald <kerrya@element.io>

* include test/stores in tsconfig

Signed-off-by: Kerry Archibald <kerrya@element.io>
2022-03-11 17:03:33 +01:00
Michael Telatynski
ceb2281d36
Fix regression around replying to search results (#8035) 2022-03-11 15:40:49 +00:00