openwrtv4/package
Christian Lamparter 3fce12568a kernel: modules: fix kmod-regmap redux
Jonas Gorski commented on the previous patch:
|This is actually the wrong fix and papers over an issue in one of our
|local patches.
|
|We intentionally allow regmap to be built as a module, see
|
|/target/linux/generic/hack-4.14/259-regmap_dynamic.patch
|[...]
|[The regulator code] optionally supports regmap thanks to the stubs
|provided if regmap is disabled - which breaks if you compile regmap
|as a module.

In order to mitigate this issue, this patch reverts the previous patch
and replaces the existing IS_ENABLED(CONFIG_REGMAP) with
IS_REACHABLE(CONFIG_REGMAP). This solves this particular issue as the
regulator code will now automatically fallback to the regmap stubs in
case the kmod-regmap module is enabled, but nothing else sets
CONFIG_REGMAP=y.

Note: There's still a potential issue that this patch doesn't solve:
If someone ever wants to make a OpenWrt kernel package for a
regulator module that requires the REGMAP feature for a target that
doesn't set CONFIG_REGMAP=y but has CONFIG_REGULATOR=y, the resulting
kmod-regulator-xyz package will not work on the target.
Luckily, there aren't any in-tree OpenWrt kernel module packages for
regulators at the moment. On the bright side: regmap is a critical
part nowadays and all new and upcoming architectures require it by
default. This will likely only ever be a problem for legacy targets
and devices that cannot afford to enable REGMAP.

Cc: Jonas Gorski <jonas.gorski@gmail.com>
Cc: John Crispin <john@phrozen.org>
Fixes: d00913d121 ("kernel: modules: fix kmod-regmap")
Signed-off-by: Christian Lamparter <chunkeey@gmail.com>
2018-08-06 07:17:12 +02:00
..
base-files base-files: sysupgrade: abort if config backup fails 2018-08-06 06:51:44 +02:00
boot kirkwood: add support for Iomega Storcenter ix2-200 2018-07-30 15:21:00 +02:00
devel gdb: bump to 8.1.1 2018-08-01 16:12:53 +02:00
firmware ath10k: update QCA4019 firmware 2018-07-30 10:43:35 +02:00
kernel kernel: modules: fix kmod-regmap redux 2018-08-06 07:17:12 +02:00
libs uclient: update to latest git HEAD 2018-08-03 23:50:29 +02:00
network wireguard: bump to 0.0.20180802 2018-08-04 04:04:34 +00:00
system ca-caertificates: remove myself as PKG_MAINTAINER 2018-07-31 00:00:20 +02:00
utils busybox: update to 1.29.2 2018-08-02 22:36:00 +02:00
Makefile imagebuilder: reuse rootfs preparation from rootfs.mk 2018-03-07 09:59:08 +01:00