rottenwheel/monero
1
0
Fork 0
mirror of https://codeberg.org/anoncontributorxmr/monero.git synced 2024-11-29 18:53:14 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Updates from security audit

Browse source 
https://suyash67.github.io/homepage/assets/pdfs/bulletproofs_plus_audit_report_v1.1.pdf
This commit is contained in:
Sarang Noether 2021-02-11 20:58:35 -05:00 committed by moneromooo-monero
parent b7713cce26
commit b535d662b9
1 changed files with 10 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
src/ringct/bulletproofs_plus.cc
View file

@ -224,9 +224,9 @@ namespace rct
// Output (1,x,x**2,...,x**{n-1}) // Output (1,x,x**2,...,x**{n-1})
static rct::keyV vector_of_scalar_powers(const rct::key &x, size_t n) static rct::keyV vector_of_scalar_powers(const rct::key &x, size_t n)
{ {
CHECK_AND_ASSERT_THROW_MES(n != 0, "Need n > 0");
rct::keyV res(n); rct::keyV res(n);
if (n == 0)
return res;
res[0] = rct::identity(); res[0] = rct::identity();
if (n == 1) if (n == 1)
return res; return res;
@ -244,6 +244,7 @@ namespace rct
static rct::key sum_of_even_powers(const rct::key &x, size_t n) static rct::key sum_of_even_powers(const rct::key &x, size_t n)
{ {
CHECK_AND_ASSERT_THROW_MES((n & (n - 1)) == 0, "Need n to be a power of 2"); CHECK_AND_ASSERT_THROW_MES((n & (n - 1)) == 0, "Need n to be a power of 2");
CHECK_AND_ASSERT_THROW_MES(n != 0, "Need n > 0");
rct::key x1 = copy(x); rct::key x1 = copy(x);
sc_mul(x1.bytes, x1.bytes, x1.bytes); sc_mul(x1.bytes, x1.bytes, x1.bytes);
@ -264,6 +265,8 @@ namespace rct
// Output x**1 + x**2 + x**3 + ... + x**n // Output x**1 + x**2 + x**3 + ... + x**n
static rct::key sum_of_scalar_powers(const rct::key &x, size_t n) static rct::key sum_of_scalar_powers(const rct::key &x, size_t n)
{ {
CHECK_AND_ASSERT_THROW_MES(n != 0, "Need n > 0");
rct::key res = ONE; rct::key res = ONE;
if (n == 1) if (n == 1)
return res; return res;
@ -764,6 +767,11 @@ try_again:
rct::addKeys2(B, temp2, temp, rct::H); rct::addKeys2(B, temp2, temp, rct::H);
rct::key e = transcript_update(transcript, A1, B); rct::key e = transcript_update(transcript, A1, B);
if (e == rct::zero())
{
MINFO("e is 0, trying again");
goto try_again;
}
rct::key e_squared; rct::key e_squared;
sc_mul(e_squared.bytes, e.bytes, e.bytes); sc_mul(e_squared.bytes, e.bytes, e.bytes);