is_hdd update

This commit is contained in:
p8p 2018-08-25 04:16:01 -07:00
parent 91c7d68b2d
commit 9d6539923e
No known key found for this signature in database
GPG key ID: F7078EC66F3061EE
5 changed files with 61 additions and 53 deletions

View file

@ -1200,8 +1200,12 @@ void BlockchainLMDB::open(const std::string& filename, const int db_flags)
throw DB_ERROR("Database could not be opened"); throw DB_ERROR("Database could not be opened");
} }
if (tools::is_hdd(filename.c_str())) boost::optional<bool> is_hdd_result = tools::is_hdd(filename.c_str());
MCLOG_RED(el::Level::Warning, "global", "The blockchain is on a rotating drive: this will be very slow, use a SSD if possible"); if (is_hdd_result)
{
if (is_hdd_result.value())
MCLOG_RED(el::Level::Warning, "global", "The blockchain is on a rotating drive: this will be very slow, use a SSD if possible");
}
m_folder = filename; m_folder = filename;

View file

@ -46,6 +46,13 @@
#include <string> #include <string>
#endif #endif
//tools::is_hdd
#ifdef __GLIBC__
#include <sstream>
#include <sys/sysmacros.h>
#include <fstream>
#endif
#include "unbound.h" #include "unbound.h"
#include "include_base_utils.h" #include "include_base_utils.h"
@ -733,62 +740,41 @@ std::string get_nix_version_display_string()
#endif #endif
} }
bool is_hdd(const char *path) boost::optional<bool> is_hdd(const char *file_path)
{ {
#ifdef __GLIBC__ #ifdef __GLIBC__
std::string device = ""; struct stat st;
struct stat st, dst; std::string prefix;
if (stat(path, &st) < 0) if(stat(file_path, &st) == 0)
return 0;
DIR *dir = opendir("/dev/block");
if (!dir)
return 0;
struct dirent *de;
while ((de = readdir(dir)))
{ {
if (strcmp(de->d_name, ".") && strcmp(de->d_name, "..")) std::ostringstream s;
s << "/sys/dev/block/" << major(st.st_dev) << ":" << minor(st.st_dev);
prefix = s.str();
}
else
{
return boost::none;
}
std::string attr_path = prefix + "/queue/rotational";
std::ifstream f(attr_path, std::ios_base::in);
if(not f.is_open())
{
attr_path = prefix + "/../queue/rotational";
f.open(attr_path, std::ios_base::in);
if(not f.is_open())
{ {
std::string dev_path = std::string("/dev/block/") + de->d_name; return boost::none;
char resolved[PATH_MAX];
if (realpath(dev_path.c_str(), resolved) && !strncmp(resolved, "/dev/", 5))
{
if (stat(resolved, &dst) == 0)
{
if (dst.st_rdev == st.st_dev)
{
// take out trailing digits (eg, sda1 -> sda)
char *ptr = resolved;
while (*ptr)
++ptr;
while (ptr > resolved && isdigit(*--ptr))
*ptr = 0;
device = resolved + 5;
break;
}
}
}
} }
} }
closedir(dir); unsigned short val = 0xdead;
f >> val;
if (device.empty()) if(not f.fail())
return 0; {
return (val == 1);
std::string sys_path = "/sys/block/" + device + "/queue/rotational"; }
FILE *f = fopen(sys_path.c_str(), "r"); return boost::none;
if (!f)
return false;
char s[8];
char *ptr = fgets(s, sizeof(s), f);
fclose(f);
if (!ptr)
return 0;
s[sizeof(s) - 1] = 0;
int n = atoi(s); // returns 0 on parse error
return n == 1;
#else #else
return 0; return boost::none;
#endif #endif
} }

View file

@ -230,7 +230,7 @@ namespace tools
bool sha256sum(const uint8_t *data, size_t len, crypto::hash &hash); bool sha256sum(const uint8_t *data, size_t len, crypto::hash &hash);
bool sha256sum(const std::string &filename, crypto::hash &hash); bool sha256sum(const std::string &filename, crypto::hash &hash);
bool is_hdd(const char *path); boost::optional<bool> is_hdd(const char *path);
boost::optional<std::pair<uint32_t, uint32_t>> parse_subaddress_lookahead(const std::string& str); boost::optional<std::pair<uint32_t, uint32_t>> parse_subaddress_lookahead(const std::string& str);

View file

@ -76,7 +76,8 @@ set(unit_tests_sources
output_selection.cpp output_selection.cpp
vercmp.cpp vercmp.cpp
ringdb.cpp ringdb.cpp
wipeable_string.cpp) wipeable_string.cpp
is_hdd.cpp)
set(unit_tests_headers set(unit_tests_headers
unit_tests_utils.h) unit_tests_utils.h)

View file

@ -0,0 +1,17 @@
#include "common/util.h"
#include <string>
#include <gtest/gtest.h>
#if defined(__GLIBC__)
TEST(is_hdd, linux_os_root)
{
std::string path = "/";
EXPECT_TRUE(tools::is_hdd(path.c_str()));
}
#else
TEST(is_hdd, unknown_os)
{
std::string path = "";
EXPECT_FALSE(tools::is_hdd(path.c_str()));
}
#endif