rottenwheel/monero
1
0
Fork 0
mirror of https://codeberg.org/anoncontributorxmr/monero.git synced 2024-11-26 01:12:39 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Rename "--block-number" option to "--block-stop"

Browse source 
Update help output for this and other options.
This commit is contained in:
warptangent 2015-05-15 17:14:36 -07:00
parent 2b2dbd887d
commit 73d3511412
No known key found for this signature in database
GPG key ID: 0E490BEBFBE4E92D
3 changed files with 45 additions and 46 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
src/blockchain_utilities/blockchain_export.cpp
View file

@ -38,7 +38,7 @@ using namespace epee; // log_space
int main(int argc, char* argv[]) int main(int argc, char* argv[])
{ {
uint32_t log_level = 0; uint32_t log_level = 0;
uint64_t block_height = 0; uint64_t block_stop = 0;
std::string import_filename = BLOCKCHAIN_RAW; std::string import_filename = BLOCKCHAIN_RAW;
boost::filesystem::path default_data_path {tools::get_default_data_dir()}; boost::filesystem::path default_data_path {tools::get_default_data_dir()};
@ -47,7 +47,7 @@ int main(int argc, char* argv[])
po::options_description desc_cmd_only("Command line options"); po::options_description desc_cmd_only("Command line options");
po::options_description desc_cmd_sett("Command line options and settings options"); po::options_description desc_cmd_sett("Command line options and settings options");
const command_line::arg_descriptor<uint32_t> arg_log_level = {"log-level", "", log_level}; const command_line::arg_descriptor<uint32_t> arg_log_level = {"log-level", "", log_level};
const command_line::arg_descriptor<uint64_t> arg_block_height = {"block-number", "", block_height}; const command_line::arg_descriptor<uint64_t> arg_block_stop = {"block-stop", "Stop at block number", block_stop};
const command_line::arg_descriptor<bool> arg_testnet_on = { const command_line::arg_descriptor<bool> arg_testnet_on = {
"testnet" "testnet"
, "Run on testnet." , "Run on testnet."
@ -57,9 +57,9 @@ int main(int argc, char* argv[])
command_line::add_arg(desc_cmd_sett, command_line::arg_data_dir, default_data_path.string()); command_line::add_arg(desc_cmd_sett, command_line::arg_data_dir, default_data_path.string());
command_line::add_arg(desc_cmd_sett, command_line::arg_testnet_data_dir, default_testnet_data_path.string()); command_line::add_arg(desc_cmd_sett, command_line::arg_testnet_data_dir, default_testnet_data_path.string());
command_line::add_arg(desc_cmd_sett, arg_log_level);
command_line::add_arg(desc_cmd_sett, arg_block_height);
command_line::add_arg(desc_cmd_sett, arg_testnet_on); command_line::add_arg(desc_cmd_sett, arg_testnet_on);
command_line::add_arg(desc_cmd_sett, arg_log_level);
command_line::add_arg(desc_cmd_sett, arg_block_stop);
command_line::add_arg(desc_cmd_only, command_line::arg_help); command_line::add_arg(desc_cmd_only, command_line::arg_help);
@ -84,7 +84,7 @@ int main(int argc, char* argv[])
} }
log_level = command_line::get_arg(vm, arg_log_level); log_level = command_line::get_arg(vm, arg_log_level);
block_height = command_line::get_arg(vm, arg_block_height); block_stop = command_line::get_arg(vm, arg_block_stop);
log_space::get_set_log_detalisation_level(true, log_level); log_space::get_set_log_detalisation_level(true, log_level);
log_space::log_singletone::add_logger(LOGGER_CONSOLE, NULL, NULL); log_space::log_singletone::add_logger(LOGGER_CONSOLE, NULL, NULL);
@ -148,7 +148,7 @@ int main(int argc, char* argv[])
LOG_PRINT_L0("Exporting blockchain raw data..."); LOG_PRINT_L0("Exporting blockchain raw data...");
BootstrapFile bootstrap; BootstrapFile bootstrap;
r = bootstrap.store_blockchain_raw(core_storage, NULL, output_dir, block_height); r = bootstrap.store_blockchain_raw(core_storage, NULL, output_dir, block_stop);
CHECK_AND_ASSERT_MES(r, false, "Failed to export blockchain raw data"); CHECK_AND_ASSERT_MES(r, false, "Failed to export blockchain raw data");
LOG_PRINT_L0("Blockchain raw data exported OK"); LOG_PRINT_L0("Blockchain raw data exported OK");
} }

43
src/blockchain_utilities/blockchain_import.cpp
View file

@ -169,7 +169,7 @@ int pop_blocks(FakeCore& simple_core, int num_blocks)
} }
template <typename FakeCore> template <typename FakeCore>
int import_from_file(FakeCore& simple_core, std::string& import_file_path, uint64_t stop_height=0) int import_from_file(FakeCore& simple_core, std::string& import_file_path, uint64_t block_stop=0)
{ {
#if !defined(BLOCKCHAIN_DB) #if !defined(BLOCKCHAIN_DB)
static_assert(std::is_same<fake_core_memory, FakeCore>::value || std::is_same<fake_core_lmdb, FakeCore>::value, static_assert(std::is_same<fake_core_memory, FakeCore>::value || std::is_same<fake_core_lmdb, FakeCore>::value,
@ -230,15 +230,15 @@ int import_from_file(FakeCore& simple_core, std::string& import_file_path, uint6
// Note that a new blockchain will start with block number 0 (total blocks: 1) // Note that a new blockchain will start with block number 0 (total blocks: 1)
// due to genesis block being added at initialization. // due to genesis block being added at initialization.
if (! stop_height) if (! block_stop)
{ {
stop_height = total_source_blocks - 1; block_stop = total_source_blocks - 1;
} }
// These are what we'll try to use, and they don't have to be a determination // These are what we'll try to use, and they don't have to be a determination
// from source and destination blockchains, but those are the defaults. // from source and destination blockchains, but those are the defaults.
LOG_PRINT_L0("start block: " << start_height << " stop block: " << LOG_PRINT_L0("start block: " << start_height << " stop block: " <<
stop_height); block_stop);
bool use_batch = false; bool use_batch = false;
if (opt_batch) if (opt_batch)
@ -277,7 +277,7 @@ int import_from_file(FakeCore& simple_core, std::string& import_file_path, uint6
{ {
throw std::runtime_error("Error in deserialization of chunk size"); throw std::runtime_error("Error in deserialization of chunk size");
} }
LOG_PRINT_L1("chunk_size: " << chunk_size); LOG_PRINT_L3("chunk_size: " << chunk_size);
if (chunk_size > BUFFER_SIZE) if (chunk_size > BUFFER_SIZE)
{ {
@ -306,10 +306,10 @@ int import_from_file(FakeCore& simple_core, std::string& import_file_path, uint6
h += NUM_BLOCKS_PER_CHUNK; h += NUM_BLOCKS_PER_CHUNK;
continue; continue;
} }
if (h > stop_height) if (h > block_stop)
{ {
std::cout << refresh_string << "block " << h-1 std::cout << refresh_string << "block " << h-1
<< " / " << stop_height << " / " << block_stop
<< std::flush; << std::flush;
std::cout << ENDL << ENDL; std::cout << ENDL << ENDL;
LOG_PRINT_L0("Specified block number reached - stopping. block: " << h-1 << " total blocks: " << h); LOG_PRINT_L0("Specified block number reached - stopping. block: " << h-1 << " total blocks: " << h);
@ -345,7 +345,7 @@ int import_from_file(FakeCore& simple_core, std::string& import_file_path, uint6
if ((h-1) % progress_interval == 0) if ((h-1) % progress_interval == 0)
{ {
std::cout << refresh_string << "block " << h-1 std::cout << refresh_string << "block " << h-1
<< " / " << stop_height << " / " << block_stop
<< std::flush; << std::flush;
} }
@ -531,7 +531,7 @@ int main(int argc, char* argv[])
uint32_t log_level = LOG_LEVEL_0; uint32_t log_level = LOG_LEVEL_0;
uint64_t num_blocks = 0; uint64_t num_blocks = 0;
uint64_t block_height = 0; uint64_t block_stop = 0;
std::string dirname; std::string dirname;
std::string db_arg_str; std::string db_arg_str;
@ -541,9 +541,9 @@ int main(int argc, char* argv[])
po::options_description desc_cmd_only("Command line options"); po::options_description desc_cmd_only("Command line options");
po::options_description desc_cmd_sett("Command line options and settings options"); po::options_description desc_cmd_sett("Command line options and settings options");
const command_line::arg_descriptor<uint32_t> arg_log_level = {"log-level", "", log_level}; const command_line::arg_descriptor<uint32_t> arg_log_level = {"log-level", "", log_level};
const command_line::arg_descriptor<uint64_t> arg_block_height = {"block-number", "stop at block number", block_height}; const command_line::arg_descriptor<uint64_t> arg_block_stop = {"block-stop", "Stop at block number", block_stop};
const command_line::arg_descriptor<uint64_t> arg_batch_size = {"batch-size", "", db_batch_size}; const command_line::arg_descriptor<uint64_t> arg_batch_size = {"batch-size", "", db_batch_size};
const command_line::arg_descriptor<uint64_t> arg_pop_blocks = {"pop-blocks", "", num_blocks}; const command_line::arg_descriptor<uint64_t> arg_pop_blocks = {"pop-blocks", "Remove blocks from end of blockchain", num_blocks};
const command_line::arg_descriptor<bool> arg_testnet_on = { const command_line::arg_descriptor<bool> arg_testnet_on = {
"testnet" "testnet"
, "Run on testnet." , "Run on testnet."
@ -567,14 +567,14 @@ int main(int argc, char* argv[])
command_line::add_arg(desc_cmd_sett, command_line::arg_data_dir, default_data_path.string()); command_line::add_arg(desc_cmd_sett, command_line::arg_data_dir, default_data_path.string());
command_line::add_arg(desc_cmd_sett, command_line::arg_testnet_data_dir, default_testnet_data_path.string()); command_line::add_arg(desc_cmd_sett, command_line::arg_testnet_data_dir, default_testnet_data_path.string());
command_line::add_arg(desc_cmd_sett, arg_log_level);
command_line::add_arg(desc_cmd_sett, arg_block_height);
command_line::add_arg(desc_cmd_sett, arg_batch_size);
command_line::add_arg(desc_cmd_sett, arg_pop_blocks);
command_line::add_arg(desc_cmd_sett, arg_testnet_on); command_line::add_arg(desc_cmd_sett, arg_testnet_on);
command_line::add_arg(desc_cmd_sett, arg_log_level);
command_line::add_arg(desc_cmd_sett, arg_database); command_line::add_arg(desc_cmd_sett, arg_database);
command_line::add_arg(desc_cmd_sett, arg_batch_size);
command_line::add_arg(desc_cmd_sett, arg_block_stop);
command_line::add_arg(desc_cmd_only, arg_count_blocks); command_line::add_arg(desc_cmd_only, arg_count_blocks);
command_line::add_arg(desc_cmd_only, arg_pop_blocks);
command_line::add_arg(desc_cmd_only, command_line::arg_help); command_line::add_arg(desc_cmd_only, command_line::arg_help);
// call add_options() directly for these arguments since // call add_options() directly for these arguments since
@ -602,7 +602,7 @@ int main(int argc, char* argv[])
opt_verify = command_line::get_arg(vm, arg_verify); opt_verify = command_line::get_arg(vm, arg_verify);
opt_batch = command_line::get_arg(vm, arg_batch); opt_batch = command_line::get_arg(vm, arg_batch);
opt_resume = command_line::get_arg(vm, arg_resume); opt_resume = command_line::get_arg(vm, arg_resume);
block_height = command_line::get_arg(vm, arg_block_height); block_stop = command_line::get_arg(vm, arg_block_stop);
db_batch_size = command_line::get_arg(vm, arg_batch_size); db_batch_size = command_line::get_arg(vm, arg_batch_size);
if (command_line::get_arg(vm, command_line::arg_help)) if (command_line::get_arg(vm, command_line::arg_help))
@ -634,11 +634,6 @@ int main(int argc, char* argv[])
db_batch_size = db_batch_size_verify; db_batch_size = db_batch_size_verify;
} }
} }
uint64_t stop_height = 0;
if (! vm["block-number"].defaulted())
{
stop_height = block_height;
}
std::vector<std::string> db_engines {"memory", "lmdb"}; std::vector<std::string> db_engines {"memory", "lmdb"};
@ -712,12 +707,12 @@ int main(int argc, char* argv[])
if (db_engine == "lmdb") if (db_engine == "lmdb")
{ {
fake_core_lmdb simple_core(dirname, opt_testnet, opt_batch, mdb_flags); fake_core_lmdb simple_core(dirname, opt_testnet, opt_batch, mdb_flags);
import_from_file(simple_core, import_file_path, stop_height); import_from_file(simple_core, import_file_path, block_stop);
} }
else if (db_engine == "memory") else if (db_engine == "memory")
{ {
fake_core_memory simple_core(dirname, opt_testnet); fake_core_memory simple_core(dirname, opt_testnet);
import_from_file(simple_core, import_file_path, stop_height); import_from_file(simple_core, import_file_path, block_stop);
} }
else else
{ {
@ -747,7 +742,7 @@ int main(int argc, char* argv[])
exit(0); exit(0);
} }
import_from_file(simple_core, import_file_path, stop_height); import_from_file(simple_core, import_file_path, block_stop);
#endif #endif
} }

28
src/blockchain_utilities/bootstrap_file.cpp
View file

@ -286,9 +286,9 @@ bool BootstrapFile::close()
#if SOURCE_DB == DB_MEMORY #if SOURCE_DB == DB_MEMORY
bool BootstrapFile::store_blockchain_raw(blockchain_storage* _blockchain_storage, tx_memory_pool* _tx_pool, boost::filesystem::path& output_dir, uint64_t requested_block_height) bool BootstrapFile::store_blockchain_raw(blockchain_storage* _blockchain_storage, tx_memory_pool* _tx_pool, boost::filesystem::path& output_dir, uint64_t requested_block_stop)
#else #else
bool BootstrapFile::store_blockchain_raw(Blockchain* _blockchain_storage, tx_memory_pool* _tx_pool, boost::filesystem::path& output_dir, uint64_t requested_block_height) bool BootstrapFile::store_blockchain_raw(Blockchain* _blockchain_storage, tx_memory_pool* _tx_pool, boost::filesystem::path& output_dir, uint64_t requested_block_stop)
#endif #endif
{ {
uint64_t num_blocks_written = 0; uint64_t num_blocks_written = 0;
@ -303,20 +303,24 @@ bool BootstrapFile::store_blockchain_raw(Blockchain* _blockchain_storage, tx_mem
return false; return false;
} }
block b; block b;
uint64_t height_start = m_height; // height_start uses 0-based height, m_height uses 1-based height. so height_start doesn't need to add 1 here, as it's already at the next height
uint64_t height_stop = 0; // block_start, block_stop use 0-based height. m_height uses 1-based height. So to resume export
// from last exported block, block_start doesn't need to add 1 here, as it's already at the next
// height.
uint64_t block_start = m_height;
uint64_t block_stop = 0;
LOG_PRINT_L0("source blockchain height: " << m_blockchain_storage->get_current_blockchain_height()-1); LOG_PRINT_L0("source blockchain height: " << m_blockchain_storage->get_current_blockchain_height()-1);
if ((requested_block_height > 0) && (requested_block_height < m_blockchain_storage->get_current_blockchain_height())) if ((requested_block_stop > 0) && (requested_block_stop < m_blockchain_storage->get_current_blockchain_height()))
{ {
LOG_PRINT_L0("Using requested block height: " << requested_block_height); LOG_PRINT_L0("Using requested block height: " << requested_block_stop);
height_stop = requested_block_height; block_stop = requested_block_stop;
} }
else else
{ {
height_stop = m_blockchain_storage->get_current_blockchain_height() - 1; block_stop = m_blockchain_storage->get_current_blockchain_height() - 1;
LOG_PRINT_L0("Using block height of source blockchain: " << height_stop); LOG_PRINT_L0("Using block height of source blockchain: " << block_stop);
} }
for (m_cur_height = height_start; m_cur_height <= height_stop; ++m_cur_height) for (m_cur_height = block_start; m_cur_height <= block_stop; ++m_cur_height)
{ {
// this method's height refers to 0-based height (genesis block = height 0) // this method's height refers to 0-based height (genesis block = height 0)
crypto::hash hash = m_blockchain_storage->get_block_id_by_height(m_cur_height); crypto::hash hash = m_blockchain_storage->get_block_id_by_height(m_cur_height);
@ -328,7 +332,7 @@ bool BootstrapFile::store_blockchain_raw(Blockchain* _blockchain_storage, tx_mem
} }
if (m_cur_height % progress_interval == 0) { if (m_cur_height % progress_interval == 0) {
std::cout << refresh_string; std::cout << refresh_string;
std::cout << "block " << m_cur_height << "/" << height_stop << std::flush; std::cout << "block " << m_cur_height << "/" << block_stop << std::flush;
} }
} }
// NOTE: use of NUM_BLOCKS_PER_CHUNK is a placeholder in case multi-block chunks are later supported. // NOTE: use of NUM_BLOCKS_PER_CHUNK is a placeholder in case multi-block chunks are later supported.
@ -338,7 +342,7 @@ bool BootstrapFile::store_blockchain_raw(Blockchain* _blockchain_storage, tx_mem
} }
// print message for last block, which may not have been printed yet due to progress_interval // print message for last block, which may not have been printed yet due to progress_interval
std::cout << refresh_string; std::cout << refresh_string;
std::cout << "block " << m_cur_height-1 << "/" << height_stop << ENDL; std::cout << "block " << m_cur_height-1 << "/" << block_stop << ENDL;
LOG_PRINT_L0("Number of blocks exported: " << num_blocks_written); LOG_PRINT_L0("Number of blocks exported: " << num_blocks_written);
if (num_blocks_written > 0) if (num_blocks_written > 0)