rottenwheel/monero
1
0
Fork 0
mirror of https://codeberg.org/anoncontributorxmr/monero.git synced 2024-11-23 16:02:24 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

tx_pool: drop invalid txes from the pool on startup

Browse source 
instead of just failing

This is a workaround for bad tx blobs being inserted in the
pool for unknown reasons
This commit is contained in:
moneromooo-monero 2017-09-20 18:55:16 +01:00
parent 1a73843cec
commit 3b8b4be5cb
No known key found for this signature in database
GPG key ID: 686F07454D6CEFC3
1 changed files with 23 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

26
src/cryptonote_core/tx_pool.cpp
View file

@ -1090,12 +1090,13 @@ namespace cryptonote
m_txs_by_fee_and_receive_time.clear(); m_txs_by_fee_and_receive_time.clear();
m_spent_key_images.clear(); m_spent_key_images.clear();
return m_blockchain.for_all_txpool_txes([this](const crypto::hash &txid, const txpool_tx_meta_t &meta, const cryptonote::blobdata *bd) { std::vector<crypto::hash> remove;
bool r = m_blockchain.for_all_txpool_txes([this, &remove](const crypto::hash &txid, const txpool_tx_meta_t &meta, const cryptonote::blobdata *bd) {
cryptonote::transaction tx; cryptonote::transaction tx;
if (!parse_and_validate_tx_from_blob(*bd, tx)) if (!parse_and_validate_tx_from_blob(*bd, tx))
{ {
MERROR("Failed to parse tx from txpool"); MWARNING("Failed to parse tx from txpool, removing");
return false; remove.push_back(txid);
} }
if (!insert_key_images(tx, meta.kept_by_block)) if (!insert_key_images(tx, meta.kept_by_block))
{ {
@ -1105,6 +1106,25 @@ namespace cryptonote
m_txs_by_fee_and_receive_time.emplace(std::pair<double, time_t>(meta.fee / (double)meta.blob_size, meta.receive_time), txid); m_txs_by_fee_and_receive_time.emplace(std::pair<double, time_t>(meta.fee / (double)meta.blob_size, meta.receive_time), txid);
return true; return true;
}, true); }, true);
if (!r)
return false;
if (!remove.empty())
{
LockedTXN lock(m_blockchain);
for (const auto &txid: remove)
{
try
{
m_blockchain.remove_txpool_tx(txid);
}
catch (const std::exception &e)
{
MWARNING("Failed to remove corrupt transaction: " << txid);
// ignore error
}
}
}
return true;
} }
//--------------------------------------------------------------------------------- //---------------------------------------------------------------------------------