Build errors involving invalid "override" import #2

New issue

Open

opened 2025-05-01 16:04:27 +00:00 by kumi · 1 comment

kumi commented

2025-05-01 16:04:27 +00:00

Contributor

See this build log for reference: https://git.private.coffee/kumi/NQRduckumentation/actions/runs/5#jobstep-3-7

Actually not an issue of this repository itself, but I don't feel like opening separate issues. Some modules import "override" from "typing", which doesn't seem to be a thing (at least in Python 3.11, which is a supported version). See this build log for reference: https://git.private.coffee/kumi/NQRduckumentation/actions/runs/5#jobstep-3-7

jupfi was assigned by kumi

2025-05-01 16:04:36 +00:00

kumi commented

2025-05-02 07:29:01 +00:00

Author

Contributor

~~Alright, that decorator was added in 3.12. So we need to ensure that the docs are actually built with 3.12 or higher.~~

Strike that. Actually, this calls for a decision (and documentation) on supported Python versions. For example, there is an import here that breaks compatibility with <3.12.

from typing import override

~~Alright, that decorator was added in 3.12. So we need to ensure that the docs are actually built with 3.12 or higher.~~ Strike that. Actually, this calls for a decision (and documentation) on supported Python versions. For example, there is an import here that breaks compatibility with <3.12. https://git.private.coffee/nqrduck/quackseq/src/commit/fcb5f56ca860c2673f544e0576209d8622e91cf1/src/quackseq/pulseparameters.py#L9