kumi/yt-dlp
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

[extractor/twitch] Extract chapters for single chapter VODs (#4453)

Browse source 
Closes #4421 
Authored by: mpeter50
This commit is contained in:
mpeter50 2022-07-30 16:11:27 +00:00 committed by GitHub
parent b6cd135ac2
commit 1cdf69c57e
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 43 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

47
yt_dlp/extractor/twitch.py
View file

@ -205,7 +205,13 @@ class TwitchVodIE(TwitchBaseIE):
'uploader_id': 'riotgames', 'uploader_id': 'riotgames',
'view_count': int, 'view_count': int,
'start_time': 310, 'start_time': 310,
'chapters': [], 'chapters': [
{
'start_time': 0,
'end_time': 17208,
'title': 'League of Legends'
}
],
'live_status': 'was_live', 'live_status': 'was_live',
}, },
'params': { 'params': {
@ -322,6 +328,33 @@ class TwitchVodIE(TwitchBaseIE):
'format': 'mhtml', 'format': 'mhtml',
'skip_download': True 'skip_download': True
} }
}, {
'note': 'VOD with single chapter',
'url': 'https://www.twitch.tv/videos/1536751224',
'info_dict': {
'id': 'v1536751224',
'ext': 'mp4',
'title': 'Porter Robinson Star Guardian Stream Tour with LilyPichu',
'duration': 8353,
'uploader': 'Riot Games',
'uploader_id': 'riotgames',
'timestamp': 1658267731,
'upload_date': '20220719',
'chapters': [
{
'start_time': 0,
'end_time': 8353,
'title': 'League of Legends'
}
],
'live_status': 'was_live',
'thumbnail': r're:^https?://.*\.jpg$',
'view_count': int,
},
'params': {
'skip_download': True
},
'expected_warnings': ['Unable to download JSON metadata: HTTP Error 403: Forbidden']
}] }]
def _download_info(self, item_id): def _download_info(self, item_id):
@ -393,8 +426,14 @@ class TwitchVodIE(TwitchBaseIE):
'was_live': True, 'was_live': True,
} }
def _extract_moments(self, info, item_id): def _extract_chapters(self, info, item_id):
for moment in info.get('moments') or []: if not info.get('moments'):
game = traverse_obj(info, ('game', 'displayName'))
if game:
yield {'title': game}
return
for moment in info['moments']:
start_time = int_or_none(moment.get('positionMilliseconds'), 1000) start_time = int_or_none(moment.get('positionMilliseconds'), 1000)
duration = int_or_none(moment.get('durationMilliseconds'), 1000) duration = int_or_none(moment.get('durationMilliseconds'), 1000)
name = str_or_none(moment.get('description')) name = str_or_none(moment.get('description'))
@ -433,7 +472,7 @@ class TwitchVodIE(TwitchBaseIE):
'uploader_id': try_get(info, lambda x: x['owner']['login'], compat_str), 'uploader_id': try_get(info, lambda x: x['owner']['login'], compat_str),
'timestamp': unified_timestamp(info.get('publishedAt')), 'timestamp': unified_timestamp(info.get('publishedAt')),
'view_count': int_or_none(info.get('viewCount')), 'view_count': int_or_none(info.get('viewCount')),
'chapters': list(self._extract_moments(info, item_id)), 'chapters': list(self._extract_chapters(info, item_id)),
'is_live': is_live, 'is_live': is_live,
'was_live': True, 'was_live': True,
} }