kumi/yt-dlp
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

[networking] Strip whitespace around header values (#8802)

Browse source 
Fixes https://github.com/yt-dlp/yt-dlp/issues/8729
Authored by: coletdjnz
This commit is contained in:
coletdjnz 2023-12-20 19:15:38 +13:00 committed by GitHub
parent db8b4edc7d
commit 196eb0fe77
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 6 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
test/test_utils.py
View file

@ -2370,6 +2370,11 @@ Line 1
headers4 = HTTPHeaderDict({'ytdl-test': 'data;'}) headers4 = HTTPHeaderDict({'ytdl-test': 'data;'})
self.assertEqual(set(headers4.items()), {('Ytdl-Test', 'data;')}) self.assertEqual(set(headers4.items()), {('Ytdl-Test', 'data;')})
# common mistake: strip whitespace from values
# https://github.com/yt-dlp/yt-dlp/issues/8729
headers5 = HTTPHeaderDict({'ytdl-test': ' data; '})
self.assertEqual(set(headers5.items()), {('Ytdl-Test', 'data;')})
def test_extract_basic_auth(self): def test_extract_basic_auth(self):
assert extract_basic_auth('http://:foo.bar') == ('http://:foo.bar', None) assert extract_basic_auth('http://:foo.bar') == ('http://:foo.bar', None)
assert extract_basic_auth('http://foo.bar') == ('http://foo.bar', None) assert extract_basic_auth('http://foo.bar') == ('http://foo.bar', None)

2
yt_dlp/utils/networking.py
View file

@ -67,7 +67,7 @@ class HTTPHeaderDict(collections.UserDict, dict):
def __setitem__(self, key, value): def __setitem__(self, key, value):
if isinstance(value, bytes): if isinstance(value, bytes):
value = value.decode('latin-1') value = value.decode('latin-1')
super().__setitem__(key.title(), str(value)) super().__setitem__(key.title(), str(value).strip())
def __getitem__(self, key): def __getitem__(self, key):
return super().__getitem__(key.title()) return super().__getitem__(key.title())