From d0cb2906c6710dd683309016092ff9420869c9af Mon Sep 17 00:00:00 2001 From: Kumi Date: Tue, 2 Jul 2024 08:25:39 +0200 Subject: [PATCH] refactor: standardize constructor signatures for notifiers Updated constructors in BaseNotifier, Matrix, and NotifySend classes to consistently use kwargs for initialization. Simplifies the BaseNotifier class and reduces the need for extra positional arguments in derived classes, leading to clearer and more flexible instantiation. --- src/trackbert/classes/notifier.py | 2 +- src/trackbert/notifiers/matrix.py | 4 ++-- src/trackbert/notifiers/notify_send.py | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/trackbert/classes/notifier.py b/src/trackbert/classes/notifier.py index ca11c67..e224f6b 100644 --- a/src/trackbert/classes/notifier.py +++ b/src/trackbert/classes/notifier.py @@ -1,5 +1,5 @@ class BaseNotifier: - def __init__(self, *args, **kwargs): + def __init__(self, **kwargs): pass def notify(self, title: str, message: str, urgent: bool = False) -> None: diff --git a/src/trackbert/notifiers/matrix.py b/src/trackbert/notifiers/matrix.py index cbd31de..1bc8c26 100644 --- a/src/trackbert/notifiers/matrix.py +++ b/src/trackbert/notifiers/matrix.py @@ -7,8 +7,8 @@ from ..classes.notifier import BaseNotifier class Matrix(BaseNotifier): - def __init__(self, config: Dict[str, Any], *args, **kwargs): - self.config = config + def __init__(self, **kwargs): + self.config = kwargs["config"] def enabled(self) -> bool: return bool(self.config) diff --git a/src/trackbert/notifiers/notify_send.py b/src/trackbert/notifiers/notify_send.py index 26e4dfc..ddba22d 100644 --- a/src/trackbert/notifiers/notify_send.py +++ b/src/trackbert/notifiers/notify_send.py @@ -8,7 +8,7 @@ from pathlib import Path class NotifySend(BaseNotifier): - def __init__(self, *args, **kwargs): + def __init__(self, **kwargs): pass def notify(