kumi/kanblendar
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix(tasks): ensure correct column association on move

Browse source 
Reordered event emission to after updating task data. Added dataset updates for task's parent column to maintain a consistent state. This prevents bugs where tasks could end up in incorrect columns after moving. Adjusts heights for consistent UI.
This commit is contained in:
Kumi 2024-07-31 11:47:25 +02:00
parent 2b5dbada07
commit 5c5473ad7b
Signed by: kumi
GPG key ID: ECBCC9082395383F
1 changed files with 6 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
kanblendar.js
View file

@ -249,12 +249,12 @@ class Kanblendar {
if (dropTarget.classList.contains('kanblendar-time-slot') || dropTarget.classList.contains('kanblendar-non-timed-tasks')) { if (dropTarget.classList.contains('kanblendar-time-slot') || dropTarget.classList.contains('kanblendar-non-timed-tasks')) {
dropTarget.appendChild(task); dropTarget.appendChild(task);
this.emitTaskChangedEvent('move', task);
} }
// Update the task's due time if dropped in a time slot and the current due time is not valid for that slot // Update the task's due time if dropped in a time slot and the current due time is not valid for that slot
if (dropTarget.classList.contains('kanblendar-time-slot')) { if (dropTarget.classList.contains('kanblendar-time-slot')) {
const startTime = dropTarget.dataset.startTime; const startTime = dropTarget.dataset.startTime;
const parentColumn = dropTarget.closest('.kanblendar-column').id;
const slotStartTime = new Date(`${this.config.currentDate}T${startTime}:00`); const slotStartTime = new Date(`${this.config.currentDate}T${startTime}:00`);
const slotEndTime = this.addMinutes(slotStartTime, this.config.interval); const slotEndTime = this.addMinutes(slotStartTime, this.config.interval);
@ -268,14 +268,17 @@ class Kanblendar {
} else { } else {
task.dataset.dueTime = slotStartTime.toISOString(); task.dataset.dueTime = slotStartTime.toISOString();
} }
task.dataset.column = parentColumn.replace('-tasks', '');
} }
// Update the task in the tasks map // Update the task in the tasks map
this.tasks.get(task.id).column = dropTarget.id.replace('-tasks', ''); this.tasks.get(task.id).column = task.dataset.column;
this.tasks.get(task.id).dueTime = task.dataset.dueTime; this.tasks.get(task.id).dueTime = task.dataset.dueTime;
this.adjustTimeSlotHeights(); // Adjust heights after dropping a task this.adjustTimeSlotHeights(); // Adjust heights after dropping a task
this.emitTaskChangedEvent('move', task);
} }
openModal(task = null) { openModal(task = null) {