diff --git a/oidc_provider/lib/endpoints/authorize.py b/oidc_provider/lib/endpoints/authorize.py index 9d6096e..54af338 100644 --- a/oidc_provider/lib/endpoints/authorize.py +++ b/oidc_provider/lib/endpoints/authorize.py @@ -2,6 +2,11 @@ from datetime import timedelta import logging from django.utils import timezone +try: + from urllib import urlencode + from urlparse import urlsplit, parse_qs, urlunsplit +except ImportError: + from urllib.parse import urlsplit, parse_qs, urlunsplit, urlencode from oidc_provider.lib.errors import * from oidc_provider.lib.utils.params import * @@ -72,7 +77,9 @@ class AuthorizeEndpoint(object): try: self.client = Client.objects.get(client_id=self.params.client_id) - if not (self.params.redirect_uri in self.client.redirect_uris): + clean_redirect_uri = urlsplit(self.params.redirect_uri) + clean_redirect_uri = urlunsplit(clean_redirect_uri._replace(query='')) + if not (clean_redirect_uri in self.client.redirect_uris): logger.error('[Authorize] Invalid redirect uri: %s', self.params.redirect_uri) raise RedirectUriError() @@ -88,6 +95,10 @@ class AuthorizeEndpoint(object): raise ClientIdError() def create_response_uri(self): + uri = urlsplit(self.params.redirect_uri) + query_params = parse_qs(uri.query) + query_fragment = parse_qs(uri.fragment) + try: if self.grant_type == 'authorization_code': code = create_code( @@ -97,8 +108,8 @@ class AuthorizeEndpoint(object): code.save() - # Create the response uri. - uri = self.params.redirect_uri + '?code={0}'.format(code.code) + query_params['code'] = code.code + query_params['state'] = self.params.state if self.params.state else '' elif self.grant_type == 'implicit': id_token_dic = create_id_token( @@ -117,18 +128,17 @@ class AuthorizeEndpoint(object): id_token = encode_id_token( id_token_dic, self.client.client_secret) - # Create the response uri. - uri = self.params.redirect_uri + \ - '#token_type={0}&id_token={1}&expires_in={2}'.format( - 'bearer', - id_token, - 60 * 10, - ) + query_fragment['token_type'] = 'bearer' + query_fragment['id_token'] = id_token + query_fragment['expires_in'] = 60 * 10 # Check if response_type is 'id_token token' then # add access_token to the fragment. if self.params.response_type == 'id_token token': - uri += '&access_token={0}'.format(token.access_token) + query_fragment['access_token'] = token.access_token + + query_fragment['state'] = self.params.state if self.params.state else '' + except Exception as error: logger.error('[Authorize] Error when trying to create response uri: %s', error) raise AuthorizeError( @@ -136,10 +146,10 @@ class AuthorizeEndpoint(object): 'server_error', self.grant_type) - # Add state if present. - uri += ('&state={0}'.format(self.params.state) if self.params.state else '') + uri = uri._replace(query=urlencode(query_params, doseq=True)) + uri = uri._replace(fragment=urlencode(query_fragment, doseq=True)) - return uri + return urlunsplit(uri) def set_client_user_consent(self): """ diff --git a/oidc_provider/tests/test_authorize_endpoint.py b/oidc_provider/tests/test_authorize_endpoint.py index a1a6310..3d1ec3e 100644 --- a/oidc_provider/tests/test_authorize_endpoint.py +++ b/oidc_provider/tests/test_authorize_endpoint.py @@ -258,3 +258,26 @@ class AuthorizationCodeFlowTestCase(TestCase): client=self.client) self.assertEqual(is_code_ok, True, msg='Code returned is invalid or missing.') + + def test_response_uri_is_properly_constructed(self): + post_data = { + 'client_id': self.client.client_id, + 'redirect_uri': self.client.default_redirect_uri + "?redirect_state=xyz", + 'response_type': 'code', + 'scope': 'openid email', + 'state': self.state, + 'allow': 'Accept', + } + + request = self.factory.post(reverse('oidc_provider:authorize'), + data=post_data) + # Simulate that the user is logged. + request.user = self.user + + response = AuthorizeView.as_view()(request) + + is_code_ok = is_code_valid(url=response['Location'], + user=self.user, + client=self.client) + self.assertEqual(is_code_ok, True, + msg='Code returned is invalid.') diff --git a/oidc_provider/tests/utils.py b/oidc_provider/tests/utils.py index 713a818..306239a 100644 --- a/oidc_provider/tests/utils.py +++ b/oidc_provider/tests/utils.py @@ -1,4 +1,8 @@ from django.contrib.auth.models import User +try: + from urlparse import parse_qs, urlsplit +except ImportError: + from urllib.parse import parse_qs, urlsplit from oidc_provider.models import * @@ -40,7 +44,9 @@ def is_code_valid(url, user, client): Check if the code inside the url is valid. """ try: - code = (url.split('code='))[1].split('&')[0] + parsed = urlsplit(url) + params = parse_qs(parsed.query) + code = params['code'][0] code = Code.objects.get(code=code) is_code_ok = (code.client == client) and \ (code.user == user)