From 497f2f3a68bfa3ab267bb7bf60bd1ad2c0725159 Mon Sep 17 00:00:00 2001
From: Ignacio Fiorentino <juanifioren@gmail.com>
Date: Tue, 3 May 2016 12:17:22 -0300
Subject: [PATCH] Bump version v0.3.3.

---
 CHANGELOG.md                                             | 5 +++++
 oidc_provider/lib/endpoints/authorize.py                 | 7 +++----
 oidc_provider/templates/oidc_provider/hidden_inputs.html | 6 +++---
 setup.py                                                 | 2 +-
 4 files changed, 12 insertions(+), 8 deletions(-)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index ce72f72..b73fd71 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -4,6 +4,11 @@ All notable changes to this project will be documented in this file.
 
 ### [Unreleased]
 
+### [0.3.3] - 2016-05-03
+
+##### Fixed
+- Important bug with PKCE and form submit in Auth Request.
+
 ### [0.3.2] - 2016-04-26
 
 ##### Added
diff --git a/oidc_provider/lib/endpoints/authorize.py b/oidc_provider/lib/endpoints/authorize.py
index 5a89a9b..09365e7 100644
--- a/oidc_provider/lib/endpoints/authorize.py
+++ b/oidc_provider/lib/endpoints/authorize.py
@@ -54,12 +54,11 @@ class AuthorizeEndpoint(object):
         self.params.response_type = query_dict.get('response_type', '')
         self.params.scope = query_dict.get('scope', '').split()
         self.params.state = query_dict.get('state', '')
+        
         self.params.nonce = query_dict.get('nonce', '')
         self.params.prompt = query_dict.get('prompt', '')
-
-        # PKCE parameters.
-        self.params.code_challenge = query_dict.get('code_challenge')
-        self.params.code_challenge_method = query_dict.get('code_challenge_method')
+        self.params.code_challenge = query_dict.get('code_challenge', '')
+        self.params.code_challenge_method = query_dict.get('code_challenge_method', '')
 
     def validate_params(self):
         # Client validation.
diff --git a/oidc_provider/templates/oidc_provider/hidden_inputs.html b/oidc_provider/templates/oidc_provider/hidden_inputs.html
index 2bff39d..596414e 100644
--- a/oidc_provider/templates/oidc_provider/hidden_inputs.html
+++ b/oidc_provider/templates/oidc_provider/hidden_inputs.html
@@ -3,6 +3,6 @@
 <input name="response_type" type="hidden" value="{{ params.response_type }}" />
 <input name="scope" type="hidden" value="{{ params.scope | join:' ' }}" />
 <input name="state" type="hidden" value="{{ params.state }}" />
-<input name="nonce" type="hidden" value="{{ params.nonce }}" />
-<input name="code_challenge" type="hidden" value="{{ params.code_challenge }}" />
-<input name="code_challenge_method" type="hidden" value="{{ params.code_challenge_method }}" />
+{% if params.nonce %}<input name="nonce" type="hidden" value="{{ params.nonce }}" />{% endif %}
+{% if params.code_challenge %}<input name="code_challenge" type="hidden" value="{{ params.code_challenge }}" />{% endif %}
+{% if params.code_challenge_method %}<input name="code_challenge_method" type="hidden" value="{{ params.code_challenge_method }}" />{% endif %}
diff --git a/setup.py b/setup.py
index 9ccaeff..9a94039 100644
--- a/setup.py
+++ b/setup.py
@@ -7,7 +7,7 @@ os.chdir(os.path.normpath(os.path.join(os.path.abspath(__file__), os.pardir)))
 
 setup(
     name='django-oidc-provider',
-    version='0.3.2',
+    version='0.3.3',
     packages=[
         'oidc_provider', 'oidc_provider/lib', 'oidc_provider/lib/endpoints',
         'oidc_provider/lib/utils', 'oidc_provider/tests', 'oidc_provider/tests/app',