From e1549dd6ffddc2ca4c923fef188ee120ca2dc063 Mon Sep 17 00:00:00 2001
From: Valentin Samir <valentin.samir@crans.org>
Date: Fri, 29 May 2015 16:14:27 +0200
Subject: [PATCH] use a LogoutMixin

---
 cas_server/views.py | 15 ++++++++++-----
 1 file changed, 10 insertions(+), 5 deletions(-)

diff --git a/cas_server/views.py b/cas_server/views.py
index 7758b55..d4fcc26 100644
--- a/cas_server/views.py
+++ b/cas_server/views.py
@@ -31,10 +31,8 @@ from . import utils
 from . import forms
 from . import models
 
-class LogoutView(View):
-    """destroy CAS session (logout) view"""
-    request = None
-    service = None
+class LogoutMixin(object):
+    """destroy CAS session utims"""
     def clean_session_variables(self):
         """Clean sessions variables"""
         try:
@@ -61,6 +59,12 @@ class LogoutView(View):
         finally:
             self.clean_session_variables()
 
+class LogoutView(View, LogoutMixin):
+    """destroy CAS session (logout) view"""
+
+    request = None
+    service = None
+
     def get(self, request, *args, **kwargs):
         """methode called on GET request on this view"""
         self.request = request
@@ -75,7 +79,7 @@ class LogoutView(View):
             messages.add_message(request, messages.SUCCESS, _(u'Successfully logout'))
             return redirect("cas_server:login")
 
-class LoginView(View, LogoutView):
+class LoginView(View, LogoutMixin):
     """credential requestor / acceptor"""
 
     # pylint: disable=too-many-instance-attributes
@@ -123,6 +127,7 @@ class LoginView(View, LogoutView):
         return self.common()
 
     def get(self, request, *args, **kwargs):
+        """methode called on GET request on this view"""
         self.request = request
         self.service = request.GET.get('service')
         self.renew = True if request.GET.get('renew') else False