From 87a877b91cecdf0253e0cebb1391d24f8baa5743 Mon Sep 17 00:00:00 2001
From: Valentin Samir <valentin.samir@crans.org>
Date: Tue, 28 Jun 2016 17:19:48 +0200
Subject: [PATCH] Full coverage auth view

---
 cas_server/tests.py | 32 +++++++++++++++++++++++++++++---
 1 file changed, 29 insertions(+), 3 deletions(-)

diff --git a/cas_server/tests.py b/cas_server/tests.py
index 1ec9ce4..949d480 100644
--- a/cas_server/tests.py
+++ b/cas_server/tests.py
@@ -264,8 +264,8 @@ class LoginTestCase(TestCase):
         """Check we only keep the last 100 Login Ticket for a user"""
         client, params = get_login_page_params()
         current_lt = params["lt"]
-        i_in_test = random.randint(0, 100)
-        i_not_in_test = random.randint(100, 150)
+        i_in_test = random.randint(0, 99)
+        i_not_in_test = random.randint(101, 150)
         for i in range(150):
             if i == i_in_test:
                 self.assertTrue(current_lt in client.session['lt'])
@@ -708,8 +708,12 @@ class LogoutTestCase(TestCase):
 
 
 class AuthTestCase(TestCase):
-
+    """
+        Test for the auth view, used for external services
+        to validate (user, pass, service) tuples.
+    """
     def setUp(self):
+        """preparing test context"""
         settings.CAS_AUTH_CLASS = 'cas_server.auth.TestAuthUser'
         self.service = 'https://www.example.com'
         models.ServicePattern.objects.create(
@@ -718,6 +722,7 @@ class AuthTestCase(TestCase):
         )
 
     def test_auth_view_goodpass(self):
+        """successful request are awsered by yes"""
         settings.CAS_AUTH_SHARED_SECRET = 'test'
         client = Client()
         response = client.post(
@@ -733,6 +738,7 @@ class AuthTestCase(TestCase):
         self.assertEqual(response.content, b'yes\n')
 
     def test_auth_view_badpass(self):
+        """ bag user password => no"""
         settings.CAS_AUTH_SHARED_SECRET = 'test'
         client = Client()
         response = client.post(
@@ -748,6 +754,7 @@ class AuthTestCase(TestCase):
         self.assertEqual(response.content, b'no\n')
 
     def test_auth_view_badservice(self):
+        """bad service => no"""
         settings.CAS_AUTH_SHARED_SECRET = 'test'
         client = Client()
         response = client.post(
@@ -763,6 +770,7 @@ class AuthTestCase(TestCase):
         self.assertEqual(response.content, b'no\n')
 
     def test_auth_view_badsecret(self):
+        """bad api key => no"""
         settings.CAS_AUTH_SHARED_SECRET = 'test'
         client = Client()
         response = client.post(
@@ -778,6 +786,7 @@ class AuthTestCase(TestCase):
         self.assertEqual(response.content, b'no\n')
 
     def test_auth_view_badsettings(self):
+        """api not set => error"""
         settings.CAS_AUTH_SHARED_SECRET = None
         client = Client()
         response = client.post(
@@ -792,6 +801,23 @@ class AuthTestCase(TestCase):
         self.assertEqual(response.status_code, 200)
         self.assertEqual(response.content, b"no\nplease set CAS_AUTH_SHARED_SECRET")
 
+    def test_auth_view_missing_parameter(self):
+        """missing parameter in request => no"""
+        settings.CAS_AUTH_SHARED_SECRET = 'test'
+        client = Client()
+        params = {
+            'username': settings.CAS_TEST_USER,
+            'password': settings.CAS_TEST_PASSWORD,
+            'service': self.service,
+            'secret': 'test'
+        }
+        for key in ['username', 'password', 'service']:
+            send_params = params.copy()
+            del send_params[key]
+            response = client.post('/auth', send_params)
+            self.assertEqual(response.status_code, 200)
+            self.assertEqual(response.content, b'no\n')
+
 
 class ValidateTestCase(TestCase):