rpc: do not return bans if they're effectively spent

The blocked ip list will still hold them till next time
a connection attempt is made with that IP, so the effective
length of the ban may be negative.
This commit is contained in:
moneromooo-monero 2016-03-12 13:44:55 +00:00
parent 474e4c00f0
commit 789e2755f7
No known key found for this signature in database
GPG key ID: 686F07454D6CEFC3

View file

@ -950,14 +950,17 @@ namespace cryptonote
return false; return false;
} }
auto now = time(nullptr);
std::map<uint32_t, time_t> blocked_ips = m_p2p.get_blocked_ips(); std::map<uint32_t, time_t> blocked_ips = m_p2p.get_blocked_ips();
for (std::map<uint32_t, time_t>::const_iterator i = blocked_ips.begin(); i != blocked_ips.end(); ++i) for (std::map<uint32_t, time_t>::const_iterator i = blocked_ips.begin(); i != blocked_ips.end(); ++i)
{ {
if (i->second > now) {
COMMAND_RPC_GETBANS::ban b; COMMAND_RPC_GETBANS::ban b;
b.ip = i->first; b.ip = i->first;
b.seconds = i->second; b.seconds = i->second - now;
res.bans.push_back(b); res.bans.push_back(b);
} }
}
res.status = CORE_RPC_STATUS_OK; res.status = CORE_RPC_STATUS_OK;
return true; return true;