kumi/danicoin
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Fix assert bug in base58 encode

Browse source 
The previous implementation was almost certainly a typo.
full_block_size is the maximum index in the encoded_block_sizes array,
and size is used as an index in this array.  So now 1 <= size <=
full_block_size == 8 instead of 1 <= size <= sizeof(full_block_size) ==
size_of(size_t) == ? (maybe 4 on 32-bit systems!)
This commit is contained in:
Zachary Michaels 2014-07-01 10:55:41 -04:00
parent 26c83c5dea
commit 7259f07a20
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/common/base58.cpp
View file

@ -110,7 +110,7 @@ namespace tools
void encode_block(const char* block, size_t size, char* res) void encode_block(const char* block, size_t size, char* res)
{ {
assert(1 <= size && size <= sizeof(full_block_size)); assert(1 <= size && size <= full_block_size);
uint64_t num = uint_8be_to_64(reinterpret_cast<const uint8_t*>(block), size); uint64_t num = uint_8be_to_64(reinterpret_cast<const uint8_t*>(block), size);
int i = static_cast<int>(encoded_block_sizes[size]) - 1; int i = static_cast<int>(encoded_block_sizes[size]) - 1;