Commit graph

1353 commits

Author SHA1 Message Date
Jakob Nixdorf
dfc788cd29
Backup: Use tasks for restore 2021-02-06 23:30:51 +01:00
Jakob Nixdorf
e6e16999ae
Backup: Use fragment to retain task
Use the same approach as in the AuthenticateActivity to retain the task when pausing the activity
2021-02-06 21:01:26 +01:00
Jakob Nixdorf
1d3f7af099
Refactor backup tasks
Base the backup tasks on UiBasedBackgroundTask
2021-02-06 16:18:16 +01:00
Ullas-Aithal
093bd842f6 Added option to hide issuer label #678 2021-02-06 19:34:01 +05:30
Jakob Nixdorf
7bf6cda6ed
Overwrite shouldDestroyOnScreeenOff in MainActivity 2021-02-05 06:40:05 +01:00
Jakob Nixdorf
edb01d819f
Merge pull request #738 from jsoberg/#635-MoveAuthenticationToBackground
#635 move authentication to a background thread
2021-02-05 06:25:16 +01:00
Joshua Soberg
39b93fe7e8 #635 - Remove task fragment if task has been canceled
This ensures that we aren't resetting password input on configuration changes after our task has been canceled
2021-02-04 20:35:24 -05:00
Joshua Soberg
d814dab8a8 #635 - Reset password input field and refocus if coming back from cancelling authentication 2021-02-04 20:26:20 -05:00
Joshua Soberg
75bc10e1aa #635 - Make sure the AuthenticateActivity isn't destroyed on screen off 2021-02-04 20:17:23 -05:00
Joshua Soberg
f5c6dfc942 Add the ability to override destroyOnScreenOff functionality if desired 2021-02-04 20:16:27 -05:00
Joshua Soberg
ba2f911909 #635 - Make sure that we're unregistering lifecycle observers to avoid memory leaks 2021-02-03 22:03:23 -05:00
Joshua Soberg
38a5ca656c #635 - Use a lifecycle observer to cancel an active task when going to the background if set to do so 2021-02-03 21:51:44 -05:00
Joshua Soberg
97e7f51fe9 #635 - Make sure that we cancel authentication tasks on screen off if enabled in settings
Note that we can't just remove the fragment from the fragment manager when we get a screen off callback, because Android doesn't allow you to remove fragments after onSaveInstanceState()
2021-02-03 21:44:26 -05:00
Joshua Soberg
7ab8eefce7 #635 - Add the ability to cancel a task 2021-02-03 21:38:26 -05:00
Jakob Nixdorf
bc0a6f93b1
Merge pull request #747 from Ullas-Aithal/feature/emptyStateChanges
Added feature to hide progress bar and add an instruction if there are no cards in the list #745 #746
2021-02-03 19:07:22 +01:00
Ullas-Aithal
6d18f43f90 Changed padding size of empty text view from activity_margin_small to activity_margin_large 2021-02-03 23:32:17 +05:30
Jakob Nixdorf
504e0c8e56
Merge pull request #741 from jsoberg/#740-AuthenticationDialogKeyboardSwitch
#740 authentication dialog keyboard switch
2021-02-03 18:50:28 +01:00
Joshua Soberg
bc8bcf834f #635 - Fix bad javadoc comment, and add clarifying javadoc to AuthenticationTask 2021-02-02 13:25:45 -05:00
Ullas-Aithal
856a7adf80 Added feature to hide progress bar and add an instruction if there are no cards in the list #745 #746 2021-02-02 12:48:41 +05:30
Joshua Soberg
3eb0094204 #635 - Reset our callback in onResume instead of onCreate
This ensure that if the user goes home, the callback will be reset when coming back (since onCreate doesn't get called most of the time in this instance).
2021-02-01 22:03:25 -05:00
Joshua Soberg
b52accb2aa #635 - Make the AuthenticationTask a UiBackedBackgroundTask, and make sure that AuthenticateActivity can receive results across configuration changes
Begin storing the task in a retained fragment so that if the task is begun, we will be able to get a callback when the activity is destroyed/recreated.
2021-02-01 21:53:40 -05:00
Joshua Soberg
f4a5f1ec5d #635 - Add a base background task class for running a task that calls back to the UI upon completion 2021-02-01 21:51:59 -05:00
Joshua Soberg
4c8788083a Merge branch 'master' into #635-MoveAuthenticationToBackground 2021-02-01 20:21:31 -05:00
Jakob Nixdorf
e251a3d9c2
Merge branch 'master' of github.com:andOTP/andOTP 2021-02-01 20:31:28 +01:00
Jakob Nixdorf
feeeba7294
Refactor backup activity to better work with background tasks 2021-02-01 20:28:34 +01:00
Jakob Nixdorf
55c67cfb0c
Merge pull request #744 from thgoebel/comment-note
Comment thumbnail request instructions
2021-02-01 17:17:34 +01:00
Thore
c7ba38fe0b Comment thumbnail request instructions
This way the user still sees them when editing their request,
but afterwards they aren't shown in the issue thread.
2021-02-01 14:16:04 +01:00
Vincent Salucci
31255ea293 Updated Bitwarden icon 2021-01-31 20:47:58 -06:00
Joshua Soberg
e8c1247d62 Remove unused import, make some fields final, and simplify an if statement 2021-01-30 11:56:28 -05:00
Joshua Soberg
b75fdd0026 #740 - Clear text when the user chooses a new authentication type
Not clearing was allowing a potentially weird state where you could have alpha characters in a PIN
2021-01-30 11:51:37 -05:00
Joshua Soberg
0a4eadd7fb #740 - Simplify password input setup into a single method
Fix bug where keyboard wasn't being hidden when selecting none/device
2021-01-30 11:43:05 -05:00
Joshua Soberg
6b33b5bc3f #740 - Remove unnecessary setTransformation calls (this is already done one line above from the ConfirmedPasswordTransformationHelper call) 2021-01-30 11:28:46 -05:00
Joshua Soberg
d1edfe1426 #740 - Fix bug I introduced in b0c56b3, and set the input type when auth metod is changed to password 2021-01-30 11:26:00 -05:00
Joshua Soberg
6a7caf4644 #635 - Remove unused field and import 2021-01-29 18:39:41 -05:00
Joshua Soberg
a9fe8e1c19 #635 - Disable the password input layout as well (disables the ability to show/hide the password text while unlocking) 2021-01-29 18:37:25 -05:00
Joshua Soberg
1ab6b21476 #635 - Correct a misleading log tag 2021-01-29 18:32:46 -05:00
Joshua Soberg
be432e7b4f #635 - Show indeterminate unlock progress (in place of the unlock button) while authenticating 2021-01-29 18:32:28 -05:00
Joshua Soberg
44ca3c02c5 Move method to be in expected call order 2021-01-29 18:23:43 -05:00
Jakob Nixdorf
e1ced76b55
Perform backups in the background
Should fix #729, but still needs some usability improvements
2021-01-29 19:42:37 +01:00
Jakob Nixdorf
6a076c9010
Update some dependencies 2021-01-29 07:10:43 +01:00
Jakob Nixdorf
03f7d0b020
Merge pull request #622 from andOTP/Add-backup-log
Add android sync to initial flow
2021-01-29 06:35:42 +01:00
Joshua Soberg
1780d24955 #635 - First pass at launching the background task when authenticating
Began disabling the password input and unlock buttons while the task is running, for some UI feedback. Right now it's just waiting for the task to finish if the activity gets paused while it's running; this isn't great since there's potential there to lock the main thread, but the task is so short-lived that it may not be an issue.
2021-01-27 22:00:32 -05:00
Joshua Soberg
8c8de98763 #635 - Add ASyncTask for confirming/upgrading authentication on a background thread 2021-01-27 21:38:24 -05:00
Joshua Soberg
d408546b55 #635 - Rename some field names for clarity 2021-01-27 21:27:27 -05:00
Joshua Soberg
1686c61b69 #635 - More code cleanup in AuthenticateActivity
Get rid of the need for separate checks for setting layout hints and input type. Add some clarifying comments.
2021-01-27 21:02:19 -05:00
Joshua Soberg
56ad0630b4 #635 - Some general code cleanup in AuthenticateActivity 2021-01-27 20:45:51 -05:00
Jakob Nixdorf
4ea89105eb
Merge pull request #718 from ziegenberg/additional-icons-8
Additional icons - Part 8
2021-01-22 19:43:43 +01:00
Edoardo Tenani
72d0271a04 Remove android:strokeWidth 2021-01-13 13:12:21 +01:00
Edoardo Tenani
db8b29e362 Remove android:fillType 2021-01-13 13:12:21 +01:00
Edoardo Tenani
a9b54547e0 Resize to 200x200dp 2021-01-13 13:12:21 +01:00