Persist new value in ChangeCredentialsTask

Try to avoids problems when the calling activity is killed

app/src/main/java/org/shadowice/flocke/andotp/Activities/SettingsActivity.java

@@ -191,8 +191,7 @@ public class SettingsActivity extends BaseActivity
                 if (fragment.useAndroidSync != null)
                     fragment.useAndroidSync.setEnabled(true);
             }
-        } else if(key.equals(getString(R.string.settings_key_enable_android_backup_service)))
-        {
+        } else if(key.equals(getString(R.string.settings_key_enable_android_backup_service))) {
             Log.d(SettingsActivity.class.getSimpleName(), "onSharedPreferenceChanged called modifying settings_key_enable_android_backup_service service is now: " +
                     (settings.getAndroidBackupServiceEnabled() ? "enabled" : "disabled"));
 

app/src/main/java/org/shadowice/flocke/andotp/Preferences/CredentialsPreference.java

@@ -204,6 +204,7 @@ public class CredentialsPreference extends DialogPreference
             }
         }
 
+        assert passwordInput.getText() != null; // The save button should only be accessible when a password has been entered (and confirmed)
         ChangeCredentialsTask task = new ChangeCredentialsTask(context, encryptionType, oldEncryptionKey, value, passwordInput.getText().toString());
         task.setCallback(this::handleTaskResult);
 

app/src/main/java/org/shadowice/flocke/andotp/Tasks/ChangeCredentialsTask.java

@@ -59,6 +59,10 @@ public class ChangeCredentialsTask extends UiBasedBackgroundTask<ChangeCredentia
                 return new Result(false, null, null);
         }
 
+        // We already persist the new value here so if something happens to the calling preference
+        // everything is already finalized
+        settings.setAuthMethod(newAuthMethod);
+
         return new Result(true, newEncryptionKey, encryptionType);
     }