From 0a6004b15746c8505aaf77043429f12bce09dfb0 Mon Sep 17 00:00:00 2001
From: RichyHBM <gitemail@richyhbm.co.uk>
Date: Tue, 19 Dec 2017 20:32:33 +0000
Subject: [PATCH] Add a background to thumbnails for better visibility in dark
 themes

---
 app/src/main/res/layout/component_card.xml | 4 +++-
 app/src/main/res/values/dimens.xml         | 1 +
 app/src/main/res/values/styles.xml         | 4 ++++
 3 files changed, 8 insertions(+), 1 deletion(-)

diff --git a/app/src/main/res/layout/component_card.xml b/app/src/main/res/layout/component_card.xml
index b760ce18..e69cb1c5 100644
--- a/app/src/main/res/layout/component_card.xml
+++ b/app/src/main/res/layout/component_card.xml
@@ -18,7 +18,9 @@
             android:layout_width="@dimen/card_thumbnail_size"
             android:layout_height="@dimen/card_thumbnail_size"
             android:layout_marginEnd="@dimen/activity_margin"
-            android:src="@mipmap/ic_launcher"/>
+            android:padding="@dimen/thumbnail_padding"
+            android:background="?attr/thumbnailBackground"
+            android:src="@mipmap/ic_launcher" />
 
         <LinearLayout
             android:orientation="vertical"
diff --git a/app/src/main/res/values/dimens.xml b/app/src/main/res/values/dimens.xml
index f1075f83..e6d5525d 100644
--- a/app/src/main/res/values/dimens.xml
+++ b/app/src/main/res/values/dimens.xml
@@ -13,6 +13,7 @@
 
     <!-- The default letter tile text size -->
     <dimen name="tile_letter_font_size">33sp</dimen>
+    <dimen name="thumbnail_padding">2dp</dimen>
 
     <dimen name="drawer_width">200dp</dimen>
     <dimen name="divider_size">1dp</dimen>
diff --git a/app/src/main/res/values/styles.xml b/app/src/main/res/values/styles.xml
index ef00d9c2..5fe89f5b 100644
--- a/app/src/main/res/values/styles.xml
+++ b/app/src/main/res/values/styles.xml
@@ -5,6 +5,7 @@
 
     <attr name="colorGithub" format="reference" />
     <attr name="colorPaypal" format="reference" />
+    <attr name="thumbnailBackground" format="reference" />
 
     <!-- General styles -->
     <style name="AppTheme.AppBarOverlay" parent="ThemeOverlay.AppCompat.Dark.ActionBar" />
@@ -19,6 +20,7 @@
 
         <item name="colorGithub">@color/github_dark</item>
         <item name="colorPaypal">@color/paypal_dark</item>
+        <item name="thumbnailBackground">@android:color/transparent</item>
 
         <item name="cardStyle">@style/CardViewStyle</item>
     </style>
@@ -41,6 +43,7 @@
         <item name="colorAccent">@color/colorAccent</item>
 
         <item name="windowBackground">?android:attr/colorBackground</item>
+        <item name="thumbnailBackground">@android:color/white</item>
 
         <item name="colorGithub">@color/github_light</item>
         <item name="colorPaypal">@color/paypal_light</item>
@@ -60,6 +63,7 @@
         <item name="colorAccent">@color/colorAccent</item>
 
         <item name="windowBackground">@android:color/black</item>
+        <item name="thumbnailBackground">@android:color/white</item>
 
         <item name="colorGithub">@color/github_light</item>
         <item name="colorPaypal">@color/paypal_light</item>