285 lines
12 KiB
XML
285 lines
12 KiB
XML
<?xml version="1.0" encoding="UTF-8"?>
|
|
<issues format="6" by="lint 8.2.0-alpha06" type="baseline" client="gradle" dependencies="false" name="AGP (8.2.0-alpha06)" variant="all" version="8.2.0-alpha06">
|
|
|
|
<issue
|
|
id="StopShip"
|
|
message="`TODO` call found; points to code which must be fixed prior to release"
|
|
errorLine1=" is Err -> TODO()"
|
|
errorLine2=" ~~~~~~">
|
|
<location
|
|
file="src/main/java/app/passwordstore/util/viewmodel/PGPKeyListViewModel.kt"
|
|
line="35"
|
|
column="19"/>
|
|
</issue>
|
|
|
|
<issue
|
|
id="InvalidPackage"
|
|
message="Invalid package reference in org.bouncycastle:bcpkix-jdk15to18; not included in Android: `javax.naming.directory`. Referenced from `org.bouncycastle.cert.dane.fetcher.JndiDANEFetcherFactory`.">
|
|
<location
|
|
file="$GRADLE_USER_HOME/caches/modules-2/files-2.1/org.bouncycastle/bcpkix-jdk15to18/1.73/7673fe0f3510e88232c4bd98d027e9e0a3d0af6d/bcpkix-jdk15to18-1.73.jar"/>
|
|
</issue>
|
|
|
|
<issue
|
|
id="InvalidPackage"
|
|
message="Invalid package reference in org.bouncycastle:bcpkix-jdk15to18; not included in Android: `javax.naming`. Referenced from `org.bouncycastle.cert.dane.fetcher.JndiDANEFetcherFactory.1`.">
|
|
<location
|
|
file="$GRADLE_USER_HOME/caches/modules-2/files-2.1/org.bouncycastle/bcpkix-jdk15to18/1.73/7673fe0f3510e88232c4bd98d027e9e0a3d0af6d/bcpkix-jdk15to18-1.73.jar"/>
|
|
</issue>
|
|
|
|
<issue
|
|
id="RawDispatchersUse"
|
|
message="Use SlackDispatchers."
|
|
errorLine1=" runBlocking(Dispatchers.Main) { suspendCoroutine { cont -> askForPassword(cont, isRetry) } }"
|
|
errorLine2=" ~~~~~~~~~~~~~~~~">
|
|
<location
|
|
file="src/main/java/app/passwordstore/util/git/sshj/SshjSessionFactory.kt"
|
|
line="60"
|
|
column="19"/>
|
|
</issue>
|
|
|
|
<issue
|
|
id="DenyListedApi"
|
|
message="Use Context#getDrawableCompat() instead"
|
|
errorLine1=" ContextCompat.getDrawable(itemView.context, R.drawable.ic_content_copy)"
|
|
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
|
|
<location
|
|
file="src/main/java/app/passwordstore/ui/adapters/FieldItemAdapter.kt"
|
|
line="67"
|
|
column="17"/>
|
|
</issue>
|
|
|
|
<issue
|
|
id="DenyListedApi"
|
|
message="Use Context#getDrawableCompat() instead"
|
|
errorLine1=" ContextCompat.getDrawable(itemView.context, R.drawable.ic_content_copy)"
|
|
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
|
|
<location
|
|
file="src/main/java/app/passwordstore/ui/adapters/FieldItemAdapter.kt"
|
|
line="67"
|
|
column="17"/>
|
|
</issue>
|
|
|
|
<issue
|
|
id="DenyListedApi"
|
|
message="Use the structured concurrent CoroutineScope#launch and Flow#collect APIs instead of reactive Flow#onEach and Flow#launchIn. Suspend calls like Flow#collect can be refactored into standalone suspend funs and mixed in with regular control flow in a suspend context, but calls that invoke CoroutineScope#launch and Flow#collect at the same time hide the suspend context, encouraging the developer to continue working in the reactive domain."
|
|
errorLine1=" model.searchResult"
|
|
errorLine2=" ^">
|
|
<location
|
|
file="src/main/java/app/passwordstore/ui/passwords/PasswordFragment.kt"
|
|
line="182"
|
|
column="5"/>
|
|
</issue>
|
|
|
|
<issue
|
|
id="DenyListedApi"
|
|
message="Use the structured concurrent CoroutineScope#launch and Flow#collect APIs instead of reactive Flow#onEach and Flow#launchIn. Suspend calls like Flow#collect can be refactored into standalone suspend funs and mixed in with regular control flow in a suspend context, but calls that invoke CoroutineScope#launch and Flow#collect at the same time hide the suspend context, encouraging the developer to continue working in the reactive domain."
|
|
errorLine1=" merge("
|
|
errorLine2=" ^">
|
|
<location
|
|
file="src/main/java/app/passwordstore/ui/dialogs/PasswordGeneratorDialogFragment.kt"
|
|
line="58"
|
|
column="5"/>
|
|
</issue>
|
|
|
|
<issue
|
|
id="DenyListedApi"
|
|
message="For a stack use ArrayDeque which is more efficient internally."
|
|
errorLine1=" private val navigationStack = Stack<NavigationStackEntry>()"
|
|
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
|
|
<location
|
|
file="src/main/java/app/passwordstore/util/viewmodel/SearchableRepositoryViewModel.kt"
|
|
line="297"
|
|
column="33"/>
|
|
</issue>
|
|
|
|
<issue
|
|
id="DenyListedApi"
|
|
message="Use the structured concurrent CoroutineScope#launch and Flow#collect APIs instead of reactive Flow#onEach and Flow#launchIn. Suspend calls like Flow#collect can be refactored into standalone suspend funs and mixed in with regular control flow in a suspend context, but calls that invoke CoroutineScope#launch and Flow#collect at the same time hide the suspend context, encouraging the developer to continue working in the reactive domain."
|
|
errorLine1=" model.searchResult"
|
|
errorLine2=" ^">
|
|
<location
|
|
file="src/main/java/app/passwordstore/ui/folderselect/SelectFolderFragment.kt"
|
|
line="62"
|
|
column="5"/>
|
|
</issue>
|
|
|
|
<issue
|
|
id="MissingQuantity"
|
|
message="For locale "it" (Italian) the following quantity should also be defined: `many`"
|
|
errorLine1=" <plurals name="delete_title">"
|
|
errorLine2=" ^">
|
|
<location
|
|
file="src/main/res/values-it/strings.xml"
|
|
line="7"
|
|
column="3"/>
|
|
</issue>
|
|
|
|
<issue
|
|
id="MissingQuantity"
|
|
message="For locale "pt" (Portuguese) the following quantity should also be defined: `many`"
|
|
errorLine1=" <plurals name="delete_title">"
|
|
errorLine2=" ^">
|
|
<location
|
|
file="src/main/res/values-pt-rBR/strings.xml"
|
|
line="7"
|
|
column="3"/>
|
|
</issue>
|
|
|
|
<issue
|
|
id="MissingQuantity"
|
|
message="For locale "it" (Italian) the following quantity should also be defined: `many`"
|
|
errorLine1=" <plurals name="delete_dialog_text">"
|
|
errorLine2=" ^">
|
|
<location
|
|
file="src/main/res/values-it/strings.xml"
|
|
line="21"
|
|
column="3"/>
|
|
</issue>
|
|
|
|
<issue
|
|
id="MissingQuantity"
|
|
message="For locale "pt" (Portuguese) the following quantity should also be defined: `many`"
|
|
errorLine1=" <plurals name="delete_dialog_text">"
|
|
errorLine2=" ^">
|
|
<location
|
|
file="src/main/res/values-pt-rBR/strings.xml"
|
|
line="21"
|
|
column="3"/>
|
|
</issue>
|
|
|
|
<issue
|
|
id="ConvertToWebp"
|
|
message="One or more images in this project can be converted to the WebP format which typically results in smaller file sizes, even for lossless conversion">
|
|
<location
|
|
file="src/debug/res/mipmap-xxxhdpi/ic_launcher.png"/>
|
|
</issue>
|
|
|
|
<issue
|
|
id="ConvertToWebp"
|
|
message="One or more images in this project can be converted to the WebP format which typically results in smaller file sizes, even for lossless conversion">
|
|
<location
|
|
file="src/main/res/mipmap-xxxhdpi/ic_launcher.png"/>
|
|
</issue>
|
|
|
|
<issue
|
|
id="SelectableText"
|
|
message="Consider making the text value selectable by specifying `android:textIsSelectable="true"`"
|
|
errorLine1=" <TextView"
|
|
errorLine2=" ~~~~~~~~">
|
|
<location
|
|
file="src/main/res/layout/activity_oreo_autofill_filter.xml"
|
|
line="27"
|
|
column="4"/>
|
|
</issue>
|
|
|
|
<issue
|
|
id="SelectableText"
|
|
message="Consider making the text value selectable by specifying `android:textIsSelectable="true"`"
|
|
errorLine1=" <TextView"
|
|
errorLine2=" ~~~~~~~~">
|
|
<location
|
|
file="src/main/res/layout/activity_oreo_autofill_publisher_changed.xml"
|
|
line="66"
|
|
column="4"/>
|
|
</issue>
|
|
|
|
<issue
|
|
id="SelectableText"
|
|
message="Consider making the text value selectable by specifying `android:textIsSelectable="true"`"
|
|
errorLine1=" <TextView"
|
|
errorLine2=" ~~~~~~~~">
|
|
<location
|
|
file="src/main/res/layout/activity_oreo_autofill_publisher_changed.xml"
|
|
line="81"
|
|
column="4"/>
|
|
</issue>
|
|
|
|
<issue
|
|
id="SelectableText"
|
|
message="Consider making the text value selectable by specifying `android:textIsSelectable="true"`"
|
|
errorLine1=" <TextView"
|
|
errorLine2=" ~~~~~~~~">
|
|
<location
|
|
file="src/main/res/layout/oreo_autofill_dataset.xml"
|
|
line="37"
|
|
column="6"/>
|
|
</issue>
|
|
|
|
<issue
|
|
id="SelectableText"
|
|
message="Consider making the text value selectable by specifying `android:textIsSelectable="true"`"
|
|
errorLine1=" <TextView"
|
|
errorLine2=" ~~~~~~~~">
|
|
<location
|
|
file="src/main/res/layout/oreo_autofill_dataset.xml"
|
|
line="46"
|
|
column="6"/>
|
|
</issue>
|
|
|
|
<issue
|
|
id="SelectableText"
|
|
message="Consider making the text value selectable by specifying `android:textIsSelectable="true"`"
|
|
errorLine1=" <TextView"
|
|
errorLine2=" ~~~~~~~~">
|
|
<location
|
|
file="src/main/res/layout/oreo_autofill_filter_row.xml"
|
|
line="29"
|
|
column="4"/>
|
|
</issue>
|
|
|
|
<issue
|
|
id="SelectableText"
|
|
message="Consider making the text value selectable by specifying `android:textIsSelectable="true"`"
|
|
errorLine1=" <TextView"
|
|
errorLine2=" ~~~~~~~~">
|
|
<location
|
|
file="src/main/res/layout/oreo_autofill_filter_row.xml"
|
|
line="43"
|
|
column="4"/>
|
|
</issue>
|
|
|
|
<issue
|
|
id="ComposeUnstableCollections"
|
|
message="The Compose Compiler cannot infer the stability of a parameter if a List<GpgIdentifier> is used in it, even if the item type is stable.
You should use Kotlinx Immutable Collections instead: `identifiers: ImmutableList<GpgIdentifier>` or create an `@Immutable` wrapper for this class: `@Immutable data class IdentifiersList(val items: List<GpgIdentifier>)`
See https://slackhq.github.io/compose-lints/rules/#avoid-using-unstable-collections for more information."
|
|
errorLine1=" identifiers: List<GpgIdentifier>,"
|
|
errorLine2=" ~~~~~~~~~~~~~~~~~~~">
|
|
<location
|
|
file="src/main/java/app/passwordstore/ui/pgp/PGPKeyList.kt"
|
|
line="36"
|
|
column="16"/>
|
|
</issue>
|
|
|
|
<issue
|
|
id="UnknownNullness"
|
|
message="Should explicitly declare type here since implicit type does not specify nullness (Lazy<Array<(GitCommand<out (Any or Any?)> or GitCommand<out (Any or Any?)>?)>>)"
|
|
errorLine1=" override val commands by unsafeLazy {"
|
|
errorLine2=" ~~~~~~~~">
|
|
<location
|
|
file="src/main/java/app/passwordstore/util/git/operation/BreakOutOfDetached.kt"
|
|
line="33"
|
|
column="16"/>
|
|
</issue>
|
|
|
|
<issue
|
|
id="UnknownNullness"
|
|
message="Should explicitly declare type here since implicit type does not specify nullness (Array<(GitCommand<out (Any or Any?)> or GitCommand<out (Any or Any?)>?)>)"
|
|
errorLine1=" override val commands ="
|
|
errorLine2=" ~~~~~~~~">
|
|
<location
|
|
file="src/main/java/app/passwordstore/util/git/operation/ResetToRemoteOperation.kt"
|
|
line="14"
|
|
column="16"/>
|
|
</issue>
|
|
|
|
<issue
|
|
id="UnknownNullness"
|
|
message="Should explicitly declare type here since implicit type does not specify nullness (Array<(GitCommand<out (Any or Any?)> or GitCommand<out (Any or Any?)>?)>)"
|
|
errorLine1=" override val commands ="
|
|
errorLine2=" ~~~~~~~~">
|
|
<location
|
|
file="src/main/java/app/passwordstore/util/git/operation/SyncOperation.kt"
|
|
line="14"
|
|
column="16"/>
|
|
</issue>
|
|
|
|
</issues>
|