kumi/Android-Password-Store
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 2
1279 commits 1 branch 0 tags 120 MiB
Commit graph

1023 commits

Author SHA1 Message Date
Harsh Shandilya
f3c9733d69
Dependency updates (#844) 
* build: uprev dependencies, add leakcanary plumber to patch leaks at runtime

Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>

* build: upgrade security-crypto

Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>

* build: fix copypasta fail

Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
 2020-06-11 11:38:10 +02:00
Fabian Henneke
5d6529a4d8
Replace FileUtils with Kotlin stdlib calls (#843) 2020-06-10 14:49:49 +05:30
Diogenes Molinares
0050deb501
Remove Apache Commons dependencies (#840) 
Co-authored-by: Harsh Shandilya <me@msfjarvis.dev>
 2020-06-10 14:05:03 +05:30
Fabian Henneke
2fa03e3fa0
Allow custom public suffixes for Autofill (#841) 
Adds a preference that allows the user to specify domains that are then
treated as additional public suffixes for the purposes of Autofill.
 2020-06-09 13:45:23 +02:00
github-actions[bot]
02b7f5559d
Update Public Suffix List data (#834) 
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
 2020-06-06 10:55:10 +05:30
Harsh Shandilya
448e70704a
AccessibilityAutofill: disable the service above Oreo (#827) 2020-06-05 23:52:02 +05:30
Fabian Henneke
2ab44a4580
Don't show an error if password prompt is cancelled (#833) 2020-06-04 20:01:25 +05:30
Fabian Henneke
4172c70c86
Improve Git password/passphrase dialog behavior (#829) 
* Reset PasswordFinder retry state after authentication

* Memorize password inbetween Git commands
 2020-06-03 10:08:47 +02:00
Fabian Henneke
0c01a5bbf9
Remove a misguided require from GitOperation (#826) 2020-06-02 16:11:08 +05:30
Fabian Henneke
43ae4bbdb7
Address GitOperationActivity regressions (#824) 2020-06-02 15:03:38 +05:30
Simao Gomes Viana
e922b5260f
app: main: res: add bools.xml with LeakCanary debug build config (#821) 
According to https://square.github.io/leakcanary/recipes/#leakcanary-in-release-builds this is necessary. As of now, the latest snapshot build crashes when starting. This is needed to prevent that.
 2020-05-31 22:33:32 +05:30
Harsh Shandilya
5a34f444c2
Completely revamp decrypted password screen (#817) 
* Completely revamp decrypted password screen

Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>

* update changelog

Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>

Co-authored-by: Fabian Henneke <FabianHenneke@users.noreply.github.com>
 2020-05-31 10:12:31 +02:00
Harsh Shandilya
523f2afc53
build: Upgrade all dependencies (#803) 
* build: upgrade all dependencies

We've accumulated a fat backlog here that's gonna need some heavy testing

* build: adjust for WhatTheStack upgrade

This is now automatically initialized

* build: downgrade security-crypto

* build: upgrade to Gradle 6.4

* idea: sync from AS 4.1.x

* build: bump AGP to 4.0.0

* build: disable Jetifier

Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
Co-authored-by: Fabian Henneke <FabianHenneke@users.noreply.github.com>
 2020-05-31 13:12:15 +05:30
Fabian Henneke
81c4960dd6
Fix GitAsyncTask activity handling in error case (#818) 2020-05-30 21:55:14 +02:00
Fabian Henneke
cd0b23e003
Make commitChange honor finishWithResultOnEnd (#815) 
If PasswordRepository.isGitRepo() returns false, commitChange currently
doesn't honor the finishWithResultOnEnd parameter, which causes
Autofill generate flows to hang on a blank AutofillSaveActivity.

This commit lets commitChange mimic what GitAsyncTask does with the
parameter.

Co-authored-by: Harsh Shandilya <msfjarvis@gmail.com>
 2020-05-30 21:08:38 +02:00
Fabian Henneke
2428d4c0de
Switch password authentication over to SSHJ (#811) 
* Switch password authentication over to SSHJ

* Address review comments and refactor further
 2020-05-30 19:39:17 +02:00
Élie Bouttier
72ede314ef
Fix i18n fr (#813) 2020-05-30 22:32:16 +05:30
github-actions[bot]
a8f6669e35
Update Public Suffix List data (#808) 
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
 2020-05-29 10:28:37 +05:30
Harsh Shandilya
e7463ec24c
Remove HOTP/TOTP support (#806) 2020-05-28 22:42:13 +05:30
Harsh Shandilya
ffcbabc2f4
Configure IME options and focus direction (#805) 2020-05-28 16:54:33 +05:30
Fabian Henneke
97911c5877
Use SSHJ for SSH public key authentication (#801) 2020-05-28 09:57:30 +05:30
github-actions[bot]
fea82fed47
Update Public Suffix List data (#804) 
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
 2020-05-28 09:41:00 +05:30
Harsh Shandilya
4084727aad
treewide: update fragments to use LayoutRes constructor (#802) 
Third time's the charm

Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
 2020-05-27 17:53:44 +02:00
Harsh Shandilya
15665244fc
Resolve ViewBinding regressions (#799) 
* PasswordStore: remove broken snippet

Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>

* Cleanup code and remove incorrect onCreateView uses

Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>

* Fixup imports

Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
 2020-05-27 12:54:03 +05:30
github-actions[bot]
aeac72286f
Update Public Suffix List data (#798) 
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
 2020-05-27 10:58:57 +05:30
Harsh Shandilya
6ee19f79e7
Introduce and switch to FragmentViewBindingDelegate (#797) 
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
 2020-05-27 00:14:10 +05:30
Harsh Shandilya
eb936e1f36
Introduce better R8 optimizations (#796) 2020-05-26 21:43:41 +05:30
Fabian Henneke
96ed53206e
Remove "name" from the list of username heuristics (#793) 2020-05-25 17:21:12 +05:30
github-actions[bot]
bf688c28f9
Update Public Suffix List data (#792) 
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
 2020-05-25 08:17:30 +02:00
Harsh Shandilya
0146b5ae94
build: prepare next development revision 
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
 2020-05-24 16:22:07 +05:30
Harsh Shandilya
ffeb4c17d3
build: bump version 
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
 2020-05-24 16:21:05 +05:30
Harsh Shandilya
f1befcf7f3
BaseGitActivity: always enforce absolute URLs (#788) 2020-05-24 16:15:07 +05:30
Harsh Shandilya
d034da8d01
Fix tests for #778 
And this is why you rebase your PRs before merging :^)

Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
 2020-05-23 16:00:03 +05:30
Harsh Shandilya
90750b976d
build: prepare next development revision 
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
 2020-05-23 15:47:45 +05:30
Harsh Shandilya
ffe16e3488
build: bump version 
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
 2020-05-23 15:47:15 +05:30
Fabian Henneke
a6eb4b4e21
Make connection mode a <= 1 toggle group to prevent UI overflow (#778) 2020-05-23 15:27:52 +05:30
github-actions[bot]
3711bb9aa7
Update Public Suffix List data (#785) 
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
 2020-05-23 11:51:08 +05:30
Harsh Shandilya
d103d6d4ba
Add tests for GitServerConfigActivity (#783) 
* Add tests for GitServerConfigActivity

* github: disable animations before running UI tests

Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
 2020-05-17 01:14:09 +05:30
Harsh Shandilya
7c0d99b8b8
treewide: correct misspellings (#781) 
app/src/main/java/com/zeapo/pwdstore/git/CloneOperation.kt:71:31: corrected "occured" to "occurred"
app/src/main/java/com/zeapo/pwdstore/git/PullOperation.kt:45:31: corrected "occured" to "occurred"
app/src/main/java/com/zeapo/pwdstore/git/SyncOperation.kt:60:31: corrected "occured" to "occurred"
app/src/main/java/com/zeapo/pwdstore/git/ResetToRemoteOperation.kt:52:31: corrected "occured" to "occurred"
app/src/main/java/com/zeapo/pwdstore/pwgen/Phonemes.kt:10:22: corrected "DIPTHONG" to "DIPHTHONG"
app/src/main/java/com/zeapo/pwdstore/pwgen/Phonemes.kt:15:31: corrected "DIPTHONG" to "DIPHTHONG"
app/src/main/java/com/zeapo/pwdstore/pwgen/Phonemes.kt:16:31: corrected "DIPTHONG" to "DIPHTHONG"
app/src/main/java/com/zeapo/pwdstore/pwgen/Phonemes.kt:17:31: corrected "DIPTHONG" to "DIPHTHONG"
app/src/main/java/com/zeapo/pwdstore/pwgen/Phonemes.kt:20:35: corrected "DIPTHONG" to "DIPHTHONG"
app/src/main/java/com/zeapo/pwdstore/pwgen/Phonemes.kt:23:31: corrected "DIPTHONG" to "DIPHTHONG"
app/src/main/java/com/zeapo/pwdstore/pwgen/Phonemes.kt:24:31: corrected "DIPTHONG" to "DIPHTHONG"
app/src/main/java/com/zeapo/pwdstore/pwgen/Phonemes.kt:27:35: corrected "DIPTHONG" to "DIPHTHONG"
app/src/main/java/com/zeapo/pwdstore/pwgen/Phonemes.kt:30:31: corrected "DIPTHONG" to "DIPHTHONG"
app/src/main/java/com/zeapo/pwdstore/pwgen/Phonemes.kt:36:35: corrected "DIPTHONG" to "DIPHTHONG"
app/src/main/java/com/zeapo/pwdstore/pwgen/Phonemes.kt:38:31: corrected "DIPTHONG" to "DIPHTHONG"
app/src/main/java/com/zeapo/pwdstore/pwgen/Phonemes.kt:39:31: corrected "DIPTHONG" to "DIPHTHONG"
app/src/main/java/com/zeapo/pwdstore/pwgen/Phonemes.kt:41:35: corrected "DIPTHONG" to "DIPHTHONG"
app/src/main/java/com/zeapo/pwdstore/pwgen/Phonemes.kt:42:35: corrected "DIPTHONG" to "DIPHTHONG"
app/src/main/java/com/zeapo/pwdstore/pwgen/Phonemes.kt:45:35: corrected "DIPTHONG" to "DIPHTHONG"
app/src/main/java/com/zeapo/pwdstore/pwgen/Phonemes.kt:47:35: corrected "DIPTHONG" to "DIPHTHONG"
app/src/main/java/com/zeapo/pwdstore/pwgen/Phonemes.kt:111:54: corrected "Dipthong" to "Diphthong"
app/src/main/java/com/zeapo/pwdstore/pwgen/Phonemes.kt:113:30: corrected "DIPTHONG" to "DIPHTHONG"
app/src/main/java/com/zeapo/pwdstore/pwgen/Phonemes.kt:207:56: corrected "DIPTHONG" to "DIPHTHONG"

Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
 2020-05-14 14:55:32 +02:00
Fabian Henneke
de4ce44531 Add specific error messages to GitServerConfigActivity 2020-05-14 12:00:30 +02:00
Fabian Henneke
f806438f2c Use absolute paths for custom ports, relative for default port 2020-05-14 12:00:30 +02:00
Fabian Henneke
42981cd52b Improve Git/HTTPS URL generation 2020-05-14 12:00:30 +02:00
Fabian Henneke
698499ba6d
treewide: Reformat XML resources again (#774) 2020-05-14 00:22:49 +05:30
Harsh Shandilya
c0332c42ff
treewide: fix copyright template and apply to all files (#773) 
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
 2020-05-13 21:01:41 +05:30
Fabian Henneke
d695d21497
Make APS buildable on F-Droid (#762) 
* Include lib-publicsuffixlist in tree with proper license attribution

* Exclude lib-publicsuffixlist from code style

* Move applicationId to app/build.gradle

* build: add distributionSha256Sum to Gradle

Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>

* Initial workflow configuration for PSL update

Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>

* Initial check-in of PSL data

Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>

Co-authored-by: Harsh Shandilya <me@msfjarvis.dev>
 2020-05-12 11:17:08 +02:00
Harsh Shandilya
b16620b55c
Add setting for fallback username (#772) 
* PasswordEntry: remove useless annotations

Turns out VisibleForTesting only applies for documentation purposes. Boo >:(

Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>

* PasswordEntry: silence locale warning

Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>

* Add setting for fallback username

Fixes #763

Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
 2020-05-11 22:13:03 +02:00
Harsh Shandilya
041cf00510
Treewide codestyle cleanup (#765) 
- Updated gitignore and checked in the IDE's codestyle config
- Removed spotless as the underlying ktlint backend has failed to resolve the super frustrating import order bug[1] in nearly a year
- Reformat the entire codebase based on the previously committed code style configuration.

1: https://github.com/pinterest/ktlint/issues/527
 2020-05-10 19:21:39 +05:30
Harsh Shandilya
94dc92f8d7
Miscellaneous UI tweaking (#771) 
* Remove dangling UI element and relayout authentication modes

* Drop unnecessary actionBarPopupTheme declaration

* Improve ssh keygen UI

* Commonize button styling

* Tweak save button in server config

* Tweak generate button in ssh keygen

* Commonize OutlinedButton style

Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
 2020-05-10 14:25:59 +05:30
Fabian Henneke
9a77f6bbea
Use NoBackgroundTheme for utility activities (#770) 2020-05-09 19:44:24 +02:00
Harsh Shandilya
4c461fb174
Introduce no-auth mode for connections (#768) 
Fixes #758
Fixes #526
 2020-05-08 20:50:04 +05:30
Harsh Shandilya
ed3312b303
PasswordEntry: add user to the potential candidates for username (#766) 2020-05-06 13:59:48 +05:30
Harsh Shandilya
feab56994d
PasswordEntry: add more potential fields for username (#764) 2020-05-06 01:58:05 +05:30
Harsh Shandilya
69e887f3d8
Better handle non-git repositories (#756) 2020-05-03 01:39:16 +05:30
Harsh Shandilya
ced8bcca01
Confirm password move if it will replace an existing one (#757) 
* Confirm password move if it will replace an existing one

Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>

* CHANGELOG: update

Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
 2020-05-01 16:32:58 +05:30
Fabian Henneke
c41100eff9
Use official FastScroll fix and refactor PasswordFragment (#753) 2020-04-29 08:53:27 +02:00
Harsh Shandilya
edc6dcda88
build: update to openpgp-ktx 2.0 (#749) 
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
 2020-04-29 11:01:22 +05:30
Harsh Shandilya
27cc0728d4
build: prepare next release 
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
 2020-04-29 03:15:05 +05:30
Harsh Shandilya
1e67936751
build: bump version 
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
 2020-04-29 03:12:29 +05:30
Fabian Henneke
d1abc09ef7
Fix Autofill icons in dark mode (#748) 2020-04-28 13:30:22 +05:30
Harsh Shandilya
8cada17bcb
Add toggle for debug logging (#745) 2020-04-25 20:34:33 +05:30
Harsh Shandilya
f89d5c282f
Improve UX around settings items (#744) 
Fixes #461
 2020-04-25 16:53:40 +05:30
Maxime Catrice
f7dbac4649
Fix search if external root dir starts with a dot (#743) 
Fixes #740
Co-Authored-By: Fabian Henneke <FabianHenneke@users.noreply.github.com>
 2020-04-25 15:18:19 +05:30
Harsh Shandilya
73695e2493
auth: redo implementation with a cleaner and simpler API surface (#741) 2020-04-24 15:00:33 +05:30
Harsh Shandilya
bee20ac44a
Better detect uninitialized repositories and offer to clone (#738) 
* PasswordRepository: more comprehensive check for valid repository

* PasswordFragment: Give 'repo uninitialized' Snackbar some purpose in life

* GitOperationActivity: finish immediately when an unhandled request code is used

* PasswordFragment: Make uninitialized repo Snackbar indefinite

* spotless

Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
 2020-04-24 02:05:07 +05:30
Harsh Shandilya
b3f6fc20c4
build: prepare next development version 
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
 2020-04-23 12:54:09 +05:30
Harsh Shandilya
9a843b08f3
build: bump version for patch release 
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
 2020-04-23 12:52:24 +05:30
Harsh Shandilya
3d8cea5966
Improve permission handling logic (#732) 
* Improve permission handling logic

Ensure we always ask for storage permissions when required

* Refactor storage permission checks and invert return value

* PasswordStore: improve permission grant flow

* strings: slightly reword permission grant request message

Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>

Co-authored-by: Fabian Henneke <fabian@henneke.me>
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
 2020-04-22 21:57:52 +05:30
Fabian Henneke
00361a58c7
Fix crash when using type independent sort (#734) 2020-04-22 18:13:56 +02:00
Fabian Henneke
9c1cc8690d
Mark Autofill onboarding dialog as seen on dismiss (#731) 2020-04-22 14:44:25 +05:30
Fabian Henneke
c302d6fe58
Never obscure OK button in Autofill onboarding UI (#729) 2020-04-21 21:38:02 +02:00
Harsh Shandilya
0c0649b86d
build: prepare next development version 
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
 2020-04-21 18:39:02 +05:30
Harsh Shandilya
ec0d478b85
build: bump version to 1.7.0 
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
 2020-04-21 18:39:01 +05:30
Harsh Shandilya
3d0850fa1f
build: inline versionCode and versionName at destination 
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
 2020-04-21 18:39:01 +05:30
Harsh Shandilya
e6ea5f6a08
PasswordStore: onboard users to Oreo autofill 
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
 2020-04-21 18:39:00 +05:30
Harsh Shandilya
b0774febb1
Application: only install logging tree in debug features build 
We should be at a stability level now that does not require logging in prod

Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
 2020-04-21 15:55:26 +05:30
Harsh Shandilya
500ab60973
treewide: switch to logging via timberkt 
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
 2020-04-21 15:55:26 +05:30
Harsh Shandilya
72166c6912
treewide: use getSystemService extension everywhere 
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
 2020-04-21 15:55:25 +05:30
Harsh Shandilya
d505151662
treewide: use edit extension and cleanup some deprecation 
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
 2020-04-21 15:55:25 +05:30
Harsh Shandilya
e1921b26e0
Remove unused import 
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
 2020-04-21 15:55:25 +05:30
Harsh Shandilya
77096c1702
BaseGitActivity: don't remove saved password unnecessarily 
if previousUrl is empty it means that this the first time the method is being called, and url
has not been built yet. We let things slide for the first pass so that the actual logic
only kicks in when it needs to.

Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
 2020-04-21 15:36:30 +05:30
Harsh Shandilya
47c2875e93
Fix protocol validation (#726) 
* GitOperation: code cleanup

* WIP: Fix validation

* Fixup SSH validation

* Spotless

* Remove logging of MalformedURLException

Co-authored-by: Fabian Henneke <fabian@henneke.me>
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
 2020-04-20 13:29:10 +05:30
Harsh Shandilya
99aa0d9bb2
Validate hostname protocol before saving (#723) 
* RFC: protocol validation

* Use java.net.URL for saner parsing

* Improve protocol correction; handle ssh://

Co-authored-by: Fabian Henneke <fabian@henneke.me>
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
 2020-04-19 17:13:39 +05:30
Harsh Shandilya
aaeb899fb6
PgpActivity: hide category view when there's no text 
Co-Authored-By: Fabian Henneke <fabian@henneke.me>
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
 2020-04-19 14:11:19 +05:30
Harsh Shandilya
17385892cb
PasswordFragment: Replace fab options with descriptive bottom sheet 
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
 2020-04-19 14:11:19 +05:30
Harsh Shandilya
eb5a30c3a9
PasswordFragment: animate FAB in action mode 
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
 2020-04-19 14:11:18 +05:30
Fabian Henneke
e5d178ea3c
Work around incompatibility between AndroidFastScroll and recyclerview-selection (#721) 
* Work around incompatibility between AndroidFastScroll and recyclerview-selection

* move hacked recyclerview into separate package

Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>

* Make RecyclerViewHelper private static

Co-authored-by: Harsh Shandilya <me@msfjarvis.dev>
 2020-04-19 10:40:49 +02:00
Harsh Shandilya
934c256edd
Resolve lint warnings 
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
 2020-04-18 23:52:16 +05:30
Harsh Shandilya
5d884a8a74
SshKeygenTask: fix build error 
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
 2020-04-18 23:52:15 +05:30
Harsh Shandilya
beaec159e8
Update SSH clear passphrase preference to handle HTTPS (#716) 
* Update SSH clear passphrase preference to handle HTTPS

Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>

* Address review comments

Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>

* Address review comments

Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>

* Explicitly set preference to visible if it can do anything

* Address review comments

Co-authored-by: Fabian Henneke <FabianHenneke@users.noreply.github.com>
Co-authored-by: Fabian Henneke <fabian@henneke.me>
 2020-04-17 20:12:48 +02:00
Harsh Shandilya
0e1dd641d2
AutofillDecryptActivity: Show toast on Main dispatcher (#717) 
Without this the activity will crash rather than display the error

Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
 2020-04-17 23:04:18 +05:30
Harsh Shandilya
b94b52a42d
Refactor Git related activities (#685) 
* Refactor git logic into separate parts

* Extract hardcoded strings

* Add KDoc to updateHostname, remove unused field

* Cleanups

* Fix dialog message

* Wire in repository clone flow

* spotless

* Remove unused method

* Cleanup GitActivity

- Rename to GitOperationActivity.
- Ensure identityBuilder is always closed regardless of what fragment uses it.
- Remove hardcoded "Operation" strings and replace with REQUEST_ARG_OP.
- Apply a transparent theme to GitOperationActivity make the UI less jarring.

* Tweak some stupidly worded dialog messages

As pointed out in #629, these strings are shoddily worded and do not express any clear intent to the
user, leaving them confused and angry.

* GitOperationActivity: wrap Context to ensure right theme is used

* spotless

* undo build.gradle change

* Use correct parent theme, remove now useless wrapping

* GitServerConfigActivity: fix repository clone flow

* temp: disable leakcanary

framework leaks on Samsung are pissing me off

* Make system bars transparent in git activity

* Tweak HTTPS password layout

* Unhardcode wrong passphrase string

* Store SSH passphrase in EncryptedSharedPreferences

Also revamp the dialog to look a bit better

* Implement support for remembering HTTPS password

Fixes #521

* Try to patch HTTPS remote creation logic

* Update security-crypto

* Clear saved passphrase/password on auth failure

* Revert "Update security-crypto"

Broken on R DP2.1

This reverts commit 4b20371dd42c512a3dd3b759859abb6c1ffd2961.

* Revert "temp: disable leakcanary"

This reverts commit 2db7d41bd67b79c6dc8c5b359a7b27100379f45f.

* Update CHANGELOG

* Remove spacer

* Remove useless override

* Wrap git server activity in a ScrollView

* GitOperation: always finish calling activity when dialogs are dismissed

* Wipe saved password/passphrase when hostname changes

* Don't commit prefs updates

* Don't call listFiles excessively

* Finish activity after saving configuration

* Make ConnectionMode and Protocol enum classes

* Change SSH key passphrase key, don't wipe on host change

* Reimplement BaseGitActivity.updateUrl (was updateHostname)

* Use SharedPreferences.edit KTX extension

* Disable inapplicable connection modes depending on scheme

* BaseGitActivity: annotate onDestroy with CallSuper

We'll leak the identityBuilder connection otherwise

* Move input hack for AlertDialog into an extension function

We re-use this in many places

* Fix protocol/mode toggle issue and consistenly name options

* Fix a crash when opening GitServerConfigActivity without a repo

* Fix OpenKeychain callbacks by moving onActivityResult to BaseGitActivity

* Run spotlessApply

Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
Co-authored-by: Fabian Henneke <fabian@henneke.me>
 2020-04-17 18:36:07 +05:30
Harsh Shandilya
4ffd7ed9bf
Enable emulator tests (#708) 
* github: Enable instrumentation testing in PRs

Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>

* Upgrade to Gradle 6.3

Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>

* Remove outdated and broken tests, redo PasswordEntryTest in Kotlin

Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>

* Remove now unused test assets

Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>

* github: Disable debug APK uploads in PR testing

Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>

* Update .github/workflows/pull_request.yml

* Update .github/workflows/pull_request.yml

Switching to Ubuntu fails due to the SDK 29 missing.

Co-authored-by: Fabian Henneke <FabianHenneke@users.noreply.github.com>
 2020-04-17 00:24:13 +05:30
Fabian Henneke
8b4751f825
Improve SSH private key validation (#713) 
* Improve SSH private key validation

* Address review comment
 2020-04-16 18:34:55 +05:30
Diogenes Molinares
f269bc7d28
See file's metadata to validate SSH key (#709) 
* See file's metadata to validate SSH key

* See file's metadata to validate SSH key

* change exception to throw and refactoring

* catch IOException and IllegalArgumentException as equal

* run ./gradlew spotlessApply

* Apply suggestions from code review

* validate BEGIN, END markers and size != 0

* Apply suggestions from code review

* Update app/src/main/java/com/zeapo/pwdstore/UserPreference.kt

* Don't throw on SSH key import failure

* Style nits

* Codestyle and copy nits

Co-authored-by: Fabian Henneke <fabian@henneke.me>
Co-authored-by: Harsh Shandilya <me@msfjarvis.dev>
 2020-04-16 17:21:24 +05:30
Fabian Henneke
e4aa673537
Reduce build warnings (#712) 
* Add annotations to and reformat SearchableRepositoryViewModel.kt

* Address build warnings other than meaningful deprecations

* Deal with warnings in UserPreference.kt
 2020-04-16 12:20:45 +02:00
Fabian Henneke
2a6326ec0e Address review comments 2020-04-15 22:47:41 +05:30
Fabian Henneke
7cd6f1d1cf Add a switch between Fuzzy and StrictDomain mode to Autofill search view 2020-04-15 22:47:41 +05:30
Fabian Henneke
441b4d3b68 Add support for "work/example.org.gpg" folder layout 2020-04-15 22:47:41 +05:30
Fabian Henneke
5a3220527f Respect encrypted username when filling Autofill generated entry 2020-04-15 22:47:41 +05:30
Fabian Henneke
d6db10e089 Match any path component in StrictDomain FilterMode 2020-04-15 22:47:41 +05:30