Commit graph

904 commits

Author SHA1 Message Date
Harsh Shandilya
4657185dc6
styles: re-add alertDialogTheme override (#923)
It seems the MaterialComponents inflater does not work with preferences.

Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-07-07 19:32:36 +02:00
Fabian Henneke
d192ab2d9a
Work around Chrome Autofill issue (#921) 2020-07-07 20:32:57 +05:30
Harsh Shandilya
5d170249cd
Major UI overhaul and the introduction of a new icon (#920)
Co-authored-by: Fabian Henneke <fabian@henneke.me>
2020-07-07 19:18:24 +05:30
github-actions[bot]
035d3feaa4
Update Public Suffix List data (#917)
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
2020-07-04 10:02:13 +05:30
Harsh Shandilya
25b4261574
Migrate to ActivityResultContracts (#910)
* Move git directory selection to ActivityResultContracts

Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>

* global: replace all android.app.Activity references

Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>

* res: resolve ObsoleteSdkInt lint warning

Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>

* layout: silence some overdraw warnings

Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>

* PasswordFragment: address deprecation

Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>

* PasswordStore: start addressing deprecation warnings

Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>

* autofill: silence deprecation warnings for legacy implementation

I don't want to ever touch these files

Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>

* Reset scrollTarget after use

Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>

* Refresh password list after each swipe

Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>

* Convert if to when

Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>

* Migrate UserPreference to ActivityResultContracts

Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>

* Also validate result in git directory selection

Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>

* AutofillSaveActivity: Switch to ActivityResultContracts

Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>

* AutofillDecryptActivity: Switch to ActivityResultContracts

Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>

* AutofillFilterActivity: Switch to ActivityResultContracts

Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>

* Improve deletion flow

- Silently delete empty directory
- Always refresh password list upon completion

Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>

* Uniform naming for activity result handlers

Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>

Co-authored-by: Fabian Henneke <FabianHenneke@users.noreply.github.com>
2020-07-03 09:24:06 +02:00
Fabian Henneke
ca9c951a53
Fill OTP fields with SMS codes (#900)
* Fill OTP fields with SMS codes

* Allow SMS OTP fill also for web origins

* Introduce free and nonFree build variants

* Fix up workflow

* Improve layout and feature detection

* Workflow changes

* Add Changelog entry

* github: update release workflow for nonFree/Free split

Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>

* Switch to lifecycleScope

* github: make snapshot deploy free variant

Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>

Co-authored-by: Harsh Shandilya <me@msfjarvis.dev>
2020-07-02 13:49:32 +02:00
Fabian Henneke
c702d4aa9e
Fix up URIish instances with @ in user name (#913) 2020-07-02 16:51:59 +05:30
Fabian Henneke
1c9f7971ce
Scroll to files and enter folders when created (#909) 2020-07-01 21:48:21 +05:30
Fabian Henneke
c5a93b8b81
Run a treewide reformat (#908)
Co-authored-by: Harsh Shandilya <msfjarvis@gmail.com>
2020-07-01 12:51:05 +02:00
Fabian Henneke
eaaa3eeea8
Improve and refactor Autofill heuristics (#905)
* Add support for `AUTOFILL_HINT_NEW_PASSWORD` and
  `AUTOFILL_HINT_NEW_USERNAME`. This allows apps to trigger a
  `ClassifiedScenario` with only a generate password action and is the
  analogue of the W3C new-password hint for websites.
* Do not consider HTML password fields without hints to be certain
  password fields (they could contain e.g. bank account numbers,
  API secrets,...).
* Reduce OTP field false positives by excluding the term "postal" as well
  as fields that match the "code" heuristic term but have HTML maxLength
  less than 6 or larger than 8.
* Add German heuristic term "einmal" ("one-time") for OTP fields
* Also exclude fields based on their HTML name (e.g. for terms such as
  "search").
* Extract fieldId, hint and htmlName matches into an extension property.
* Reduce warnings and remove unnecessary suppression annotations.
2020-07-01 09:22:41 +02:00
Aditya Wasan
82a9a61254
Use PreferenceKeys file to manage SharedPreferences keys. (#891)
* Use PreferenceKeys file to manage SharedPreferences keys.

Signed-off-by: Aditya Wasan <adityawasan55@gmail.com>

* Use PreferenceKeys in all files

Signed-off-by: Aditya Wasan <adityawasan55@gmail.com>

* Divide PreferenceKeys into multiple regions

Signed-off-by: Aditya Wasan <adityawasan55@gmail.com>

* Fix build error

Signed-off-by: Aditya Wasan <adityawasan55@gmail.com>

* Use PreferenceKeys in more files

Signed-off-by: Aditya Wasan <adityawasan55@gmail.com>

* Reformat code

Signed-off-by: Aditya Wasan <adityawasan55@gmail.com>

* Fix build error

Signed-off-by: Aditya Wasan <adityawasan55@gmail.com>

* Fix merge issues

Signed-off-by: Aditya Wasan <adityawasan55@gmail.com>
2020-07-01 00:00:02 +05:30
Harsh Shandilya
e11ef1ca1d
Revert "Support directly importing secrets" (#904) 2020-06-30 21:28:28 +05:30
Harsh Shandilya
5e74507d5b
Allow importing TOTP configuration through QR codes (#903)
Co-authored-by: Fabian Henneke <fabian@henneke.me>
2020-06-30 19:21:49 +05:30
Harsh Shandilya
57f125a4da
Workaround to prevent crash on first run (#898)
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-06-30 14:37:59 +05:30
Fabian Henneke
8bc662c9c0
Offer TOTP Autofill for OTP fields (#899) 2020-06-29 10:12:19 +02:00
Harsh Shandilya
ac6220eed3
Merge SshKeyGenFragment into its activity (#897)
* Merge SshKeyGenFragment into its activity

Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>

* Drop neutral button discouraged by material specs

Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>

* Address review comments

Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-06-29 12:50:05 +05:30
Harsh Shandilya
063c1a1144
Reintroduce TOTP support (#890)
Co-authored-by: Fabian Henneke <fabian@henneke.me>
2020-06-29 12:08:59 +05:30
Fabian Henneke
535ad1dbb1
Consolidate password list refresh (#887) 2020-06-28 13:29:15 +05:30
Harsh Shandilya
9fc5d337b8
UI fixups (#892) 2020-06-28 01:45:39 +05:30
github-actions[bot]
0a0e517414
Update Public Suffix List data (#888)
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
2020-06-27 07:03:29 +02:00
Fabian Henneke
b60c5fb605
Use remembered credential even if it is empty (#880)
* Use remembered credential even if it is empty

Should fix #875.

* .isNull() --> == null

* Update relnotes

Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>

* Reword relnotes

Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>

* 2019 it is

Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>

Co-authored-by: Harsh Shandilya <me@msfjarvis.dev>
2020-06-26 09:12:39 +02:00
Fabian Henneke
6b5984dfe6
Reset SSH passphrase after SSH key import (#885) 2020-06-26 09:00:19 +02:00
Fabian Henneke
889208b264
Prevent cached passwords from being wiped (#884) 2020-06-26 08:47:47 +02:00
Fabian Henneke
e1f81e8f4b
Use a custom sshj config (#878)
* Use a custom sshj config

* Get random numbers directly from SecureRandom
* Use Timber calls for logging
* Remove all algorithms that are not in the Mozilla Intermediate SSH config

* Address review comments

* Fixup slf4j's custom format string format

Co-authored-by: Harsh Shandilya <msfjarvis@gmail.com>
2020-06-23 15:39:44 +02:00
Fabian Henneke
8a90ba46c6
Add org.gnu.icecat as a trusted multi-origin browser (#871)
I verified the following:

* Store: F-Droid
* Package hash: wi2iuVvK/WYZUzd2g0Qzn9ef3kAisQURZ8U1WSMTkcM=
* Based on: Firefox
* Actively maintained: https://git.savannah.gnu.org/cgit/gnuzilla.git/log/?h=68
* Multi-origin method: WebView
* Save support: no
2020-06-22 11:53:09 +02:00
Harsh Shandilya
a0b6f48b50 PasswordCreationActivity: properly guard rename code
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-06-21 07:17:34 +02:00
Harsh Shandilya
2c6d4548c5
UserPreference: fix my inability to count (#863) 2020-06-20 12:19:55 +05:30
github-actions[bot]
585d59859d
Update Public Suffix List data (#864)
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
2020-06-20 08:03:15 +02:00
Harsh Shandilya
9751cde406
PasswordStore: refresh password list on swipe down in non-git mode (#862)
* PasswordStore: refresh password list on swipe down in non-git mode

Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>

* Address review comments

Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>

Co-authored-by: Fabian Henneke <FabianHenneke@users.noreply.github.com>
2020-06-19 00:07:05 +05:30
Diogenes Molinares
0a4bcc57f5
Avoid destination's file outside repository (#861) 2020-06-18 19:49:31 +05:30
Diogenes Molinares
23b488a8eb
Add support for category renaming (#854)
* rename category

* changed CHANGELOG

* IDE Refactor

* Address review comments

Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>

* change Stack to List and fix bug when empty category name

* create intermediate folders

* little fixes and KDoc added

* Reuse existing move code

* change button Cancel => Skip

* use canonicalPath to confirm destination inside repository

* change error message

* update KDoc

* show different error to user

Co-authored-by: Harsh Shandilya <me@msfjarvis.dev>
Co-authored-by: Harsh Shandilya <msfjarvis@gmail.com>
Co-authored-by: Fabian Henneke <fabian@henneke.me>
Co-authored-by: Fabian Henneke <FabianHenneke@users.noreply.github.com>
2020-06-18 14:07:26 +02:00
Fabian Henneke
33b3f54921
Refactor password generation (#860)
* Refactor password generation

* Update Extensions.kt

* Update app/src/main/java/com/zeapo/pwdstore/pwgen/PasswordGenerator.kt

Co-authored-by: Harsh Shandilya <me@msfjarvis.dev>

* Address review comments

Co-authored-by: Harsh Shandilya <me@msfjarvis.dev>
2020-06-18 12:04:33 +02:00
Fabian Henneke
e25e0035a2
Update state of encrypt username checkbox onCreate (#859) 2020-06-18 10:23:42 +02:00
Harsh Shandilya
8ff37e953f
Improve bulk deletion and password move flow (#855)
Co-authored-by: Fabian Henneke <FabianHenneke@users.noreply.github.com>
2020-06-17 18:35:46 +05:30
Diogenes Molinares
faff735a08
Properly support password renaming (#852)
Co-authored-by: Harsh Shandilya <me@msfjarvis.dev>
2020-06-14 15:01:43 +05:30
Harsh Shandilya
cd72d15b32
UserPreference: delete all shortcuts when repository is deleted (#850) 2020-06-14 13:24:46 +05:30
Harsh Shandilya
5aab4088d1
Misc UI fixups (#851) 2020-06-14 13:10:33 +05:30
Harsh Shandilya
d8231e112a
Break down PGP Activity into focused sections (#776) 2020-06-12 20:28:15 +05:30
Fabian Henneke
5d6529a4d8
Replace FileUtils with Kotlin stdlib calls (#843) 2020-06-10 14:49:49 +05:30
Diogenes Molinares
0050deb501
Remove Apache Commons dependencies (#840)
Co-authored-by: Harsh Shandilya <me@msfjarvis.dev>
2020-06-10 14:05:03 +05:30
Fabian Henneke
2fa03e3fa0
Allow custom public suffixes for Autofill (#841)
Adds a preference that allows the user to specify domains that are then
treated as additional public suffixes for the purposes of Autofill.
2020-06-09 13:45:23 +02:00
github-actions[bot]
02b7f5559d
Update Public Suffix List data (#834)
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
2020-06-06 10:55:10 +05:30
Harsh Shandilya
448e70704a
AccessibilityAutofill: disable the service above Oreo (#827) 2020-06-05 23:52:02 +05:30
Fabian Henneke
2ab44a4580
Don't show an error if password prompt is cancelled (#833) 2020-06-04 20:01:25 +05:30
Fabian Henneke
4172c70c86
Improve Git password/passphrase dialog behavior (#829)
* Reset PasswordFinder retry state after authentication

* Memorize password inbetween Git commands
2020-06-03 10:08:47 +02:00
Fabian Henneke
0c01a5bbf9
Remove a misguided require from GitOperation (#826) 2020-06-02 16:11:08 +05:30
Fabian Henneke
43ae4bbdb7
Address GitOperationActivity regressions (#824) 2020-06-02 15:03:38 +05:30
Simao Gomes Viana
e922b5260f
app: main: res: add bools.xml with LeakCanary debug build config (#821)
According to https://square.github.io/leakcanary/recipes/#leakcanary-in-release-builds this is necessary. As of now, the latest snapshot build crashes when starting. This is needed to prevent that.
2020-05-31 22:33:32 +05:30
Harsh Shandilya
5a34f444c2
Completely revamp decrypted password screen (#817)
* Completely revamp decrypted password screen

Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>

* update changelog

Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>

Co-authored-by: Fabian Henneke <FabianHenneke@users.noreply.github.com>
2020-05-31 10:12:31 +02:00
Harsh Shandilya
523f2afc53
build: Upgrade all dependencies (#803)
* build: upgrade all dependencies

We've accumulated a fat backlog here that's gonna need some heavy testing

* build: adjust for WhatTheStack upgrade

This is now automatically initialized

* build: downgrade security-crypto

* build: upgrade to Gradle 6.4

* idea: sync from AS 4.1.x

* build: bump AGP to 4.0.0

* build: disable Jetifier

Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
Co-authored-by: Fabian Henneke <FabianHenneke@users.noreply.github.com>
2020-05-31 13:12:15 +05:30
Fabian Henneke
81c4960dd6
Fix GitAsyncTask activity handling in error case (#818) 2020-05-30 21:55:14 +02:00
Fabian Henneke
cd0b23e003
Make commitChange honor finishWithResultOnEnd (#815)
If PasswordRepository.isGitRepo() returns false, commitChange currently
doesn't honor the finishWithResultOnEnd parameter, which causes
Autofill generate flows to hang on a blank AutofillSaveActivity.

This commit lets commitChange mimic what GitAsyncTask does with the
parameter.

Co-authored-by: Harsh Shandilya <msfjarvis@gmail.com>
2020-05-30 21:08:38 +02:00
Fabian Henneke
2428d4c0de
Switch password authentication over to SSHJ (#811)
* Switch password authentication over to SSHJ

* Address review comments and refactor further
2020-05-30 19:39:17 +02:00
Élie Bouttier
72ede314ef
Fix i18n fr (#813) 2020-05-30 22:32:16 +05:30
github-actions[bot]
a8f6669e35
Update Public Suffix List data (#808)
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
2020-05-29 10:28:37 +05:30
Harsh Shandilya
e7463ec24c
Remove HOTP/TOTP support (#806) 2020-05-28 22:42:13 +05:30
Harsh Shandilya
ffcbabc2f4
Configure IME options and focus direction (#805) 2020-05-28 16:54:33 +05:30
Fabian Henneke
97911c5877
Use SSHJ for SSH public key authentication (#801) 2020-05-28 09:57:30 +05:30
github-actions[bot]
fea82fed47
Update Public Suffix List data (#804)
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
2020-05-28 09:41:00 +05:30
Harsh Shandilya
4084727aad
treewide: update fragments to use LayoutRes constructor (#802)
Third time's the charm

Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-05-27 17:53:44 +02:00
Harsh Shandilya
15665244fc
Resolve ViewBinding regressions (#799)
* PasswordStore: remove broken snippet

Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>

* Cleanup code and remove incorrect onCreateView uses

Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>

* Fixup imports

Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-05-27 12:54:03 +05:30
github-actions[bot]
aeac72286f
Update Public Suffix List data (#798)
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
2020-05-27 10:58:57 +05:30
Harsh Shandilya
6ee19f79e7
Introduce and switch to FragmentViewBindingDelegate (#797)
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-05-27 00:14:10 +05:30
Harsh Shandilya
eb936e1f36
Introduce better R8 optimizations (#796) 2020-05-26 21:43:41 +05:30
Fabian Henneke
96ed53206e
Remove "name" from the list of username heuristics (#793) 2020-05-25 17:21:12 +05:30
github-actions[bot]
bf688c28f9
Update Public Suffix List data (#792)
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
2020-05-25 08:17:30 +02:00
Harsh Shandilya
f1befcf7f3
BaseGitActivity: always enforce absolute URLs (#788) 2020-05-24 16:15:07 +05:30
Harsh Shandilya
d034da8d01
Fix tests for #778
And this is why you rebase your PRs before merging :^)

Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-05-23 16:00:03 +05:30
Fabian Henneke
a6eb4b4e21
Make connection mode a <= 1 toggle group to prevent UI overflow (#778) 2020-05-23 15:27:52 +05:30
github-actions[bot]
3711bb9aa7
Update Public Suffix List data (#785)
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
2020-05-23 11:51:08 +05:30
Harsh Shandilya
d103d6d4ba
Add tests for GitServerConfigActivity (#783)
* Add tests for GitServerConfigActivity

* github: disable animations before running UI tests

Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-05-17 01:14:09 +05:30
Harsh Shandilya
7c0d99b8b8
treewide: correct misspellings (#781)
app/src/main/java/com/zeapo/pwdstore/git/CloneOperation.kt:71:31: corrected "occured" to "occurred"
app/src/main/java/com/zeapo/pwdstore/git/PullOperation.kt:45:31: corrected "occured" to "occurred"
app/src/main/java/com/zeapo/pwdstore/git/SyncOperation.kt:60:31: corrected "occured" to "occurred"
app/src/main/java/com/zeapo/pwdstore/git/ResetToRemoteOperation.kt:52:31: corrected "occured" to "occurred"
app/src/main/java/com/zeapo/pwdstore/pwgen/Phonemes.kt:10:22: corrected "DIPTHONG" to "DIPHTHONG"
app/src/main/java/com/zeapo/pwdstore/pwgen/Phonemes.kt:15:31: corrected "DIPTHONG" to "DIPHTHONG"
app/src/main/java/com/zeapo/pwdstore/pwgen/Phonemes.kt:16:31: corrected "DIPTHONG" to "DIPHTHONG"
app/src/main/java/com/zeapo/pwdstore/pwgen/Phonemes.kt:17:31: corrected "DIPTHONG" to "DIPHTHONG"
app/src/main/java/com/zeapo/pwdstore/pwgen/Phonemes.kt:20:35: corrected "DIPTHONG" to "DIPHTHONG"
app/src/main/java/com/zeapo/pwdstore/pwgen/Phonemes.kt:23:31: corrected "DIPTHONG" to "DIPHTHONG"
app/src/main/java/com/zeapo/pwdstore/pwgen/Phonemes.kt:24:31: corrected "DIPTHONG" to "DIPHTHONG"
app/src/main/java/com/zeapo/pwdstore/pwgen/Phonemes.kt:27:35: corrected "DIPTHONG" to "DIPHTHONG"
app/src/main/java/com/zeapo/pwdstore/pwgen/Phonemes.kt:30:31: corrected "DIPTHONG" to "DIPHTHONG"
app/src/main/java/com/zeapo/pwdstore/pwgen/Phonemes.kt:36:35: corrected "DIPTHONG" to "DIPHTHONG"
app/src/main/java/com/zeapo/pwdstore/pwgen/Phonemes.kt:38:31: corrected "DIPTHONG" to "DIPHTHONG"
app/src/main/java/com/zeapo/pwdstore/pwgen/Phonemes.kt:39:31: corrected "DIPTHONG" to "DIPHTHONG"
app/src/main/java/com/zeapo/pwdstore/pwgen/Phonemes.kt:41:35: corrected "DIPTHONG" to "DIPHTHONG"
app/src/main/java/com/zeapo/pwdstore/pwgen/Phonemes.kt:42:35: corrected "DIPTHONG" to "DIPHTHONG"
app/src/main/java/com/zeapo/pwdstore/pwgen/Phonemes.kt:45:35: corrected "DIPTHONG" to "DIPHTHONG"
app/src/main/java/com/zeapo/pwdstore/pwgen/Phonemes.kt:47:35: corrected "DIPTHONG" to "DIPHTHONG"
app/src/main/java/com/zeapo/pwdstore/pwgen/Phonemes.kt:111:54: corrected "Dipthong" to "Diphthong"
app/src/main/java/com/zeapo/pwdstore/pwgen/Phonemes.kt:113:30: corrected "DIPTHONG" to "DIPHTHONG"
app/src/main/java/com/zeapo/pwdstore/pwgen/Phonemes.kt:207:56: corrected "DIPTHONG" to "DIPHTHONG"

Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-05-14 14:55:32 +02:00
Fabian Henneke
de4ce44531 Add specific error messages to GitServerConfigActivity 2020-05-14 12:00:30 +02:00
Fabian Henneke
f806438f2c Use absolute paths for custom ports, relative for default port 2020-05-14 12:00:30 +02:00
Fabian Henneke
42981cd52b Improve Git/HTTPS URL generation 2020-05-14 12:00:30 +02:00
Fabian Henneke
698499ba6d
treewide: Reformat XML resources again (#774) 2020-05-14 00:22:49 +05:30
Harsh Shandilya
c0332c42ff
treewide: fix copyright template and apply to all files (#773)
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-05-13 21:01:41 +05:30
Fabian Henneke
d695d21497
Make APS buildable on F-Droid (#762)
* Include lib-publicsuffixlist in tree with proper license attribution

* Exclude lib-publicsuffixlist from code style

* Move applicationId to app/build.gradle

* build: add distributionSha256Sum to Gradle

Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>

* Initial workflow configuration for PSL update

Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>

* Initial check-in of PSL data

Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>

Co-authored-by: Harsh Shandilya <me@msfjarvis.dev>
2020-05-12 11:17:08 +02:00
Harsh Shandilya
b16620b55c
Add setting for fallback username (#772)
* PasswordEntry: remove useless annotations

Turns out VisibleForTesting only applies for documentation purposes. Boo >:(

Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>

* PasswordEntry: silence locale warning

Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>

* Add setting for fallback username

Fixes #763

Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-05-11 22:13:03 +02:00
Harsh Shandilya
041cf00510
Treewide codestyle cleanup (#765)
- Updated gitignore and checked in the IDE's codestyle config
- Removed spotless as the underlying ktlint backend has failed to resolve the super frustrating import order bug[1] in nearly a year
- Reformat the entire codebase based on the previously committed code style configuration.

1: https://github.com/pinterest/ktlint/issues/527
2020-05-10 19:21:39 +05:30
Harsh Shandilya
94dc92f8d7
Miscellaneous UI tweaking (#771)
* Remove dangling UI element and relayout authentication modes

* Drop unnecessary actionBarPopupTheme declaration

* Improve ssh keygen UI

* Commonize button styling

* Tweak save button in server config

* Tweak generate button in ssh keygen

* Commonize OutlinedButton style

Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-05-10 14:25:59 +05:30
Fabian Henneke
9a77f6bbea
Use NoBackgroundTheme for utility activities (#770) 2020-05-09 19:44:24 +02:00
Harsh Shandilya
4c461fb174
Introduce no-auth mode for connections (#768)
Fixes #758
Fixes #526
2020-05-08 20:50:04 +05:30
Harsh Shandilya
ed3312b303
PasswordEntry: add user to the potential candidates for username (#766) 2020-05-06 13:59:48 +05:30
Harsh Shandilya
feab56994d
PasswordEntry: add more potential fields for username (#764) 2020-05-06 01:58:05 +05:30
Harsh Shandilya
69e887f3d8
Better handle non-git repositories (#756) 2020-05-03 01:39:16 +05:30
Harsh Shandilya
ced8bcca01
Confirm password move if it will replace an existing one (#757)
* Confirm password move if it will replace an existing one

Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>

* CHANGELOG: update

Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-05-01 16:32:58 +05:30
Fabian Henneke
c41100eff9
Use official FastScroll fix and refactor PasswordFragment (#753) 2020-04-29 08:53:27 +02:00
Harsh Shandilya
edc6dcda88
build: update to openpgp-ktx 2.0 (#749)
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-04-29 11:01:22 +05:30
Fabian Henneke
d1abc09ef7
Fix Autofill icons in dark mode (#748) 2020-04-28 13:30:22 +05:30
Harsh Shandilya
8cada17bcb
Add toggle for debug logging (#745) 2020-04-25 20:34:33 +05:30
Harsh Shandilya
f89d5c282f
Improve UX around settings items (#744)
Fixes #461
2020-04-25 16:53:40 +05:30
Maxime Catrice
f7dbac4649
Fix search if external root dir starts with a dot (#743)
Fixes #740
Co-Authored-By: Fabian Henneke <FabianHenneke@users.noreply.github.com>
2020-04-25 15:18:19 +05:30
Harsh Shandilya
73695e2493
auth: redo implementation with a cleaner and simpler API surface (#741) 2020-04-24 15:00:33 +05:30
Harsh Shandilya
bee20ac44a
Better detect uninitialized repositories and offer to clone (#738)
* PasswordRepository: more comprehensive check for valid repository

* PasswordFragment: Give 'repo uninitialized' Snackbar some purpose in life

* GitOperationActivity: finish immediately when an unhandled request code is used

* PasswordFragment: Make uninitialized repo Snackbar indefinite

* spotless

Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-04-24 02:05:07 +05:30
Harsh Shandilya
3d8cea5966
Improve permission handling logic (#732)
* Improve permission handling logic

Ensure we always ask for storage permissions when required

* Refactor storage permission checks and invert return value

* PasswordStore: improve permission grant flow

* strings: slightly reword permission grant request message

Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>

Co-authored-by: Fabian Henneke <fabian@henneke.me>
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-04-22 21:57:52 +05:30
Fabian Henneke
00361a58c7
Fix crash when using type independent sort (#734) 2020-04-22 18:13:56 +02:00
Fabian Henneke
9c1cc8690d
Mark Autofill onboarding dialog as seen on dismiss (#731) 2020-04-22 14:44:25 +05:30
Fabian Henneke
c302d6fe58
Never obscure OK button in Autofill onboarding UI (#729) 2020-04-21 21:38:02 +02:00
Harsh Shandilya
e6ea5f6a08
PasswordStore: onboard users to Oreo autofill
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-04-21 18:39:00 +05:30