Commit graph

2623 commits

Author SHA1 Message Date
Fabian Henneke
0a71cc8aa5
Fix Autofill regression caused by empty dataset (#1184) 2020-11-03 22:10:31 +05:30
Fabian Henneke
73648b39d0
Make autofill-parser API explicit and refactor (#1182) 2020-11-03 13:36:17 +05:30
Fabian Henneke
1d13a1fbd6
Improve Autofill UI and enable inline presentations (#1181)
* Improve Autofill UI and enable inline presentations

Improves the Autofill UI in the following ways:

* Add support for Android 11 inline presentations of Autofill datasets.
* Instead of showing the identifier (app name or web origin) of the
current app on top of every Autofill dataset, it is now shown 1) as a
header dataset on Android 9 and 10 as well as 2) at the top of the
search activity on all supported versions of Android. Rationale: The
identifier is only used in trust decisions when choosing an existing
entry to fill and should feature prominently in that view, not
elsewhere.
* Show the actual identifier part of a matched entry's path, which may
differ from the identifier of the matched app/website.
* Slightly tweak the labels of Search/Generate Autofill actions to
indicate that a) this is about entries and b) the user may skip the
generation of a password and supply a custom one as well.

* Suppress lint error

* Address review comments

* Add a fixme about properly handling fill-in datasets

* CHANGELOG: add entry for inline presentation

Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>

* Remove unused parameter

Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>

Co-authored-by: Harsh Shandilya <me@msfjarvis.dev>
2020-11-02 20:25:37 +01:00
Harsh Shandilya
cff8d41c91
build: compile against SDK 30 and resolve deprecations
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-11-01 22:51:02 +05:30
Harsh Shandilya
18b6e93bb5
build: update CL, BC, WTS and AndroidX test
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-11-01 22:50:20 +05:30
Fabian Henneke
03959cca4d
Finish activity when Autofill Generate is cancelled (#1179) 2020-10-31 12:01:18 +01:00
github-actions[bot]
07b8505fe0
autofill-parser: update publicsuffixes file (#1178)
Co-authored-by: GitHub Actions <noreply@github.com>
2020-10-31 10:04:47 +05:30
Harsh Shandilya
f19ca706e6
Update kotlinx.coroutines and WhatTheStack (#1177)
* build: bump coroutines, AndroidX test and WhatTheStack

Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>

* github: run dependency analysis workflow in pull_request_target context

Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>

* Downgrade AndroidX test back

Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-10-27 09:42:32 +05:30
Harsh Shandilya
b8e07ae98c
github: add workflow to track dependency tree changes (#1176)
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-10-26 16:55:13 +01:00
Harsh Shandilya
a0ffebd52e
github: fix issue template frontmatter (#1175)
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-10-24 12:27:18 +02:00
github-actions[bot]
e124dcbd59
autofill-parser: update publicsuffixes file (#1173)
Co-authored-by: GitHub Actions <noreply@github.com>
2020-10-24 11:08:53 +05:30
Harsh Shandilya
f14a0711a2
Merge branch 'release' into develop
* release:
  build: bump version
  CHANGELOG: bump for 1.13.1
  CHANGELOG: add #1170
  Minimal support for MIME secret encoding (#1170)
  Workaround AndroidX lifecycle requirements in OpenKeychain auth (#1168)
  CHANGELOG: add note about F-Droid DDG support
  autofill-parser: add DuckDuckGo's F-Droid signature
  autofill-parser: add support for multiple signatures for a single package
  CHANGELOG: add entry for auto sync rollback
  Revert "Add option to automatically sync repository on app launch (#1137)"

Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-10-23 22:00:10 +05:30
Harsh Shandilya
5cfa1f165f
build: bump version
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-10-23 21:58:26 +05:30
GitHub Actions
d029cd1f47 CHANGELOG: bump for 1.13.1 2020-10-23 16:27:28 +00:00
Harsh Shandilya
ee63b0677a
CHANGELOG: add #1170
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-10-23 21:56:07 +05:30
Joris Minjat
53b9a807a1
Minimal support for MIME secret encoding (#1170)
Co-authored-by: Fabian Henneke <FabianHenneke@users.noreply.github.com>
(cherry picked from commit 38ece10e0d)
2020-10-23 21:51:26 +05:30
Harsh Shandilya
2b25171bf2
Workaround AndroidX lifecycle requirements in OpenKeychain auth (#1168)
* Workaround AndroidX lifecycle requirements in OpenKeychain auth

Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>

* CHANGELOG: add OpenKeychain fix

Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>

Co-authored-by: Fabian Henneke <FabianHenneke@users.noreply.github.com>
(cherry picked from commit 66b31f1432)
2020-10-23 21:51:26 +05:30
Joris Minjat
38ece10e0d
Minimal support for MIME secret encoding (#1170)
Co-authored-by: Fabian Henneke <FabianHenneke@users.noreply.github.com>
2020-10-23 21:43:37 +05:30
Harsh Shandilya
66b31f1432
Workaround AndroidX lifecycle requirements in OpenKeychain auth (#1168)
* Workaround AndroidX lifecycle requirements in OpenKeychain auth

Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>

* CHANGELOG: add OpenKeychain fix

Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>

Co-authored-by: Fabian Henneke <FabianHenneke@users.noreply.github.com>
2020-10-23 15:23:47 +05:30
Harsh Shandilya
4e22df02fa
Update GitHub Actions workflows (#1169)
* github: switch all actions to their latest versions and pin by SHA1 hash

Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>

* github: switch back to peter-evans/create-pull-request for creating pull requests

Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-10-23 11:33:45 +02:00
Harsh Shandilya
57cd2b5aa6
CHANGELOG: add note about F-Droid DDG support
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-10-23 11:00:21 +05:30
Harsh Shandilya
96787311a0
autofill-parser: add DuckDuckGo's F-Droid signature
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-10-23 11:00:21 +05:30
Harsh Shandilya
ffa061a58a
autofill-parser: add support for multiple signatures for a single package
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-10-23 11:00:20 +05:30
Harsh Shandilya
805c7bfcf1
scripts/hash_browser_app: prepare for multiple signatures and set safe bash opts
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-10-23 11:00:20 +05:30
Harsh Shandilya
c513722a30
Rollback automatic synchronization feature (#1165)
* Revert "Add option to automatically sync repository on app launch (#1137)"

Fixes #1163

This reverts commit 92f1aab25d.

Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>

* CHANGELOG: add entry for auto sync rollback

Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-10-23 07:29:42 +02:00
Harsh Shandilya
41fb76d0f2
CHANGELOG: add note about F-Droid DDG support
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
(cherry picked from commit e051fdf174e4ac36647f1639cc8d0a968b440709)
2020-10-23 10:42:15 +05:30
Harsh Shandilya
92678279c2
autofill-parser: add DuckDuckGo's F-Droid signature
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
(cherry picked from commit 8eec5cc6c7dc6d4c50dadf78e6cdc948c19486a5)
2020-10-23 10:42:15 +05:30
Harsh Shandilya
24235fb0bf
autofill-parser: add support for multiple signatures for a single package
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
(cherry picked from commit 0480b759527420be754f0a2720bccf4a46d06304)
2020-10-23 10:42:14 +05:30
Harsh Shandilya
841b3e770d
CHANGELOG: add entry for auto sync rollback
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
(cherry picked from commit 491100be0f7993062b0d2c386b362ec434737d6c)
2020-10-23 10:41:57 +05:30
Harsh Shandilya
e045c6b0f5
Revert "Add option to automatically sync repository on app launch (#1137)"
Fixes #1163

This reverts commit 92f1aab25d.

Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
(cherry picked from commit 4905396c673dcfdf076c530a1cbb5be800e0920f)
2020-10-23 10:41:32 +05:30
Harsh Shandilya
4a9151870d
Remove accessibility autofill support (#1162)
* autofill: remove Accessibility backend

Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>

* CHANGELOG: update

Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-10-22 23:38:47 +05:30
Harsh Shandilya
260145ce16
build: prepare next development version
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-10-22 17:36:45 +05:30
Harsh Shandilya
9c5d96389c
build: bump version
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-10-22 17:29:48 +05:30
Harsh Shandilya
440caab622
GitServerConfigActivity: add quick-fix for HTTPS URLs with custom ports
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-10-21 06:21:19 +05:30
Harsh Shandilya
f2d0c18672
GitServerConfigActivity: set auth mode visibility on launch as well
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-10-21 06:21:19 +05:30
Harsh Shandilya
30c8c27770
Convert PasswordRepository to an object
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-10-19 00:11:28 +05:30
Harsh Shandilya
95d53e495c
PasswordRepository: split out PasswordSortOrder
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-10-19 00:11:28 +05:30
Harsh Shandilya
12fe561be7
PasswordStore: Remove unnecessary class-level variables
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-10-19 00:11:28 +05:30
Harsh Shandilya
543cf5675a
Rollback string changes from #1157
These should never have been made

Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-10-18 04:02:45 +05:30
ashoksinghal
3981638e0f
Use BottomSheet in place of Snackbar for longer messages (#1157) 2020-10-17 22:09:34 +05:30
Harsh Shandilya
6c1e41ba10
Revamp build configuration (#1156)
* release: move scripts to scripts directory

Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>

* Move CI secrets to secrets directory

Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>

* gradle: uprev to 6.7

Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>

* gradle: suppress warnings about unsupported options

Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>

* build: update dependencies

Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>

* build: move Gradle plugins to ext

Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>

* build: move configuration tasks to buildSrc

Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>

* CHANGELOG: add entry for #1137

Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>

* Fix lint warnings

Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-10-16 17:18:11 +02:00
Aditya Wasan
92f1aab25d
Add option to automatically sync repository on app launch (#1137)
* Add option to automatically sync repository on app launch

Signed-off-by: Aditya Wasan <adityawasan55@gmail.com>

* Pull repo if user is not authenticated

Signed-off-by: Aditya Wasan <adityawasan55@gmail.com>

* Address review comments

Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>

* Hijack incoming intent rather than copying it

Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>

* Initialize password repository before using it

Signed-off-by: Aditya Wasan <adityawasan55@gmail.com>

Co-authored-by: Harsh Shandilya <me@msfjarvis.dev>
2020-10-15 20:46:39 +05:30
Harsh Shandilya
a025ecf073
Merge branch 'release' into develop
* release:
  build: bump version
  CHANGELOG: add entries for #1142 and #1131
  Temporarily work around SSHJ compatibility issues (#1142)
  all: refactor ActivityResultContracts usages to adhere to API requirements

Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-10-13 12:59:07 +05:30
Harsh Shandilya
38fc3c743b
build: bump version
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-10-13 12:54:26 +05:30
Harsh Shandilya
544ca59f4d
github: fix release draft workflow (#1152)
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-10-13 12:48:02 +05:30
Harsh Shandilya
4fbdc0e723
CHANGELOG: add entries for #1142 and #1131
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-10-13 12:14:20 +05:30
Fabian Henneke
6139693d4f
Temporarily work around SSHJ compatibility issues (#1142)
Using ECDSA either as a key exchange or a host key algorithm fails with
SSHJ 0.30.0 on Android, but should again become possible in 0.31.0.

While we wait for the release, demote ECDSA in the list of key
algorithms (as it should still be available for public key auth) and
remove it from the list of key exchange algorithms.

(cherry picked from commit 0d2788ab54)
2020-10-13 12:05:54 +05:30
Harsh Shandilya
c70c1792f6
all: refactor ActivityResultContracts usages to adhere to API requirements
The newest versions of AndroidX Activity and Fragments correctly enforce the
requirement for all contracts to be registered at class init or before
the lifecycle has reached `Lifecycle.State.STARTED`. To comply with these requirements,
move all instances of `registerForActivityResult` being called at arbitrary points
in the code to be done at class init.

Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
(cherry picked from commit cf03c55478)
2020-10-13 12:03:49 +05:30
Harsh Shandilya
591bb4e795
ProxyUtils: correctly handle the 'no proxy' case (#1148)
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-10-11 19:16:48 +05:30
Harsh Shandilya
facc4d9163
github: update release draft workflow
Switch to $GITHUB_ENV since set-env has been deprecated

Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-10-10 12:29:13 +05:30