From ff58afde28df16d8c39f1d6c43594297fb8bc57e Mon Sep 17 00:00:00 2001 From: Harsh Shandilya Date: Wed, 1 Mar 2023 17:17:09 +0530 Subject: [PATCH] refactor(app): centralize lint configuration --- app/build.gradle.kts | 11 ----------- app/lint.xml | 17 +++++++++++++++++ gradle/libs.versions.toml | 4 ---- 3 files changed, 17 insertions(+), 15 deletions(-) diff --git a/app/build.gradle.kts b/app/build.gradle.kts index c4d1cff5..bbe15182 100644 --- a/app/build.gradle.kts +++ b/app/build.gradle.kts @@ -37,17 +37,6 @@ android { } namespace = "app.passwordstore" - - lint { - abortOnError = true - checkReleaseBuilds = false - warningsAsErrors = true - disable.add("MissingTranslation") - disable.add("PluralsCandidate") - disable.add("ImpliedQuantity") - disable.add("DialogFragmentCallbacksDetector") - baseline = file("lint-baseline.xml") - } } dependencies { diff --git a/app/lint.xml b/app/lint.xml index 4f3fbe6c..af4a7b2c 100644 --- a/app/lint.xml +++ b/app/lint.xml @@ -26,5 +26,22 @@ + + + + + + + + + + + + + + + + + diff --git a/gradle/libs.versions.toml b/gradle/libs.versions.toml index 67ae1799..48c6af6e 100644 --- a/gradle/libs.versions.toml +++ b/gradle/libs.versions.toml @@ -1,7 +1,5 @@ [versions] agp = "7.4.2" -# 1.8.x is being built against current DP releases -# noinspection GradleDependency androidxActivity = "1.7.0-beta02" bouncycastle = "1.72" # @keep used for kotlinCompilerExtensionVersion @@ -14,8 +12,6 @@ leakcanary = "2.10" lifecycle = "2.6.0-rc01" [libraries] -# 2.x releases for desugar_jdk_libs are weird and broken -# noinspection GradleDependency android-desugarJdkLibs = "com.android.tools:desugar_jdk_libs:1.2.2" androidx-activity-compose = { module = "androidx.activity:activity-compose", version.ref = "androidxActivity" } androidx-activity-ktx = { module = "androidx.activity:activity-ktx", version.ref = "androidxActivity" }