github: add missing escapes and quotes (#1736)

.github/workflows/deploy_github_releases.yml

@@ -51,7 +51,7 @@ jobs:
         path: app/build/outputs/apk/free/release/app-free-release.apk
 
     - name: Clean secrets
-      if: always()
+      if: "${{ always() }}"
       run: scripts/signing-cleanup.sh
 
   create_github_release:

.github/workflows/pull_request.yml

@@ -25,7 +25,7 @@ jobs:
           return await script({github, context})
 
     - name: Set up JDK
-      if: ${{ steps.service-changed.outputs.result == 'true' }}
+      if: "${{ steps.service-changed.outputs.result == 'true' }}"
       uses: actions/setup-java@v2.5.0
       with:
         distribution: zulu
@@ -33,11 +33,11 @@ jobs:
         cache: gradle
 
     - name: Copy CI gradle.properties
-      if: ${{ steps.service-changed.outputs.result == 'true' }}
+      if: "${{ steps.service-changed.outputs.result == 'true' }}"
       run: mkdir -p ~/.gradle ; cp .github/ci-gradle.properties ~/.gradle/gradle.properties
 
     - name: Check codestyle
-      if: ${{ steps.service-changed.outputs.result == 'true' }}
+      if: "${{ steps.service-changed.outputs.result == 'true' }}"
       uses: gradle/gradle-build-action@v2.1.3
       with:
         arguments: --no-configuration-cache spotlessCheck
@@ -60,7 +60,7 @@ jobs:
           return await script({github, context})
 
     - name: Set up JDK
-      if: ${{ steps.service-changed.outputs.result == 'true' }}
+      if: "${{ steps.service-changed.outputs.result == 'true' }}"
       uses: actions/setup-java@v2.5.0
       with:
         distribution: zulu
@@ -68,17 +68,17 @@ jobs:
         cache: gradle
 
     - name: Copy CI gradle.properties
-      if: ${{ steps.service-changed.outputs.result == 'true' }}
+      if: "${{ steps.service-changed.outputs.result == 'true' }}"
       run: mkdir -p ~/.gradle ; cp .github/ci-gradle.properties ~/.gradle/gradle.properties
 
     - name: Run unit tests
-      if: ${{ steps.service-changed.outputs.result == 'true' }}
+      if: "${{ steps.service-changed.outputs.result == 'true' }}"
       uses: gradle/gradle-build-action@v2.1.3
       with:
         arguments: --no-configuration-cache test -PslimTests
 
     - name: (Fail-only) Upload test report
-      if: failure()
+      if: "${{ failure() }}"
       uses: actions/upload-artifact@v2.3.1
       with:
           name: Test report
@@ -102,7 +102,7 @@ jobs:
           return await script({github, context})
 
     - name: Set up JDK
-      if: ${{ steps.service-changed.outputs.result == 'true' }}
+      if: "${{ steps.service-changed.outputs.result == 'true' }}"
       uses: actions/setup-java@v2.5.0
       with:
         distribution: zulu
@@ -110,11 +110,11 @@ jobs:
         cache: gradle
 
     - name: Copy CI gradle.properties
-      if: ${{ steps.service-changed.outputs.result == 'true' }}
+      if: "${{ steps.service-changed.outputs.result == 'true' }}"
       run: mkdir -p ~/.gradle ; cp .github/ci-gradle.properties ~/.gradle/gradle.properties
 
     - name: Build debug APKs
-      if: ${{ steps.service-changed.outputs.result == 'true' }}
+      if: "${{ steps.service-changed.outputs.result == 'true' }}"
       uses: gradle/gradle-build-action@v2.1.3
       with:
         arguments: --no-configuration-cache assembleFreeDebug assembleNonFreeDebug
@@ -137,7 +137,7 @@ jobs:
           return await script({github, context})
 
     - name: Set up JDK
-      if: ${{ steps.service-changed.outputs.result == 'true' }}
+      if: "${{ steps.service-changed.outputs.result == 'true' }}"
       uses: actions/setup-java@v2.5.0
       with:
         distribution: zulu
@@ -145,11 +145,11 @@ jobs:
         cache: gradle
 
     - name: Copy CI gradle.properties
-      if: ${{ steps.service-changed.outputs.result == 'true' }}
+      if: "${{ steps.service-changed.outputs.result == 'true' }}"
       run: mkdir -p ~/.gradle ; cp .github/ci-gradle.properties ~/.gradle/gradle.properties
 
     - name: Check library API
-      if: ${{ steps.service-changed.outputs.result == 'true' }}
+      if: "${{ steps.service-changed.outputs.result == 'true' }}"
       uses: gradle/gradle-build-action@v2.1.3
       with:
         arguments: --no-configuration-cache apiCheck
@@ -172,7 +172,7 @@ jobs:
           return await script({github, context})
 
     - name: Set up JDK
-      if: ${{ steps.service-changed.outputs.result == 'true' }}
+      if: "${{ steps.service-changed.outputs.result == 'true' }}"
       uses: actions/setup-java@v2.5.0
       with:
         distribution: zulu
@@ -180,11 +180,11 @@ jobs:
         cache: gradle
 
     - name: Copy CI gradle.properties
-      if: ${{ steps.service-changed.outputs.result == 'true' }}
+      if: "${{ steps.service-changed.outputs.result == 'true' }}"
       run: mkdir -p ~/.gradle ; cp .github/ci-gradle.properties ~/.gradle/gradle.properties
 
     - name: Run Lint on debug variants
-      if: ${{ steps.service-changed.outputs.result == 'true' }}
+      if: "${{ steps.service-changed.outputs.result == 'true' }}"
       uses: gradle/gradle-build-action@v2.1.3
       with:
         arguments: --no-configuration-cache lintDebug

.github/workflows/sync_crowdin.yml

@@ -32,7 +32,7 @@ jobs:
 
       - name: Create Pull Request
         uses: peter-evans/create-pull-request@v3.12.1
-        if: env.UPDATED == 'true'
+        if: "env.UPDATED == 'true'"
         with:
           assignees: msfjarvis
           author: GitHub Actions <noreply@github.com>

.github/workflows/update_publicsuffix_data.yml

@@ -28,14 +28,14 @@ jobs:
 
       - name: Verify update publicsuffixes file
         uses: gradle/gradle-build-action@v2.1.3
-        if: env.UPDATED == "true"
+        if: "${{ env.UPDATED == 'true' }}"
         with:
           arguments: --no-configuration-cache :autofill-parser:test -PslimTests
 
       - name: Create Pull Request
         id: cpr
         uses: peter-evans/create-pull-request@v3.12.1
-        if: env.UPDATED == "true"
+        if: "${{ env.UPDATED == 'true' }}"
         with:
           assignees: msfjarvis
           author: GitHub Actions <noreply@github.com>
@@ -48,7 +48,7 @@ jobs:
           token: ${{ secrets.GITHUB_TOKEN }}
 
       - name: Close, re-open and enable squash merge for PR
-        if: steps.cpr.outputs.pull-request-operation == "created"
+        if: "${{ steps.cpr.outputs.pull-request-operation == 'created' }}"
         shell: bash
         run: |
           gh pr close "${PR_URL}"