kumi/Android-Password-Store
1
0
Fork 0
Code Issues 1 Pull requests 10 Projects Releases Packages Wiki Activity Actions

feat(build): remove Detekt

Browse source 
This no longer adds value for me and instead results in unnecessary
bikeshedding.
This commit is contained in:
Harsh Shandilya 2023-04-27 14:42:11 +05:30
parent 2b2c0860f8
commit f0ac9f97e2
No known key found for this signature in database
15 changed files with 4 additions and 923 deletions
Download patch file Download diff file Expand all files Collapse all files

1
build-logic/build.gradle.kts
View file

@ -91,7 +91,6 @@ gradlePlugin {
dependencies {
implementation(platform(libs.kotlin.bom))
implementation(libs.build.agp)
implementation(libs.build.detekt)
implementation(libs.build.diffutils)
implementation(libs.build.download)
implementation(libs.build.kotlin)

19
build-logic/src/main/kotlin/app/passwordstore/gradle/KotlinCommonPlugin.kt
View file

@ -5,17 +5,13 @@
package app.passwordstore.gradle
import io.gitlab.arturbosch.detekt.DetektPlugin
import io.gitlab.arturbosch.detekt.extensions.DetektExtension
import org.gradle.api.JavaVersion
import org.gradle.api.Plugin
import org.gradle.api.Project
import org.gradle.api.tasks.compile.JavaCompile
import org.gradle.api.tasks.testing.Test
import org.gradle.api.tasks.testing.logging.TestLogEvent
import org.gradle.kotlin.dsl.configure
import org.gradle.kotlin.dsl.withType
import org.gradle.language.base.plugins.LifecycleBasePlugin
import org.jetbrains.kotlin.gradle.dsl.JvmTarget
import org.jetbrains.kotlin.gradle.dsl.KotlinVersion
import org.jetbrains.kotlin.gradle.tasks.KotlinCompile
@ -25,22 +21,7 @@ class KotlinCommonPlugin : Plugin<Project> {
override fun apply(project: Project) {
val isAppModule = project.pluginManager.hasPlugin("com.android.application")
project.pluginManager.apply(DetektPlugin::class.java)
project.extensions.configure<DetektExtension> {
parallel = true
ignoredBuildTypes = listOf("release")
ignoredFlavors = listOf("free")
basePath = project.layout.projectDirectory.toString()
baseline =
project.rootProject.layout.projectDirectory
.dir("detekt-baselines")
.file("${project.name}.xml")
.asFile
}
project.tasks.run {
project.pluginManager.withPlugin("base") {
named(LifecycleBasePlugin.CHECK_TASK_NAME).configure { this.dependsOn(named("detekt")) }
}
withType<JavaCompile>().configureEach {
sourceCompatibility = JavaVersion.VERSION_11.toString()
targetCompatibility = JavaVersion.VERSION_11.toString()