From d103d6d4ba6638b163b75929c15bb2fe801539a3 Mon Sep 17 00:00:00 2001 From: Harsh Shandilya Date: Sun, 17 May 2020 01:14:09 +0530 Subject: [PATCH] Add tests for GitServerConfigActivity (#783) * Add tests for GitServerConfigActivity * github: disable animations before running UI tests Signed-off-by: Harsh Shandilya --- .github/workflows/pull_request.yml | 6 +- .../git/GitServerConfigActivityTest.kt | 127 ++++++++++++++++++ 2 files changed, 132 insertions(+), 1 deletion(-) create mode 100644 app/src/androidTest/java/com/zeapo/pwdstore/git/GitServerConfigActivityTest.kt diff --git a/.github/workflows/pull_request.yml b/.github/workflows/pull_request.yml index 826e0ff5..7d80d3a5 100644 --- a/.github/workflows/pull_request.yml +++ b/.github/workflows/pull_request.yml @@ -59,4 +59,8 @@ jobs: with: api-level: ${{ matrix.api-level }} target: default - script: ./gradlew connectedCheck + script: | + adb shell settings put global animator_duration_scale 0 + adb shell settings put global transition_animation_scale 0 + adb shell settings put global window_animation_scale 0 + ./gradlew connectedCheck diff --git a/app/src/androidTest/java/com/zeapo/pwdstore/git/GitServerConfigActivityTest.kt b/app/src/androidTest/java/com/zeapo/pwdstore/git/GitServerConfigActivityTest.kt new file mode 100644 index 00000000..8bfd759c --- /dev/null +++ b/app/src/androidTest/java/com/zeapo/pwdstore/git/GitServerConfigActivityTest.kt @@ -0,0 +1,127 @@ +/* + * Copyright © 2014-2020 The Android Password Store Authors. All Rights Reserved. + * SPDX-License-Identifier: GPL-3.0-only + */ + +package com.zeapo.pwdstore.git + +import android.view.View +import android.widget.RadioGroup +import androidx.test.espresso.Espresso.onView +import androidx.test.espresso.UiController +import androidx.test.espresso.ViewAction +import androidx.test.espresso.action.ViewActions.replaceText +import androidx.test.espresso.matcher.ViewMatchers.isEnabled +import androidx.test.espresso.matcher.ViewMatchers.withId +import androidx.test.ext.junit.runners.AndroidJUnit4 +import androidx.test.rule.ActivityTestRule +import com.google.android.material.button.MaterialButtonToggleGroup +import com.zeapo.pwdstore.R +import com.zeapo.pwdstore.git.BaseGitActivity.GitUpdateUrlResult +import org.hamcrest.Matcher +import org.junit.Rule +import org.junit.Test +import org.junit.runner.RunWith +import kotlin.test.assertEquals + +@RunWith(AndroidJUnit4::class) +class GitServerConfigActivityTest { + + @Rule + @JvmField + val activityRule = ActivityTestRule(GitServerConfigActivity::class.java, true) + + private val activity get() = activityRule.activity + + @Test + fun invalidValuesFailPredictably() { + setDefaultSshValues() + onView(withId(R.id.server_port)).perform(replaceText("69420")) + assertEquals(activity.updateUrl(), GitUpdateUrlResult.CustomPortRequiresAbsoluteUrlError) + + setDefaultSshValues() + onView(withId(R.id.server_url)).perform(replaceText("")) + assertEquals(activity.updateUrl(), GitUpdateUrlResult.EmptyHostnameError) + + setDefaultSshValues() + onView(withId(R.id.server_port)).perform(replaceText("xyz_is_not_a_port")) + assertEquals(activity.updateUrl(), GitUpdateUrlResult.NonNumericPortError) + + setDefaultHttpsValues() + onView(withId(R.id.server_port)).perform(replaceText("xyz_is_not_a_port")) + assertEquals(activity.updateUrl(), GitUpdateUrlResult.NonNumericPortError) + + setDefaultHttpsValues() + onView(withId(R.id.server_url)).perform(replaceText("")) + assertEquals(activity.updateUrl(), GitUpdateUrlResult.EmptyHostnameError) + } + + @Test + fun urlIsConstructedCorrectly() { + setDefaultSshValues() + activity.updateUrl() + assertEquals("john_doe@github.com:john_doe/my_secret_repository", activity.url) + + setDefaultSshValues() + onView(withId(R.id.server_port)).perform(replaceText("69420")) + onView(withId(R.id.server_url)).perform(replaceText("192.168.0.102")) + onView(withId(R.id.server_path)).perform(replaceText("/home/john_doe/my_secret_repository")) + activity.updateUrl() + assertEquals("ssh://john_doe@192.168.0.102:69420/home/john_doe/my_secret_repository", activity.url) + + setDefaultHttpsValues() + activity.updateUrl() + assertEquals("https://github.com/john_doe/my_secret_repository", activity.url) + + setDefaultHttpsValues() + onView(withId(R.id.server_port)).perform(replaceText("69420")) + onView(withId(R.id.server_url)).perform(replaceText("192.168.0.102")) + onView(withId(R.id.server_path)).perform(replaceText("/home/john_doe/my_secret_repository")) + activity.updateUrl() + assertEquals("https://192.168.0.102:69420/home/john_doe/my_secret_repository", activity.url) + } + + private fun callMethod(message: String = "", viewMethod: (view: T) -> Unit): ViewAction { + return object : ViewAction { + override fun getDescription(): String { + return if (message.isBlank()) viewMethod.toString() else message + } + + override fun getConstraints(): Matcher { + return isEnabled() + } + + @Suppress("UNCHECKED_CAST") + override fun perform(uiController: UiController?, view: View?) { + viewMethod(view!! as T) + } + + } + } + + private fun setDefaultHttpsValues() { + onView(withId(R.id.clone_protocol_group)).perform(callMethod { + it.check(R.id.clone_protocol_https) + }) + onView(withId(R.id.connection_mode_group)).perform(callMethod { + it.check(R.id.connection_mode_password) + }) + onView(withId(R.id.server_path)).perform(replaceText("john_doe/my_secret_repository")) + onView(withId(R.id.server_port)).perform(replaceText("")) + onView(withId(R.id.server_url)).perform(replaceText("github.com")) + onView(withId(R.id.server_user)).perform(replaceText("john_doe")) + } + + private fun setDefaultSshValues() { + onView(withId(R.id.clone_protocol_group)).perform(callMethod { + it.check(R.id.clone_protocol_ssh) + }) + onView(withId(R.id.connection_mode_group)).perform(callMethod { + it.check(R.id.connection_mode_ssh_key) + }) + onView(withId(R.id.server_path)).perform(replaceText("john_doe/my_secret_repository")) + onView(withId(R.id.server_port)).perform(replaceText("")) + onView(withId(R.id.server_url)).perform(replaceText("github.com")) + onView(withId(R.id.server_user)).perform(replaceText("john_doe")) + } +}