From bfd51efca44c0ed565e9cf45bd64a3f0de3385ed Mon Sep 17 00:00:00 2001
From: Harsh Shandilya <me@msfjarvis.dev>
Date: Wed, 12 Jul 2023 15:33:59 +0530
Subject: [PATCH] feat(build): target API 34

---
 app/src/main/AndroidManifest.xml                              | 2 ++
 app/src/main/java/app/passwordstore/Application.kt            | 2 +-
 .../src/main/kotlin/app/passwordstore/gradle/AndroidCommon.kt | 4 ++--
 3 files changed, 5 insertions(+), 3 deletions(-)

diff --git a/app/src/main/AndroidManifest.xml b/app/src/main/AndroidManifest.xml
index 19bd6845..0c76d6bf 100644
--- a/app/src/main/AndroidManifest.xml
+++ b/app/src/main/AndroidManifest.xml
@@ -105,10 +105,12 @@
     <service
       android:name=".util.services.ClipboardService"
       android:exported="false"
+      android:foregroundServiceType="shortService"
       android:process=":clipboard_service_process" />
     <service
       android:name=".util.services.PasswordExportService"
       android:exported="false"
+      android:foregroundServiceType="shortService"
       android:process=":password_export_service_process" />
     <service
       android:name=".util.services.OreoAutofillService"
diff --git a/app/src/main/java/app/passwordstore/Application.kt b/app/src/main/java/app/passwordstore/Application.kt
index 45bdc5e6..9c7fe39a 100644
--- a/app/src/main/java/app/passwordstore/Application.kt
+++ b/app/src/main/java/app/passwordstore/Application.kt
@@ -81,7 +81,7 @@ class Application : android.app.Application(), SharedPreferences.OnSharedPrefere
     super.onTerminate()
   }
 
-  override fun onSharedPreferenceChanged(prefs: SharedPreferences, key: String) {
+  override fun onSharedPreferenceChanged(prefs: SharedPreferences, key: String?) {
     if (key == PreferenceKeys.APP_THEME) {
       setNightMode()
     }
diff --git a/build-logic/src/main/kotlin/app/passwordstore/gradle/AndroidCommon.kt b/build-logic/src/main/kotlin/app/passwordstore/gradle/AndroidCommon.kt
index f3fe5a95..c1311f41 100644
--- a/build-logic/src/main/kotlin/app/passwordstore/gradle/AndroidCommon.kt
+++ b/build-logic/src/main/kotlin/app/passwordstore/gradle/AndroidCommon.kt
@@ -16,10 +16,10 @@ import org.gradle.kotlin.dsl.withType
 object AndroidCommon {
   fun configure(project: Project) {
     project.extensions.configure<TestedExtension> {
-      setCompileSdkVersion(33)
+      compileSdkVersion(34)
       defaultConfig {
         minSdk = 26
-        targetSdk = 33
+        targetSdk = 34
       }
 
       packagingOptions {