From a723ded00fdc902fdc9fea9f14fc6ce187802e23 Mon Sep 17 00:00:00 2001 From: Harsh Shandilya Date: Fri, 31 Dec 2021 09:33:50 +0530 Subject: [PATCH] Revert "autofill-parser: remove Bromite from supported browsers (#1423)" (#1632) This reverts commit 3f20678d799e15e21d1b7f013bc3672270f0d20f. --- CHANGELOG.md | 1 - app/src/main/res/xml/oreo_autofill_service.xml | 1 + autofill-parser/CHANGELOG.md | 4 +--- .../autofillparser/FeatureAndTrustDetection.kt | 2 ++ 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 2c7d2018..2d61673c 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -31,7 +31,6 @@ All notable changes to this project will be documented in this file. - The settings UI has been completely re-done to dramatically improve discoverability and navigation for users - Using the `git://` protocol in the server URL now presents an explicit discouragement rather than a generic error - Encrypted data is no longer ASCII armored, bringing it in line with `pass` -- Removed Bromite from supported Autofill browsers, since they [disable Android autofill](https://github.com/bromite/bromite/blob/master/FAQ.md#does-bromite-support-the-android-autofill-framework). - Changing password generator parameters now automatically updates the password without needing to press the 'Generate' button again - The app UI was reskinned to match Google's Material You guidelines - Using HTTPS without authentication is now fully supported, and no longer asks for a username diff --git a/app/src/main/res/xml/oreo_autofill_service.xml b/app/src/main/res/xml/oreo_autofill_service.xml index 5c442ca1..e2047e67 100644 --- a/app/src/main/res/xml/oreo_autofill_service.xml +++ b/app/src/main/res/xml/oreo_autofill_service.xml @@ -15,6 +15,7 @@ + diff --git a/autofill-parser/CHANGELOG.md b/autofill-parser/CHANGELOG.md index cc86f037..afe7564f 100644 --- a/autofill-parser/CHANGELOG.md +++ b/autofill-parser/CHANGELOG.md @@ -6,14 +6,12 @@ All notable changes to this project will be documented in this file. ### Changed -- Changed the support level for Chrome Beta/Canary/Dev/Stable and Ungoogled Chromium to `PasswordFillAndSaveIfNoAccessibility`. +- Changed the support level for Chrome Beta/Canary/Dev/Stable, Bromite and Ungoogled Chromium to `PasswordFillAndSaveIfNoAccessibility`. - Updated `androidx.annotation` to 1.1.0 and `androidx.autofill` to `1.2.0-alpha01`. - The library now requires Kotlin 1.5.0 configured with `kotlinOptions.languageVersion = "1.5"`. -- Removed Bromite from supported Autofill browsers, since they [disable Android autofill](https://github.com/bromite/bromite/blob/master/FAQ.md#does-bromite-support-the-android-autofill-framework). - - Added [Styx](https://github.com/jamal2362/Styx) to supported Autofill browsers. ### Fixed diff --git a/autofill-parser/src/main/java/com/github/androidpasswordstore/autofillparser/FeatureAndTrustDetection.kt b/autofill-parser/src/main/java/com/github/androidpasswordstore/autofillparser/FeatureAndTrustDetection.kt index 0da52cf9..816491b2 100644 --- a/autofill-parser/src/main/java/com/github/androidpasswordstore/autofillparser/FeatureAndTrustDetection.kt +++ b/autofill-parser/src/main/java/com/github/androidpasswordstore/autofillparser/FeatureAndTrustDetection.kt @@ -72,6 +72,7 @@ private val TRUSTED_BROWSER_CERTIFICATE_HASH = "com.opera.mini.native" to arrayOf("V6y8Ul8bLr0ZGWzW8BQ5fMkQ/RiEHgroUP68Ph5ZP/I="), "com.opera.mini.native.beta" to arrayOf("V6y8Ul8bLr0ZGWzW8BQ5fMkQ/RiEHgroUP68Ph5ZP/I="), "com.opera.touch" to arrayOf("qtjiBNJNF3k0yc0MY8xqo4779CxKaVcJfiIQ9X+qZ6o="), + "org.bromite.bromite" to arrayOf("4e5c0HbXsNyEyytF+3i4bfLrOaO2xWuj3CkqXgw7lQQ="), "org.gnu.icecat" to arrayOf("wi2iuVvK/WYZUzd2g0Qzn9ef3kAisQURZ8U1WSMTkcM="), "org.mozilla.fenix" to arrayOf("UAR3kIjn+YjVvFzF+HmP6/T4zQhKGypG79TI7krq8hE="), "org.mozilla.fenix.nightly" to arrayOf("d+rEzu02r++6dheZMd1MwZWrDNVLrzVdIV57vdKOQCo="), @@ -160,6 +161,7 @@ private val BROWSER_SAVE_FLAG_IF_NO_ACCESSIBILITY = "com.chrome.beta" to SaveInfo.FLAG_SAVE_ON_ALL_VIEWS_INVISIBLE, "com.chrome.canary" to SaveInfo.FLAG_SAVE_ON_ALL_VIEWS_INVISIBLE, "com.chrome.dev" to SaveInfo.FLAG_SAVE_ON_ALL_VIEWS_INVISIBLE, + "org.bromite.bromite" to SaveInfo.FLAG_SAVE_ON_ALL_VIEWS_INVISIBLE, "org.ungoogled.chromium.stable" to SaveInfo.FLAG_SAVE_ON_ALL_VIEWS_INVISIBLE, )