Use remembered credential even if it is empty (#880)

* Use remembered credential even if it is empty

Should fix #875.

* .isNull() --> == null

* Update relnotes

Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>

* Reword relnotes

Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>

* 2019 it is

Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>

Co-authored-by: Harsh Shandilya <me@msfjarvis.dev>
(cherry picked from commit b60c5fb605)
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>

CHANGELOG.md

@@ -4,6 +4,10 @@ All notable changes to this project will be documented in this file.
 
 ## [Unreleased]
 
+### Fixed
+
+-   Remember passphrase option did not work with keys that had empty passphrases and were generated before 2019
+
 ### Added
 
 -   Add GNU IceCatMobile to the list of supported browsers for Autofill

app/src/main/java/com/zeapo/pwdstore/git/GitOperation.kt

@@ -67,7 +67,7 @@ private class GitOperationCredentialFinder(val callingActivity: Activity, val co
         val storedCredential = gitOperationPrefs.getString(credentialPref, null)
         if (isRetry)
             gitOperationPrefs.edit { remove(credentialPref) }
-        if (storedCredential.isNullOrEmpty()) {
+        if (storedCredential == null) {
             val layoutInflater = LayoutInflater.from(callingActivity)
 
             @SuppressLint("InflateParams")