kumi/Android-Password-Store
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 2

GitSettings: use runCatching to replace exception handling

Browse source 
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
This commit is contained in:
Harsh Shandilya 2020-09-05 20:31:28 +05:30
parent 83654896b6
commit 82c83a5bed
No known key found for this signature in database
GPG key ID: 366D7BBAD1031E80
1 changed files with 4 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
app/src/main/java/com/zeapo/pwdstore/git/config/GitSettings.kt
View file

@ -5,6 +5,8 @@
package com.zeapo.pwdstore.git.config
import androidx.core.content.edit
import com.github.michaelbull.result.getOrElse
import com.github.michaelbull.result.runCatching
import com.zeapo.pwdstore.Application
import com.zeapo.pwdstore.utils.PasswordRepository
import com.zeapo.pwdstore.utils.PreferenceKeys
@ -105,9 +107,9 @@ object GitSettings {
}
fun updateConnectionSettingsIfValid(newAuthMode: AuthMode, newUrl: String, newBranch: String): UpdateConnectionSettingsResult {
val parsedUrl = try {
val parsedUrl = runCatching {
URIish(newUrl)
} catch (_: Exception) {
}.getOrElse {
return UpdateConnectionSettingsResult.FailedToParseUrl
}
val newProtocol = when (parsedUrl.scheme) {