kumi/Android-Password-Store
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

Fix: Set childCount correctly on recycled rows (#675)

Browse source 
The childCount is not set explicitly for empty directories, which means
that the childCount of the entry from which the current row was
recycled is preserved. This results in empty directories being shown
with seemingly random child counts.

The fix is to always set text and visibility for the childCount view.

Co-authored-by: Harsh Shandilya <msfjarvis@gmail.com>
This commit is contained in:
Fabian Henneke 2020-03-27 09:58:41 +01:00 committed by GitHub
parent 0153d3215e
commit 791868f3d6
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
app/src/main/java/com/zeapo/pwdstore/ui/adapters/EntryRecyclerAdapter.kt
View file

@ -99,10 +99,8 @@ abstract class EntryRecyclerAdapter internal constructor(val values: ArrayList<P
!(!showHidden && (pathname.isDirectory && pathname.isHidden)) !(!showHidden && (pathname.isDirectory && pathname.isHidden))
} ?: emptyArray<File>() } ?: emptyArray<File>()
val childCount = children.size val childCount = children.size
if (childCount > 0) { holder.childCount.visibility = if (childCount > 0) View.VISIBLE else View.GONE
holder.childCount.visibility = View.VISIBLE holder.childCount.text = "$childCount"
holder.childCount.text = "$childCount"
}
} else { } else {
holder.typeImage.setImageResource(R.drawable.ic_action_secure_24dp) holder.typeImage.setImageResource(R.drawable.ic_action_secure_24dp)
val parentPath = pass.fullPathToParent.replace("(^/)|(/$)".toRegex(), "") val parentPath = pass.fullPathToParent.replace("(^/)|(/$)".toRegex(), "")