kumi/Android-Password-Store
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

refactor: use Closeable#use extension where applicable

Browse source
This commit is contained in:
Harsh Shandilya 2024-09-22 23:45:14 +05:30
parent 6a5e35a95c
commit 69513bf246
2 changed files with 3 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
app/src/main/java/app/passwordstore/util/services/PasswordExportService.kt
View file

@ -89,10 +89,7 @@ class PasswordExportService : Service() {
val destOutputStream = contentResolver.openOutputStream(targetPasswordFile.uri)
if (destOutputStream != null && sourceInputStream != null) {
sourceInputStream.copyTo(destOutputStream, 1024)
sourceInputStream.close()
destOutputStream.close()
sourceInputStream.use { source -> destOutputStream.use { dest -> source.copyTo(dest) } }
}
}
}

6
crypto/pgpainless/src/main/kotlin/app/passwordstore/crypto/PGPainlessCryptoHandler.kt
View file

@ -65,8 +65,7 @@ public class PGPainlessCryptoHandler @Inject constructor() :
.addDecryptionKeys(keyringCollection, protector)
.addDecryptionPassphrase(Passphrase.fromPassword(passphrase))
)
Streams.pipeAll(decryptionStream, outputStream)
decryptionStream.close()
decryptionStream.use { Streams.pipeAll(it, outputStream) }
return@runCatching
}
.mapError { error ->
@ -121,8 +120,7 @@ public class PGPainlessCryptoHandler @Inject constructor() :
.setAsciiArmor(options.isOptionEnabled(PGPEncryptOptions.ASCII_ARMOR))
val encryptionStream =
PGPainless.encryptAndOrSign().onOutputStream(outputStream).withOptions(producerOptions)
Streams.pipeAll(plaintextStream, encryptionStream)
encryptionStream.close()
encryptionStream.use { Streams.pipeAll(plaintextStream, it) }
val result = encryptionStream.result
publicKeyRingCollection.forEach { keyRing ->
require(result.isEncryptedFor(keyRing)) {