kumi/Android-Password-Store
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Workaround: Prevent fill-in datasets from being shown on Android… (#666)

Browse source
This commit is contained in:
Fabian Henneke 2020-03-26 10:03:54 +01:00 committed by GitHub
parent 8f722a2219
commit 5445899ab8
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 8 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
app/src/main/java/com/zeapo/pwdstore/autofill/oreo/Form.kt
View file

@ -213,7 +213,14 @@ class FillableForm private constructor(
): Dataset { ): Dataset {
val remoteView = makePlaceholderRemoteView(context) val remoteView = makePlaceholderRemoteView(context)
val scenario = AutofillScenario.fromBundle(clientState) val scenario = AutofillScenario.fromBundle(clientState)
return Dataset.Builder(remoteView).run { // Before Android P, Datasets used for fill-in had to come with a RemoteViews, even
// though they are never shown.
val builder = if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.P) {
Dataset.Builder()
} else {
Dataset.Builder(remoteView)
}
return builder.run {
if (scenario != null) fillWith(scenario, action, credentials) if (scenario != null) fillWith(scenario, action, credentials)
else e { "Failed to recover scenario from client state" } else e { "Failed to recover scenario from client state" }
build() build()