kumi/Android-Password-Store
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Allow unauthenticated HTTPS Git access (#1533)

Browse source
This commit is contained in:
Harsh Shandilya 2021-11-03 20:32:53 +05:30 committed by GitHub
parent 2cf3ddf2aa
commit 52f4ce06f5
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 4 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
CHANGELOG.md
View file

@ -32,6 +32,7 @@ All notable changes to this project will be documented in this file.
- Removed Bromite from supported Autofill browsers, since they [disable Android autofill](https://github.com/bromite/bromite/blob/master/FAQ.md#does-bromite-support-the-android-autofill-framework). - Removed Bromite from supported Autofill browsers, since they [disable Android autofill](https://github.com/bromite/bromite/blob/master/FAQ.md#does-bromite-support-the-android-autofill-framework).
- Changing password generator parameters now automatically updates the password without needing to press the 'Generate' button again - Changing password generator parameters now automatically updates the password without needing to press the 'Generate' button again
- The app UI was reskinned to match Google's Material You guidelines - The app UI was reskinned to match Google's Material You guidelines
- Using HTTPS without authentication is now fully supported, and no longer asks for a username
## [1.13.5] - 2021-07-28 ## [1.13.5] - 2021-07-28

4
app/src/main/java/dev/msfjarvis/aps/util/settings/GitSettings.kt
View file

@ -149,7 +149,9 @@ constructor(
in listOf("ssh", null) -> Protocol.Ssh in listOf("ssh", null) -> Protocol.Ssh
else -> return UpdateConnectionSettingsResult.FailedToParseUrl else -> return UpdateConnectionSettingsResult.FailedToParseUrl
} }
if (newAuthMode != AuthMode.None && parsedUrl.user.isNullOrBlank()) if ((newAuthMode != AuthMode.None && newProtocol != Protocol.Https) &&
parsedUrl.user.isNullOrBlank()
)
return UpdateConnectionSettingsResult.MissingUsername(newProtocol) return UpdateConnectionSettingsResult.MissingUsername(newProtocol)
val validHttpsAuth = listOf(AuthMode.None, AuthMode.Password) val validHttpsAuth = listOf(AuthMode.None, AuthMode.Password)
val validSshAuth = listOf(AuthMode.OpenKeychain, AuthMode.Password, AuthMode.SshKey) val validSshAuth = listOf(AuthMode.OpenKeychain, AuthMode.Password, AuthMode.SshKey)