From 39c7b0cb7bd512eb981c2cffa1f1507ceb06d0a3 Mon Sep 17 00:00:00 2001
From: Harsh Shandilya <me@msfjarvis.dev>
Date: Tue, 9 May 2023 00:13:09 +0530
Subject: [PATCH] fix: add warning to passphrase cache feature

---
 app/src/main/java/app/passwordstore/ui/settings/PGPSettings.kt | 3 ++-
 app/src/main/res/values/strings.xml                            | 3 ++-
 2 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/app/src/main/java/app/passwordstore/ui/settings/PGPSettings.kt b/app/src/main/java/app/passwordstore/ui/settings/PGPSettings.kt
index 7be4a268..e3c3e90c 100644
--- a/app/src/main/java/app/passwordstore/ui/settings/PGPSettings.kt
+++ b/app/src/main/java/app/passwordstore/ui/settings/PGPSettings.kt
@@ -33,7 +33,8 @@ class PGPSettings(private val activity: FragmentActivity) : SettingsProvider {
         persistent = true
       }
       switch(Feature.EnableGPGPassphraseCache.configKey) {
-        titleRes = R.string.pref_title_passphrase_cache
+        titleRes = R.string.pref_passphrase_cache_title
+        summaryRes = R.string.pref_passphrase_cache_summary
         defaultValue = false
       }
     }
diff --git a/app/src/main/res/values/strings.xml b/app/src/main/res/values/strings.xml
index e0a1d3b7..9dc739ad 100644
--- a/app/src/main/res/values/strings.xml
+++ b/app/src/main/res/values/strings.xml
@@ -134,6 +134,8 @@
   <string name="pref_import_pgp_key_title">Import PGP key</string>
   <string name="pref_pgp_key_manager_title">Key manager</string>
   <string name="pref_pgp_ascii_armor_title">Encrypt in ASCII armor mode</string>
+  <string name="pref_passphrase_cache_title">Enable passphrase caching</string>
+  <string name="pref_passphrase_cache_summary">WARNING: this feature is functional but very experimental.</string>
 
   <!-- PasswordGenerator fragment -->
   <string name="pwgen_title">Generate Password</string>
@@ -371,5 +373,4 @@
   <string name="pgp_key_manager_no_keys_guidance">Import a key using the add button below</string>
   <string name="no_keys_imported_dialog_title">No keys imported</string>
   <string name="no_keys_imported_dialog_message">There are no PGP keys imported in the app yet, press the button below to pick a key file</string>
-  <string name="pref_title_passphrase_cache">Enable passphrase caching</string>
 </resources>