kumi/Android-Password-Store
1
0
Fork 0
Code Issues 1 Pull requests 10 Projects Releases Packages Wiki Activity Actions

Open dialog immediately at activity oncreate, can't open it after asynctask (potential illegalstateexception)

Browse source
This commit is contained in:
Matthew Wong 2015-09-15 23:54:17 -04:00
parent 68e1495ef2
commit 394a549f7e
2 changed files with 13 additions and 10 deletions
Download patch file Download diff file Expand all files Collapse all files

8
app/src/main/java/com/zeapo/pwdstore/autofill/AutofillFragment.java
View file

@ -98,11 +98,11 @@ public class AutofillFragment extends DialogFragment {
editor.putString(packageName, path); editor.putString(packageName, path);
} }
editor.apply(); editor.apply();
int position = getArguments().getInt("position");
callingActivity.recyclerAdapter.notifyItemChanged(position);
if (getArguments().getBoolean("finish")) { // if recyclerAdapter has not loaded yet, there is no need to notifyItemChanged
callingActivity.finish(); if (callingActivity.recyclerAdapter != null) {
int position = callingActivity.recyclerAdapter.getPosition(packageName);
callingActivity.recyclerAdapter.notifyItemChanged(position);
} }
} }
}); });

15
app/src/main/java/com/zeapo/pwdstore/autofill/AutofillPreferenceActivity.java
View file

@ -32,7 +32,7 @@ public class AutofillPreferenceActivity extends AppCompatActivity {
private PackageManager pm; private PackageManager pm;
private boolean recreate; private boolean recreate; // flag for action on up press; origin autofill dialog? different act
@Override @Override
public void onCreate(Bundle savedInstanceState) { public void onCreate(Bundle savedInstanceState) {
@ -49,6 +49,14 @@ public class AutofillPreferenceActivity extends AppCompatActivity {
new populateTask().execute(); new populateTask().execute();
recreate = false;
Bundle extras = getIntent().getExtras();
if (extras != null) {
recreate = true;
showDialog(extras.getString("packageName"), extras.getString("appName"));
}
setTitle("Autofill Apps"); setTitle("Autofill Apps");
} }
@ -79,13 +87,9 @@ public class AutofillPreferenceActivity extends AppCompatActivity {
findViewById(R.id.progress_bar).setVisibility(View.GONE); findViewById(R.id.progress_bar).setVisibility(View.GONE);
recyclerView.setAdapter(recyclerAdapter); recyclerView.setAdapter(recyclerAdapter);
recreate = false;
Bundle extras = getIntent().getExtras(); Bundle extras = getIntent().getExtras();
if (extras != null) { if (extras != null) {
recreate = true;
recyclerView.scrollToPosition(recyclerAdapter.getPosition(extras.getString("packageName"))); recyclerView.scrollToPosition(recyclerAdapter.getPosition(extras.getString("packageName")));
showDialog(extras.getString("packageName"), extras.getString("appName"));
} }
} }
} }
@ -139,7 +143,6 @@ public class AutofillPreferenceActivity extends AppCompatActivity {
Bundle args = new Bundle(); Bundle args = new Bundle();
args.putString("packageName", packageName); args.putString("packageName", packageName);
args.putString("appName", appName); args.putString("appName", appName);
args.putInt("position", recyclerAdapter.getPosition(packageName));
df.setArguments(args); df.setArguments(args);
df.show(getFragmentManager(), "autofill_dialog"); df.show(getFragmentManager(), "autofill_dialog");
} }