kumi/Android-Password-Store
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Clear clipboard 20 times fix (#423)

Browse source 
* Fix clear clipboard 20 times

As described in issue #419 there was a bug when clearing clipboard 20 times because from "0" to "< 19" there are 19 numbers, not 20. 19 is never reached because of "less than" operator. This could be also fixed by changing the operator from "=" to "<=" but I think is better to change the number of times to 20.

* Fixed clear clipboard 20 times hint

Fixed the hint to match what really happens, consecutive numbers are stored in the clipboard 20 times.
This commit is contained in:
alexlab2017 2018-09-11 10:53:55 +02:00 committed by Mohamed Zenadi
parent dd43545c4c
commit 270ab889b0
2 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
app/src/main/java/com/zeapo/pwdstore/autofill/AutofillService.java
View file

@ -620,7 +620,7 @@ public class AutofillService extends AccessibilityService {
clip = ClipData.newPlainText("autofill_pm", ""); clip = ClipData.newPlainText("autofill_pm", "");
clipboard.setPrimaryClip(clip); clipboard.setPrimaryClip(clip);
if (settings.getBoolean("clear_clipboard_20x", false)) { if (settings.getBoolean("clear_clipboard_20x", false)) {
for (int i = 0; i < 19; i++) { for (int i = 0; i < 20; i++) {
clip = ClipData.newPlainText(String.valueOf(i), String.valueOf(i)); clip = ClipData.newPlainText(String.valueOf(i), String.valueOf(i));
clipboard.setPrimaryClip(clip); clipboard.setPrimaryClip(clip);
} }

2
app/src/main/res/values/strings.xml
View file

@ -138,7 +138,7 @@
<string name="pref_autofill_always_title">Always show dialog</string> <string name="pref_autofill_always_title">Always show dialog</string>
<string name="pref_misc_title">Misc</string> <string name="pref_misc_title">Misc</string>
<string name="pref_clear_clipboard_title">Clear clipboard 20 times</string> <string name="pref_clear_clipboard_title">Clear clipboard 20 times</string>
<string name="pref_clear_clipboard_hint">Store nonsense in the clipboard 20 times instead of just once. Useful on Samsung phones that feature clipboard history.</string> <string name="pref_clear_clipboard_hint">Store consecutive numbers in the clipboard 20 times. Useful on Samsung phones that feature clipboard history.</string>
<string name="pref_git_delete_repo_summary">Deletes local (hidden) repository</string> <string name="pref_git_delete_repo_summary">Deletes local (hidden) repository</string>
<string name="pref_external_repository">External repository</string> <string name="pref_external_repository">External repository</string>
<string name="pref_external_repository_summary">Use an external password repository</string> <string name="pref_external_repository_summary">Use an external password repository</string>