Migrate namespaces to Gradle (#1805)

* ui-compose: update Gradle configuration

* gradle: fix namespace for a couple astray Compose dependencies

* all: switch to Gradle namespace property

Mirrors a similar change from AndroidX dcfa035a96

app/build.gradle.kts

@@ -35,6 +35,8 @@ android {
     testInstrumentationRunner = "androidx.test.runner.AndroidJUnitRunner"
   }
 
+  namespace = "dev.msfjarvis.aps"
+
   lint {
     abortOnError = true
     checkReleaseBuilds = false

app/src/main/AndroidManifest.xml

@@ -5,7 +5,6 @@
 
 <manifest xmlns:android="http://schemas.android.com/apk/res/android"
   xmlns:tools="http://schemas.android.com/tools"
-  package="dev.msfjarvis.aps"
   android:installLocation="auto">
 
   <uses-permission android:name="android.permission.INTERNET" />

autofill-parser/build.gradle.kts

@@ -13,6 +13,7 @@ plugins {
 android {
   defaultConfig { consumerProguardFiles("consumer-rules.pro") }
   sourceSets { getByName("test") { resources.srcDir("src/main/assets") } }
+  namespace = "com.github.androidpasswordstore.autofillparser"
 }
 
 dependencies {

autofill-parser/src/main/AndroidManifest.xml

@@ -3,4 +3,4 @@
   ~ SPDX-License-Identifier: LGPL-3.0-only WITH LGPL-3.0-linking-exception
   -->
 
-<manifest package="com.github.androidpasswordstore.autofillparser"></manifest>
+<manifest />

gradle/libs.versions.toml

@@ -21,12 +21,10 @@ androidx-annotation = "androidx.annotation:annotation:1.3.0"
 androidx-appcompat = "androidx.appcompat:appcompat:1.4.1"
 androidx-autofill = "androidx.autofill:autofill:1.2.0-beta01"
 androidx-biometricKtx = "androidx.biometric:biometric-ktx:1.2.0-alpha04"
-androidx-compose-material3 = "androidx.compose.material3:material3:1.0.0-alpha08"
 androidx-constraintlayout = "androidx.constraintlayout:constraintlayout:2.1.3"
 androidx-core-ktx = "androidx.core:core-ktx:1.8.0-alpha06"
 androidx-documentfile = "androidx.documentfile:documentfile:1.1.0-alpha01"
 androidx-fragment-ktx = "androidx.fragment:fragment-ktx:1.4.1"
-androidx-hilt-compose = "androidx.hilt:hilt-navigation-compose:1.0.0"
 androidx-lifecycle-common = { module = "androidx.lifecycle:lifecycle-common", version.ref = "lifecycle" }
 androidx-lifecycle-livedataKtx = { module = "androidx.lifecycle:lifecycle-livedata-ktx", version.ref = "lifecycle" }
 androidx-lifecycle-viewmodel-compose = { module = "androidx.lifecycle:lifecycle-viewmodel-compose", version.ref = "lifecycle" }
@@ -61,7 +59,9 @@ compose-animation = { module = "androidx.compose.animation:animation", version.r
 compose-compiler = { module = "androidx.compose.compiler:compiler", version.ref = "compose" }
 compose-foundation-core = { module = "androidx.compose.foundation:foundation", version.ref = "compose" }
 compose-foundation-layout = { module = "androidx.compose.foundation:foundation-layout", version.ref = "compose" }
+compose-hilt = "androidx.hilt:hilt-navigation-compose:1.0.0"
 compose-material = { module = "androidx.compose.material:material", version.ref = "compose" }
+compose-material3 = "androidx.compose.material3:material3:1.0.0-alpha08"
 compose-runtime = { module = "androidx.compose.runtime:runtime", version.ref = "compose" }
 compose-ui-core = { module = "androidx.compose.ui:ui", version.ref = "compose" }
 compose-ui-test = { module = "androidx.compose.ui:ui-test-junit4", version.ref = "compose" }

openpgp-ktx/build.gradle.kts

@@ -11,8 +11,8 @@ plugins {
 
 android {
   defaultConfig { consumerProguardFiles("consumer-proguard-rules.pro") }
-
   buildFeatures.aidl = true
+  namespace = "me.msfjarvis.openpgpktx"
 }
 
 dependencies { implementation(libs.kotlin.coroutines.core) }

openpgp-ktx/src/main/AndroidManifest.xml

@@ -3,4 +3,4 @@
   ~ SPDX-License-Identifier: Apache-2.0
   -->
 
-<manifest package="me.msfjarvis.openpgpktx" />
+<manifest />

passgen/diceware/build.gradle.kts

@@ -9,7 +9,10 @@ plugins {
   id("com.github.android-password-store.kotlin-library")
 }
 
-android { sourceSets { getByName("test") { resources.srcDir("src/main/res/raw") } } }
+android {
+  sourceSets { getByName("test") { resources.srcDir("src/main/res/raw") } }
+  namespace = "dev.msfjarvis.aps.passgen.diceware"
+}
 
 dependencies {
   implementation(libs.dagger.hilt.core)

passgen/diceware/src/main/AndroidManifest.xml

@@ -3,4 +3,4 @@
   ~ SPDX-License-Identifier: LGPL-3.0-only WITH LGPL-3.0-linking-exception
   -->
 
-<manifest package="dev.msfjarvis.aps.passgen.diceware" />
+<manifest />

ui-compose/build.gradle.kts

@@ -4,14 +4,21 @@ plugins {
   id("com.github.android-password-store.kotlin-library")
 }
 
-dependencies {
+android {
-  implementation(libs.androidx.activity.compose)
+  buildFeatures {
-  implementation(libs.androidx.hilt.compose)
+    compose = true
-  implementation(libs.compose.foundation.core)
+    composeOptions {
-  implementation(libs.compose.foundation.layout)
+      useLiveLiterals = false
-  implementation(libs.compose.material)
+      kotlinCompilerExtensionVersion = libs.versions.compose.get()
-  implementation(libs.androidx.compose.material3)
+    }
-  implementation(libs.compose.ui.core)
+  }
-  implementation(libs.compose.ui.viewbinding)
+  namespace = "dev.msfjarvis.aps.ui.compose"
-  compileOnly(libs.compose.ui.tooling)
+}
+
+dependencies {
+  api(libs.compose.foundation.core)
+  api(libs.compose.foundation.layout)
+  api(libs.compose.material)
+  api(libs.compose.material3)
+  api(libs.compose.ui.core)
 }

ui-compose/src/main/AndroidManifest.xml

@@ -3,4 +3,4 @@
   ~ SPDX-License-Identifier: LGPL-3.0-only WITH LGPL-3.0-linking-exception
   -->
 
-<manifest package="dev.msfjarvis.aps.ui.compose" />
+<manifest />